[NXP] Add ICD _SetPollingInterval and set minimum ActiveModeThreshold to 5 seconds #33875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5 seconds
During initialization, the app would stuck in an assert if the app was configured
as a LIT ICD:
VerifyOrDieWithMsg(ICDConfigurationData::GetInstance().GetMinLitActiveModeThreshold() <=
ICDConfigurationData::GetInstance().GetActiveModeThreshold(),
AppServer, "The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds.");
Setting the default value of nxp_active_mode_threshold_ms to 5000ms fixes the issue.
Signed-off-by: marius-alex-tache <[email protected]>
…M function Signed-off-by: Chin-Ran Lo <[email protected]>
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #33875: Size comparison from dc8187b to 6ee1756 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jun 17, 2024
andy31415
added
fast track
changing-submodules-on-purpose
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
… to 5 seconds (project-chip#33875) * [NXP][common] The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds During initialization, the app would stuck in an assert if the app was configured as a LIT ICD: VerifyOrDieWithMsg(ICDConfigurationData::GetInstance().GetMinLitActiveModeThreshold() <= ICDConfigurationData::GetInstance().GetActiveModeThreshold(), AppServer, "The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds."); Setting the default value of nxp_active_mode_threshold_ms to 5000ms fixes the issue. Signed-off-by: marius-alex-tache <[email protected]> * [NXP][platform][common] Add the _SetPollingInterval for Wi-Fi SIT ICDM function Signed-off-by: Chin-Ran Lo <[email protected]> --------- Signed-off-by: marius-alex-tache <[email protected]> Signed-off-by: Chin-Ran Lo <[email protected]> Co-authored-by: marius-alex-tache <[email protected]> Co-authored-by: Chin-Ran Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the _SetPollingInterval for Wi-Fi SIT ICDM function, The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds.
During initialization, the app would stuck in an assert if the app was configured
as a LIT ICD:
VerifyOrDieWithMsg(ICDConfigurationData::GetInstance().GetMinLitActiveModeThreshold() <=
ICDConfigurationData::GetInstance().GetActiveModeThreshold(),
AppServer, "The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds.");
Setting the default value of nxp_active_mode_threshold_ms to 5000ms fixes the issue.