Rename src/app/interaction-model to src/app/data-model-interface and more updates on naming
#33847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
force-pushed
the
data_model_interfaces_renaming
branch
from
38448de to
70a1ccb
Compare
|
PR #33847: Size comparison from bd0422b to 70a1ccb Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
harimau-qirex
approved these changes
Jun 11, 2024
jmartinez-silabs
approved these changes
Jun 11, 2024
Alami-Amine
pushed a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Jun 12, 2024
| @@ -38,10 +38,10 @@ namespace InteractionModel { | |||
| /// thread or equivalent | |||
| /// - class is allowed to attempt to cache indexes/locations for faster | |||
| /// lookups of things (e.g during iterations) | |||
| class Model : public DataModelMetadataTree | |||
| class DataModel : public DataModelMetadataTree | |||
There was a problem hiding this comment.
So here is a question: why do we have InteractionModel::DataModel? These are sort of orthogonal things....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several renames to make code clearer (this is based on feedback from previous PRs).
Changes
Path renames
src/app/interaction-model->src/app/data-model-interfacesrc/app/codegen-interaction-model->src/app/codegen-data-modelClass renames
Model->DataModelEvents->EventsGeneratorPaths->DataModelChangeListener