[ICD] Add ClientType support to the ICDManager and ICD Management cluster #33811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
darwin
controller
app
tests
icd
|
PR #33811: Size comparison from c9bcd22 to 2e98bba Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
added
the
skip-protocol-compatibility
|
PR #33811: Size comparison from c9bcd22 to 3f83f31 Full report (16 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #33811: Size comparison from d4d9a99 to 15e2299 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
mkardous-silabs
force-pushed
the
feature/client_type
branch
from
69ace1e to
2a5dc2a
Compare
|
PR #33811: Size comparison from d4d9a99 to 2a5dc2a Full report (9 builds for cc32xx, mbed, nrfconnect, stm32, tizen)
|
mkardous-silabs
force-pushed
the
feature/client_type
branch
from
2a5dc2a to
dc5cfac
Compare
|
PR #33811: Size comparison from 17cda5a to dc5cfac Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
yunhanw-google
requested changes
Jun 10, 2024
mkardous-silabs
force-pushed
the
feature/client_type
branch
2 times, most recently
from
6a844ba to
11dbf8e
Compare
|
PR #33811: Size comparison from 17cda5a to 11dbf8e Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan and
carol-apple
-- Fix icd clienttype with integer and align with generated type for clientType in other generated file -- Fix missing semicolon in the end of ()Ljava/lang/Short
yunhanw-google
force-pushed
the
feature/client_type
branch
from
a86ed6d to
f712b2e
Compare
|
PR #33811: Size comparison from 28430f1 to f712b2e Full report (22 builds for cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #33811: Size comparison from 28430f1 to 73219c2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33811: Size comparison from 28430f1 to ea387fc Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33811: Size comparison from 28430f1 to 3053ee2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…ster (project-chip#33811) * update icdm xml * generated files * Add clientType to the ICDMonitoring table * Add client type buisness logic to ICDM cluster * Add client type logic to the ICDManager * finish clean up * make ClientType arg mandatory * regen --------- Co-authored-by: yunhanw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds support for the ClientType in the ICDManager and the ICD Management cluster.
Spec PR :
Test Plan PR to adapt ICDM 3.1 test case :
Drive by changes :
PairingCommand used the wrong node-id for the ICDClientInfo storage. Modified the command sending to use to use the CheckInNodeID.
Note to reviewers
PR seems very large but isn't in reality. Since the XML was updates, the generated files updates is present in this PR as well.
Tests