Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using MSEC_PER_SEC without directly including relevant headers. #33795

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Stop using MSEC_PER_SEC without directly including relevant headers. #33795

merged 1 commit into from
Jun 7, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

And stop doing time math by hand, use duration_cast.

Fixes #33793

@github-actions github-actions bot added the darwin label Jun 7, 2024
@bzbarsky-apple
Stop using MSEC_PER_SEC without directly including relevant headers.
d304a2e 
And stop doing time math by hand, use duration_cast.

Fixes project-chip#33793
@bzbarsky-apple bzbarsky-apple force-pushed the stop-using-msec_per_sec branch from 59347d5 to d304a2e Compare June 7, 2024 02:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

PR #33795: Size comparison from 3d7e23e to d304a2e

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 3d7e23e d304a2e change % change
bl602 lighting-app bl602 FLASH 1268040 1268040 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282316 1282318 2 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307254 1307254 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088680 1088680 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099372 1099374 2 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178504 1178504 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872112 872112 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1123798 1123798 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1075566 1075566 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1086826 1086828 2 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797872 797872 0 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813472 813472 0 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802776 802776 0 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755544 755544 0 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741184 741184 0 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604930 604930 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650398 650398 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661589 661589 0 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681441 681441 0 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681441 681441 0 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638377 638377 0 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603661 603661 0 0.0
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623305 623305 0 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623305 623305 0 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619277 619277 0 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639001 639001 0 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639001 639001 0 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587813 587813 0 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607657 607657 0 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607657 607657 0 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 888216 888216 0 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701328 701328 0 0.0
RAM 242724 242724 0 0.0
window-app BRD4187C FLASH 968492 968484 -8 -0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466358 1466358 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535559 1535559 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2532496 2532496 0 0.0
RAM 129104 129104 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568430 5568430 0 0.0
RAM 482216 482216 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052264 5052264 0 0.0
RAM 236792 236792 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4478024 4478024 0 0.0
RAM 216816 216816 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11519239 11519239 0 0.0
RAM 521762 521762 0 0.0
chip-tool-ipv6only arm64 unknown 17384 17384 0 0.0
FLASH 10667636 10667636 0 0.0
RAM 569744 569744 0 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11289287 11289287 0 0.0
RAM 515330 515330 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347608 4347608 0 0.0
RAM 208864 208864 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5366258 5366258 0 0.0
RAM 225424 225424 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4542904 4542904 0 0.0
RAM 204240 204240 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177816 4177816 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4302184 4302184 0 0.0
RAM 197712 197712 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2800173 2800173 0 0.0
RAM 154424 154424 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4150228 4150228 0 0.0
RAM 234616 234616 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5588664 5588664 0 0.0
RAM 344872 344872 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9568070 9568070 0 0.0
RAM 340288 340288 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497548 1497548 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873664 873664 0 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949208 949208 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822188 822188 0 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575652 575652 0 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590912 590912 0 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609624 609624 0 0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 673992 673992 0 0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610292 1610292 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534492 1534492 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460772 1460772 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462772 1462772 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650576 650576 0 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610276 610276 0 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472036 472036 0 0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625046 625046 0 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600864 600864 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770184 770184 0 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668176 668176 0 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626798 626798 0 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713688 713688 0 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558740 558740 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793506 793506 0 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 659986 659986 0 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 687174 687174 0 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 608998 608998 0 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599346 599346 0 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462618 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633192 633192 0 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642846 642846 0 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618248 618248 0 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464864 464864 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1556 1556 0 0.0
FLASH 1613824 1613824 0 0.0
RAM 45452 45452 0 0.0
chip-tool-ubsan arm unknown 2364 2364 0 0.0
FLASH 15638962 15638962 0 0.0
RAM 6828388 6828388 0 0.0

@mergify mergify bot merged commit dad6154 into project-chip:master Jun 7, 2024
68 checks passed
@bzbarsky-apple bzbarsky-apple deleted the stop-using-msec_per_sec branch June 7, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple approved these changes

@anush-apple anush-apple anush-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin review - approved
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.3] Building Darwin tool on latest commits giving error response
4 participants
@bzbarsky-apple @andy31415 @anush-apple @ksperling-apple