-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: possibility to get node id of the unsolicited message sender #33704
Merged
mergify
merged 1 commit into
project-chip:master
from
j0tunn:feat/pass.session.to.unsolicited.msg.handler
Jun 26, 2024
Merged
Feat: possibility to get node id of the unsolicited message sender #33704
mergify
merged 1 commit into
project-chip:master
from
j0tunn:feat/pass.session.to.unsolicited.msg.handler
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0tunn
changed the title
feat: possibility to get node id of the unsolicited message sender
Feat: possibility to get node id of the unsolicited message sender
Jun 3, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
June 3, 2024 07:57
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
June 3, 2024 07:57
PR #33704: Size comparison from 294dc18 to 6334f1e Increases (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (4 builds for linux, nxp)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Jun 8, 2024
andy31415
approved these changes
Jun 10, 2024
bauerschwan
approved these changes
Jun 11, 2024
j0tunn
force-pushed
the
feat/pass.session.to.unsolicited.msg.handler
branch
from
June 26, 2024 13:56
6334f1e
to
c5fe64b
Compare
PR #33704: Size comparison from 2829a87 to c5fe64b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to get peer node id in the in the
UnsolicitedMessageHandler
implementation.Usecase: parallel OTA sessions. We need to know node id of the bdx unsolicited message sender.
Current change is backwards compatible.