-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update network-commissioning to use AddResponse
for responding to scan responses
#33687
Merged
mergify
merged 14 commits into
project-chip:master
from
andy31415:update_command_handler_usage
Jun 1, 2024
Merged
Update network-commissioning to use AddResponse
for responding to scan responses
#33687
mergify
merged 14 commits into
project-chip:master
from
andy31415:update_command_handler_usage
Jun 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33687: Size comparison from b790232 to 1bfde15 Increases (60 builds for cc13x4_26x4, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (9 builds for esp32, linux, mbed, telink)
Full report (73 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33687: Size comparison from b790232 to 986a179 Increases (20 builds for efr32, linux, nrfconnect, nxp, psoc6, stm32)
Decreases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, qpg, stm32, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
May 31, 2024 19:35
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 31, 2024 19:35
PR #33687: Size comparison from b790232 to 3a99402 Increases (1 build for stm32)
Decreases (4 builds for mbed, qpg, stm32)
Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
jmartinez-silabs
approved these changes
May 31, 2024
PR #33687: Size comparison from b790232 to a10087b Increases (2 builds for nrfconnect, stm32)
Decreases (6 builds for mbed, nrfconnect, qpg, stm32)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
src/app/clusters/network-commissioning/network-commissioning.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/network-commissioning/network-commissioning.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/network-commissioning/network-commissioning.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/network-commissioning/network-commissioning.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/network-commissioning/network-commissioning.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
PR #33687: Size comparison from b790232 to 3b1d668 Increases (22 builds for efr32, linux, nrfconnect, nxp, psoc6, stm32)
Decreases (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, qpg, stm32, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some usages of seemingly internal API for CommandHandler. This makes the logic more safe because it starts taking advantage of CommandHandler built-in behavior:
Also fixed oddities in the code:
Tested: