-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Keep MTRCommissionableBrowser around until OnBleScanStopped #33674
Merged
woody-apple
merged 4 commits into
project-chip:master
from
ksperling-apple:mtrcommissionablebrowser-stop-uaf
May 30, 2024
Merged
Darwin: Keep MTRCommissionableBrowser around until OnBleScanStopped #33674
woody-apple
merged 4 commits into
project-chip:master
from
ksperling-apple:mtrcommissionablebrowser-stop-uaf
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksperling-apple
force-pushed
the
mtrcommissionablebrowser-stop-uaf
branch
from
May 29, 2024 23:44
3d08de3
to
ce73a04
Compare
anush-apple
reviewed
May 29, 2024
PR #33674: Size comparison from 90c5cd4 to ce73a04 Full report (3 builds for cc32xx, mbed)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
lazarkov and
lpbeliveau-silabs
May 30, 2024 00:05
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 30, 2024 00:05
PR #33674: Size comparison from 90c5cd4 to fa3936a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
|
anush-apple
approved these changes
May 30, 2024
PR #33674: Size comparison from 90c5cd4 to 0312ddb Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 30, 2024
PR #33674: Size comparison from 90c5cd4 to 99b6ba7 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (55 builds for bl602, bl702, bl702l, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, telink)
|
Because the BLE platform implementation uses a separate dispatch queue, StopBleScan() does not synchrnously stop any further use of the current BleScannerDelegate. Keep the MTRCommissionableBrowser that contains the delegate alive until OnBleScanStopped to avoid a UAF.
woody-apple
force-pushed
the
mtrcommissionablebrowser-stop-uaf
branch
from
May 30, 2024 16:07
99b6ba7
to
b6dff31
Compare
PR #33674: Size comparison from 201d5fa to b6dff31 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the BLE platform implementation uses a separate dispatch queue, StopBleScan() does not synchrnously stop any further use of the current BleScannerDelegate. Keep the MTRCommissionableBrowser that contains the delegate alive until OnBleScanStopped to avoid a UAF.