Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post merge review updates for CommandHandler updates #33658

Merged
merged 20 commits into from
May 29, 2024
Merged

Post merge review updates for CommandHandler updates #33658

merged 20 commits into from
May 29, 2024

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented May 29, 2024 •
edited
Loading

This addresses post-merge review comments in #33620.

Changes

  • Move TryAddResponseData into cpp file instead of h
  • move EncoderToTLV into DataModel (path and namespace) and rename DataModelEncoderToTLV to EncodableType (so that DataModel:: does not stutter)
  • removed inline hint for CommandHandler
  • Removed the ViaEncoder suffix to methods as method arguments are different
  • Various typo fixes in comments and updated some comment descriptions

@github-actions github-actions bot added the app label May 29, 2024
@andy31415 andy31415 marked this pull request as ready for review May 29, 2024 12:14
@pullapprove pullapprove bot requested a review from yunhanw-google May 29, 2024 12:14
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

PR #33658: Size comparison from fc3591d to 0cb9aba

Increases (2 builds for nrfconnect)
platform target config section fc3591d 0cb9aba change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 769516 769520 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 731204 731208 4 0.0
Decreases (2 builds for cc32xx)
platform target config section fc3591d 0cb9aba change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606462 -8 -0.0
.text 514144 514136 -8 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651742 -8 -0.0
.text 538540 538532 -8 -0.0
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
platform target config section fc3591d 0cb9aba change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606462 -8 -0.0
(read/write) 209716 209716 0 0.0
.bss 202932 202932 0 0.0
.data 1660 1660 0 0.0
.rodata 90206 90206 0 0.0
.text 514144 514136 -8 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651742 -8 -0.0
(read/write) 209972 209972 0 0.0
.bss 203328 203328 0 0.0
.data 1524 1524 0 0.0
.rodata 111086 111086 0 0.0
.text 538540 538532 -8 -0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535776 2535776 0 0.0
.bss 220928 220928 0 0.0
.data 5224 5224 0 0.0
.text 1498460 1498460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1058788 1058788 0 0.0
bss 139209 139209 0 0.0
rodata 102788 102788 0 0.0
text 769516 769520 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1235720 1235720 0 0.0
bss 137637 137637 0 0.0
rodata 152224 152224 0 0.0
text 795816 795816 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1006532 1006532 0 0.0
bss 138107 138107 0 0.0
rodata 90004 90004 0 0.0
text 731204 731208 4 0.0
qpg lighting-app qpg6105+debug (read/write) 838532 838532 0 0.0
.bss 103780 103780 0 0.0
.data 864 864 0 0.0
.text 649920 649920 0 0.0
lock-app qpg6105+debug (read/write) 798380 798380 0 0.0
.bss 98444 98444 0 0.0
.data 876 876 0 0.0
.text 609772 609772 0 0.0
stm32 light STM32WB5MM-DK (read/write) 622570 622570 0 0.0
.bss 141060 141060 0 0.0
.data 672 672 0 0.0
.rodata 82036 82036 0 0.0
.text 389184 389184 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

PR #33658: Size comparison from fc3591d to 642f666

Increases (17 builds for cc13x4_26x4, cyw30739, linux, nrfconnect, nxp, psoc6)
platform target config section fc3591d 642f666 change % change
cc13x4_26x4 lock-ftd LP_EM_CC1354P10_6 (read only) 813040 813056 16 0.0
.text 733432 733448 16 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740964 740972 8 0.0
.text 663640 663648 8 0.0
cyw30739 light CYW30739B2-P5-EVK-02 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678683 678691 8 0.0
.app_xip_area 602925 602933 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
lock CYW30739B2-P5-EVK-02 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
linux chip-tool-ipv6only arm64 (read only) 11514020 11514036 16 0.0
.rodata 361316 361332 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 769516 769520 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 731204 731208 4 0.0
nxp contact k32w1+release (read/write) 703780 703892 112 0.0
.text 590256 590368 112 0.0
light k32w1+release (read/write) 795560 795576 16 0.0
.text 673296 673312 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1824404 1824412 8 0.0
.text 1608804 1608812 8 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1745892 1745900 8 0.0
.text 1533388 1533396 8 0.0
lock cy8ckit_062s2_43012 (read/write) 1694740 1694748 8 0.0
.text 1461892 1461900 8 0.0
Decreases (12 builds for bl602, bl702, bl702l, cc32xx)
platform target config section fc3591d 642f666 change % change
bl602 lighting-app bl602 (read/write) 1444642 1444010 -632 -0.0
.text 1108552 1107914 -638 -0.1
bl602+mfd (read/write) 1459082 1458698 -384 -0.0
.text 1123870 1123488 -382 -0.0
bl602+rpc (read/write) 1492058 1491674 -384 -0.0
.text 1139942 1139560 -382 -0.0
bl702 lighting-app bl702 (read/write) 1210491 1210111 -380 -0.0
.text 978956 978574 -382 -0.0
bl702+mfd (read/write) 1221563 1220923 -640 -0.1
.text 990966 990328 -638 -0.1
bl702+rpc (read/write) 1301963 1301327 -636 -0.0
.text 1053664 1053026 -638 -0.1
bl706-eth (read/write) 1027837 1027457 -380 -0.0
.text 769760 769378 -382 -0.0
bl706-wifi (read/write) 1261750 1261134 -616 -0.0
.text 1000766 1000152 -614 -0.1
bl702l lighting-app bl702l (read/write) 1180084 1179444 -640 -0.1
.text 972086 971448 -638 -0.1
bl702l+mfd (read/write) 1191488 1190852 -636 -0.1
.text 984408 983770 -638 -0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606462 -8 -0.0
.text 514144 514136 -8 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651742 -8 -0.0
.text 538540 538532 -8 -0.0
Full report (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
platform target config section fc3591d 642f666 change % change
bl602 lighting-app bl602 (read/write) 1444642 1444010 -632 -0.0
.bss 85896 85896 0 0.0
.data 9512 9512 0 0.0
.rodata 160028 160028 0 0.0
.text 1108552 1107914 -638 -0.1
bl602+mfd (read/write) 1459082 1458698 -384 -0.0
.bss 86072 86072 0 0.0
.data 9488 9488 0 0.0
.rodata 158988 158988 0 0.0
.text 1123870 1123488 -382 -0.0
bl602+rpc (read/write) 1492058 1491674 -384 -0.0
.bss 93944 93944 0 0.0
.data 9896 9896 0 0.0
.rodata 167604 167604 0 0.0
.text 1139942 1139560 -382 -0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210491 1210111 -380 -0.0
.bss 11185 11185 0 0.0
.data 3712 3712 0 0.0
.rodata 109580 109580 0 0.0
.text 978956 978574 -382 -0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1221563 1220923 -640 -0.1
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 108520 108520 0 0.0
.text 990966 990328 -638 -0.1
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301963 1301327 -636 -0.0
.bss 19669 19669 0 0.0
.data 4256 4256 0 0.0
.rodata 124952 124952 0 0.0
.text 1053664 1053026 -638 -0.1
bl706-eth (read/write) 1027837 1027457 -380 -0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 102596 102596 0 0.0
.text 769760 769378 -382 -0.0
bl706-wifi (read/write) 1261750 1261134 -616 -0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 123716 123716 0 0.0
.text 1000766 1000152 -614 -0.1
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1180084 1179444 -640 -0.1
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 103584 103584 0 0.0
.text 972086 971448 -638 -0.1
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1191488 1190852 -636 -0.1
.bss 16572 16572 0 0.0
.data 5056 5056 0 0.0
.rodata 102524 102524 0 0.0
.text 984408 983770 -638 -0.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 797332 797332 0 0.0
(read/write) 177700 177700 0 0.0
.bss 99612 99612 0 0.0
.data 3604 3604 0 0.0
.rodata 85868 85868 0 0.0
.text 711200 711200 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813040 813056 16 0.0
(read/write) 188172 188172 0 0.0
.bss 110100 110100 0 0.0
.data 3596 3596 0 0.0
.rodata 79344 79344 0 0.0
.text 733432 733448 16 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 802380 802380 0 0.0
(read/write) 182292 182292 0 0.0
.bss 104220 104220 0 0.0
.data 3596 3596 0 0.0
.rodata 106668 106668 0 0.0
.text 695448 695448 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755292 755292 0 0.0
(read/write) 176644 176644 0 0.0
.bss 98336 98336 0 0.0
.data 3588 3588 0 0.0
.rodata 81276 81276 0 0.0
.text 673752 673752 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740964 740972 8 0.0
(read/write) 176884 176884 0 0.0
.bss 98576 98576 0 0.0
.data 3588 3588 0 0.0
.rodata 77060 77060 0 0.0
.text 663640 663648 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606462 -8 -0.0
(read/write) 209716 209716 0 0.0
.bss 202932 202932 0 0.0
.data 1660 1660 0 0.0
.rodata 90206 90206 0 0.0
.text 514144 514136 -8 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651742 -8 -0.0
(read/write) 209972 209972 0 0.0
.bss 203328 203328 0 0.0
.data 1524 1524 0 0.0
.rodata 111086 111086 0 0.0
.text 538540 538532 -8 -0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 740491 740491 0 0.0
.app_xip_area 660437 660437 0 0.0
.bss 73652 73652 0 0.0
.data 940 940 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 712347 712347 0 0.0
.app_xip_area 637225 637225 0 0.0
.bss 68776 68776 0 0.0
.data 884 884 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678683 678691 8 0.0
.app_xip_area 602925 602933 8 0.0
.bss 69236 69236 0 0.0
.data 1060 1060 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 697043 697043 0 0.0
.app_xip_area 618269 618269 0 0.0
.bss 72284 72284 0 0.0
.data 1028 1028 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 659795 659795 0 0.0
.app_xip_area 587053 587053 0 0.0
.bss 66444 66444 0 0.0
.data 836 836 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 682271 682271 0 0.0
.app_xip_area 606897 606897 0 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 682271 682271 0 0.0
.app_xip_area 606897 606897 0 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
linux chip-tool-ipv6only arm64 (read only) 11514020 11514036 16 0.0
(read/write) 592320 592320 0 0.0
.bss 104152 104152 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 458064 458064 0 0.0
.dynamic 512 512 0 0.0
.got 17288 17288 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 361316 361332 16 0.0
.text 10266008 10266008 0 0.0
thermostat-no-ble arm64 (read only) 4491676 4491676 0 0.0
(read/write) 250472 250472 0 0.0
.bss 123144 123144 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 106768 106768 0 0.0
.dynamic 512 512 0 0.0
.got 9144 9144 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 162516 162516 0 0.0
.text 3985768 3985768 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535776 2535776 0 0.0
.bss 220928 220928 0 0.0
.data 5224 5224 0 0.0
.text 1498460 1498460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1058788 1058788 0 0.0
bss 139209 139209 0 0.0
rodata 102788 102788 0 0.0
text 769516 769520 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1235720 1235720 0 0.0
bss 137637 137637 0 0.0
rodata 152224 152224 0 0.0
text 795816 795816 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1006532 1006532 0 0.0
bss 138107 138107 0 0.0
rodata 90004 90004 0 0.0
text 731204 731208 4 0.0
nxp contact k32w0+release (read only) 575876 575876 0 0.0
(read/write) 83212 83212 0 0.0
.bss 67920 67920 0 0.0
.data 2204 2204 0 0.0
.text 575340 575340 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703780 703892 112 0.0
.bss 71272 71272 0 0.0
.data 2872 2872 0 0.0
.text 590256 590368 112 0.0
light k32w0+release (read only) 609768 609768 0 0.0
(read/write) 82696 82696 0 0.0
.bss 67376 67376 0 0.0
.data 2224 2224 0 0.0
.text 609232 609232 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795560 795576 16 0.0
.bss 80816 80816 0 0.0
.data 2080 2080 0 0.0
.text 673296 673312 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826128 826128 0 0.0
(read/write) 1824404 1824412 8 0.0
.bss 204460 204460 0 0.0
.data 2752 2752 0 0.0
.text 1608804 1608812 8 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829224 829224 0 0.0
(read/write) 1745892 1745900 8 0.0
.bss 201388 201388 0 0.0
.data 2728 2728 0 0.0
.text 1533388 1533396 8 0.0
light cy8ckit_062s2_43012 (read only) 835944 835944 0 0.0
(read/write) 1665548 1665548 0 0.0
.bss 194852 194852 0 0.0
.data 2544 2544 0 0.0
.text 1459764 1459764 0 0.0
lock cy8ckit_062s2_43012 (read only) 808880 808880 0 0.0
(read/write) 1694740 1694748 8 0.0
.bss 221932 221932 0 0.0
.data 2528 2528 0 0.0
.text 1461892 1461900 8 0.0
qpg lighting-app qpg6105+debug (read/write) 838532 838532 0 0.0
.bss 103780 103780 0 0.0
.data 864 864 0 0.0
.text 649920 649920 0 0.0
lock-app qpg6105+debug (read/write) 798380 798380 0 0.0
.bss 98444 98444 0 0.0
.data 876 876 0 0.0
.text 609772 609772 0 0.0
stm32 light STM32WB5MM-DK (read/write) 622570 622570 0 0.0
.bss 141060 141060 0 0.0
.data 672 672 0 0.0
.rodata 82036 82036 0 0.0
.text 389184 389184 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

PR #33658: Size comparison from 6d51857 to 2ac70c0

Increases (31 builds for cc13x4_26x4, cyw30739, esp32, nrfconnect, nxp, telink)
platform target config section 6d51857 2ac70c0 change % change
cc13x4_26x4 lock-ftd LP_EM_CC1354P10_6 (read only) 813040 813056 16 0.0
.text 733432 733448 16 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740964 740972 8 0.0
.text 663640 663648 8 0.0
cyw30739 light CYW30739B2-P5-EVK-02 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678683 678691 8 0.0
.app_xip_area 602925 602933 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
lock CYW30739B2-P5-EVK-02 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
esp32 all-clusters-app c3devkit (read only) 1210344 1210358 14 0.0
.flash.text 1210344 1210358 14 0.0
m5stack (read only) 1253351 1253367 16 0.0
.flash.text 1247187 1247203 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 769516 769520 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 731204 731208 4 0.0
nxp contact k32w1+release (read/write) 703876 703892 16 0.0
.text 590352 590368 16 0.0
light k32w1+release (read/write) 795568 795576 8 0.0
.text 673304 673312 8 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 834626 834642 16 0.0
text 624558 624572 14 0.0
all-clusters-app tlsr9118bdk40d (read/write) 840068 840084 16 0.0
text 596920 596934 14 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1056676 1056692 16 0.0
text 769284 769298 14 0.0
bridge-app tlsr9518adk80d (read/write) 915040 915056 16 0.0
text 656056 656070 14 0.0
contact-sensor-app tlsr9528a_retention (read/write) 836478 836494 16 0.0
text 626364 626378 14 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 947512 947528 16 0.0
text 713244 713258 14 0.0
lighting-app-ota-factory-data tlsr9118bdk40d (read/write) 770060 770068 8 0.0
text 555210 555224 14 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1090208 1090224 16 0.0
text 792640 792654 14 0.0
lock-app-dfu tlsr9528a (read/write) 911268 911284 16 0.0
text 659408 659422 14 0.0
ota-requestor-app tlsr9518adk80d (read/write) 933860 933876 16 0.0
text 674938 674952 14 0.0
pump-app tlsr9258a (read/write) 831560 831576 16 0.0
text 620996 621010 14 0.0
pump-controller-app tlsr9118bdk40d (read/write) 606944 606960 16 0.0
text 450112 450126 14 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 844106 844122 16 0.0
text 632764 632778 14 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 859613 859621 8 0.0
text 642474 642488 14 0.0
thermostat tlsr9518adk80d (read/write) 825704 825712 8 0.0
text 617822 617836 14 0.0
window-covering tlsr9258a (read/write) 835832 835848 16 0.0
text 622766 622780 14 0.0
Decreases (13 builds for bl602, bl702, bl702l, cc32xx, efr32)
platform target config section 6d51857 2ac70c0 change % change
bl602 lighting-app bl602 (read/write) 1444642 1444010 -632 -0.0
.text 1108552 1107914 -638 -0.1
bl602+mfd (read/write) 1459082 1458698 -384 -0.0
.text 1123870 1123488 -382 -0.0
bl602+rpc (read/write) 1492058 1491674 -384 -0.0
.text 1139942 1139560 -382 -0.0
bl702 lighting-app bl702 (read/write) 1210491 1210111 -380 -0.0
.text 978956 978574 -382 -0.0
bl702+mfd (read/write) 1221563 1220923 -640 -0.1
.text 990966 990328 -638 -0.1
bl702+rpc (read/write) 1301963 1301327 -636 -0.0
.text 1053664 1053026 -638 -0.1
bl706-eth (read/write) 1027837 1027457 -380 -0.0
.text 769760 769378 -382 -0.0
bl706-wifi (read/write) 1261750 1261134 -616 -0.0
.text 1000766 1000152 -614 -0.1
bl702l lighting-app bl702l (read/write) 1180084 1179444 -640 -0.1
.text 972086 971448 -638 -0.1
bl702l+mfd (read/write) 1191488 1190852 -636 -0.1
.text 984408 983770 -638 -0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606462 -8 -0.0
.text 514144 514136 -8 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651742 -8 -0.0
.text 538540 538532 -8 -0.0
efr32 lock-app BRD4338a (read/write) 962508 962492 -16 -0.0
.text 700432 700416 -16 -0.0
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
platform target config section 6d51857 2ac70c0 change % change
bl602 lighting-app bl602 (read/write) 1444642 1444010 -632 -0.0
.bss 85896 85896 0 0.0
.data 9512 9512 0 0.0
.rodata 160028 160028 0 0.0
.text 1108552 1107914 -638 -0.1
bl602+mfd (read/write) 1459082 1458698 -384 -0.0
.bss 86072 86072 0 0.0
.data 9488 9488 0 0.0
.rodata 158988 158988 0 0.0
.text 1123870 1123488 -382 -0.0
bl602+rpc (read/write) 1492058 1491674 -384 -0.0
.bss 93944 93944 0 0.0
.data 9896 9896 0 0.0
.rodata 167604 167604 0 0.0
.text 1139942 1139560 -382 -0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210491 1210111 -380 -0.0
.bss 11185 11185 0 0.0
.data 3712 3712 0 0.0
.rodata 109580 109580 0 0.0
.text 978956 978574 -382 -0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1221563 1220923 -640 -0.1
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 108520 108520 0 0.0
.text 990966 990328 -638 -0.1
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301963 1301327 -636 -0.0
.bss 19669 19669 0 0.0
.data 4256 4256 0 0.0
.rodata 124952 124952 0 0.0
.text 1053664 1053026 -638 -0.1
bl706-eth (read/write) 1027837 1027457 -380 -0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 102596 102596 0 0.0
.text 769760 769378 -382 -0.0
bl706-wifi (read/write) 1261750 1261134 -616 -0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 123716 123716 0 0.0
.text 1000766 1000152 -614 -0.1
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1180084 1179444 -640 -0.1
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 103584 103584 0 0.0
.text 972086 971448 -638 -0.1
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1191488 1190852 -636 -0.1
.bss 16572 16572 0 0.0
.data 5056 5056 0 0.0
.rodata 102524 102524 0 0.0
.text 984408 983770 -638 -0.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 797332 797332 0 0.0
(read/write) 177700 177700 0 0.0
.bss 99612 99612 0 0.0
.data 3604 3604 0 0.0
.rodata 85868 85868 0 0.0
.text 711200 711200 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813040 813056 16 0.0
(read/write) 188172 188172 0 0.0
.bss 110100 110100 0 0.0
.data 3596 3596 0 0.0
.rodata 79344 79344 0 0.0
.text 733432 733448 16 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 802380 802380 0 0.0
(read/write) 182292 182292 0 0.0
.bss 104220 104220 0 0.0
.data 3596 3596 0 0.0
.rodata 106668 106668 0 0.0
.text 695448 695448 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755292 755292 0 0.0
(read/write) 176644 176644 0 0.0
.bss 98336 98336 0 0.0
.data 3588 3588 0 0.0
.rodata 81276 81276 0 0.0
.text 673752 673752 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740964 740972 8 0.0
(read/write) 176884 176884 0 0.0
.bss 98576 98576 0 0.0
.data 3588 3588 0 0.0
.rodata 77060 77060 0 0.0
.text 663640 663648 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606462 -8 -0.0
(read/write) 209716 209716 0 0.0
.bss 202932 202932 0 0.0
.data 1660 1660 0 0.0
.rodata 90206 90206 0 0.0
.text 514144 514136 -8 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651742 -8 -0.0
(read/write) 209972 209972 0 0.0
.bss 203328 203328 0 0.0
.data 1524 1524 0 0.0
.rodata 111086 111086 0 0.0
.text 538540 538532 -8 -0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 740491 740491 0 0.0
.app_xip_area 660437 660437 0 0.0
.bss 73652 73652 0 0.0
.data 940 940 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 712347 712347 0 0.0
.app_xip_area 637225 637225 0 0.0
.bss 68776 68776 0 0.0
.data 884 884 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678683 678691 8 0.0
.app_xip_area 602925 602933 8 0.0
.bss 69236 69236 0 0.0
.data 1060 1060 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 697043 697043 0 0.0
.app_xip_area 618269 618269 0 0.0
.bss 72284 72284 0 0.0
.data 1028 1028 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 659795 659795 0 0.0
.app_xip_area 587053 587053 0 0.0
.bss 66444 66444 0 0.0
.data 836 836 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 682271 682271 0 0.0
.app_xip_area 606897 606897 0 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 682271 682271 0 0.0
.app_xip_area 606897 606897 0 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1070772 1070772 0 0.0
.bss 180056 180056 0 0.0
.data 3448 3448 0 0.0
.text 887248 887248 0 0.0
lock-app BRD4338a (read/write) 962508 962492 -16 -0.0
.bss 213260 213260 0 0.0
.data 29448 29448 0 0.0
.text 700432 700416 -16 -0.0
window-app BRD4187C (read/write) 1135104 1135104 0 0.0
.bss 164584 164584 0 0.0
.data 3352 3352 0 0.0
.text 967148 967148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1210344 1210358 14 0.0
(read/write) 1752704 1752704 0 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 13660 13660 0 0.0
.flash.rodata 254768 254768 0 0.0
.flash.text 1210344 1210358 14 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1253351 1253367 16 0.0
(read/write) 537300 537300 0 0.0
.dram0.bss 79680 79680 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 286504 286504 0 0.0
.flash.text 1247187 1247203 16 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2713765 2713765 0 0.0
(read/write) 133328 133328 0 0.0
.bss 47880 47880 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 77144 77144 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 188400 188400 0 0.0
.text 2341157 2341157 0 0.0
all-clusters-app debug (read only) 6002961 6002961 0 0.0
(read/write) 486344 486344 0 0.0
.bss 136160 136160 0 0.0
.data 4592 4592 0 0.0
.data.rel.ro 338136 338136 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 355824 355824 0 0.0
.text 5204963 5204963 0 0.0
all-clusters-minimal-app debug (read only) 5289897 5289897 0 0.0
(read/write) 241720 241720 0 0.0
.bss 129024 129024 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 101112 101112 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 294570 294570 0 0.0
.text 4752563 4752563 0 0.0
bridge-app debug (read only) 4701937 4701937 0 0.0
(read/write) 221736 221736 0 0.0
.bss 119552 119552 0 0.0
.data 6272 6272 0 0.0
.data.rel.ro 89168 89168 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 234986 234986 0 0.0
.text 4240259 4240259 0 0.0
chip-tool debug (read only) 12185321 12185321 0 0.0
(read/write) 525376 525376 0 0.0
.bss 95128 95128 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 417896 417896 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 459801 459801 0 0.0
.text 11013155 11013155 0 0.0
chip-tool-ipv6only arm64 (read only) 11514036 11514036 0 0.0
(read/write) 592320 592320 0 0.0
.bss 104152 104152 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 458064 458064 0 0.0
.dynamic 512 512 0 0.0
.got 17288 17288 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 361332 361332 0 0.0
.text 10266008 10266008 0 0.0
fabric-admin debug (read only) 11933881 11933881 0 0.0
(read/write) 518440 518440 0 0.0
.bss 94488 94488 0 0.0
.data 4866 4866 0 0.0
.data.rel.ro 412088 412088 0 0.0
.dynamic 624 624 0 0.0
.got 5584 5584 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 430873 430873 0 0.0
.text 10805443 10805443 0 0.0
fabric-bridge-app debug (read only) 4569561 4569561 0 0.0
(read/write) 213744 213744 0 0.0
.bss 115104 115104 0 0.0
.data 5056 5056 0 0.0
.data.rel.ro 86896 86896 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228362 228362 0 0.0
.text 4116851 4116851 0 0.0
lighting-app debug+rpc+ui (read only) 5615409 5615409 0 0.0
(read/write) 230920 230920 0 0.0
.bss 120496 120496 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 98000 98000 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 359220 359220 0 0.0
.text 5002275 5002275 0 0.0
lock-app debug (read only) 4757313 4757313 0 0.0
(read/write) 209120 209120 0 0.0
.bss 114792 114792 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 83416 83416 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 260842 260842 0 0.0
.text 4278419 4278419 0 0.0
ota-provider-app debug (read only) 4374217 4374217 0 0.0
(read/write) 197464 197464 0 0.0
.bss 114624 114624 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 72464 72464 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 212746 212746 0 0.0
.text 3962435 3962435 0 0.0
ota-requestor-app debug (read only) 4503001 4503001 0 0.0
(read/write) 201896 201896 0 0.0
.bss 115520 115520 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 75632 75632 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 218826 218826 0 0.0
.text 4080451 4080451 0 0.0
shell debug (read only) 2976065 2976065 0 0.0
(read/write) 158320 158320 0 0.0
.bss 60752 60752 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 90288 90288 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 191456 191456 0 0.0
.text 2602818 2602818 0 0.0
thermostat-no-ble arm64 (read only) 4491676 4491676 0 0.0
(read/write) 250472 250472 0 0.0
.bss 123144 123144 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 106768 106768 0 0.0
.dynamic 512 512 0 0.0
.got 9144 9144 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 162516 162516 0 0.0
.text 3985768 3985768 0 0.0
tv-app debug (read only) 5831329 5831329 0 0.0
(read/write) 350008 350008 0 0.0
.bss 238640 238640 0 0.0
.data 6592 6592 0 0.0
.data.rel.ro 97480 97480 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 302346 302346 0 0.0
.text 5280787 5280787 0 0.0
tv-casting-app debug (read only) 9996521 9996521 0 0.0
(read/write) 344104 344104 0 0.0
.bss 156728 156728 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 177392 177392 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 389720 389720 0 0.0
.text 9133843 9133843 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535776 2535776 0 0.0
.bss 220928 220928 0 0.0
.data 5224 5224 0 0.0
.text 1498460 1498460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1058788 1058788 0 0.0
bss 139209 139209 0 0.0
rodata 102788 102788 0 0.0
text 769516 769520 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1235720 1235720 0 0.0
bss 137637 137637 0 0.0
rodata 152224 152224 0 0.0
text 795816 795816 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1006532 1006532 0 0.0
bss 138107 138107 0 0.0
rodata 90004 90004 0 0.0
text 731204 731208 4 0.0
nxp contact k32w0+release (read only) 575876 575876 0 0.0
(read/write) 83212 83212 0 0.0
.bss 67920 67920 0 0.0
.data 2204 2204 0 0.0
.text 575340 575340 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703876 703892 16 0.0
.bss 71272 71272 0 0.0
.data 2872 2872 0 0.0
.text 590352 590368 16 0.0
light k32w0+release (read only) 609768 609768 0 0.0
(read/write) 82696 82696 0 0.0
.bss 67376 67376 0 0.0
.data 2224 2224 0 0.0
.text 609232 609232 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795568 795576 8 0.0
.bss 80816 80816 0 0.0
.data 2080 2080 0 0.0
.text 673304 673312 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826128 826128 0 0.0
(read/write) 1824412 1824412 0 0.0
.bss 204460 204460 0 0.0
.data 2752 2752 0 0.0
.text 1608812 1608812 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829224 829224 0 0.0
(read/write) 1745900 1745900 0 0.0
.bss 201388 201388 0 0.0
.data 2728 2728 0 0.0
.text 1533396 1533396 0 0.0
light cy8ckit_062s2_43012 (read only) 835944 835944 0 0.0
(read/write) 1665548 1665548 0 0.0
.bss 194852 194852 0 0.0
.data 2544 2544 0 0.0
.text 1459764 1459764 0 0.0
lock cy8ckit_062s2_43012 (read only) 808880 808880 0 0.0
(read/write) 1694748 1694748 0 0.0
.bss 221932 221932 0 0.0
.data 2528 2528 0 0.0
.text 1461900 1461900 0 0.0
qpg lighting-app qpg6105+debug (read/write) 838532 838532 0 0.0
.bss 103780 103780 0 0.0
.data 864 864 0 0.0
.text 649920 649920 0 0.0
lock-app qpg6105+debug (read/write) 798380 798380 0 0.0
.bss 98444 98444 0 0.0
.data 876 876 0 0.0
.text 609772 609772 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834626 834642 16 0.0
bss 49944 49944 0 0.0
text 624558 624572 14 0.0
all-clusters-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 840068 840084 16 0.0
bss 79088 79088 0 0.0
noinit 46096 46096 0 0.0
text 596920 596934 14 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1056676 1056692 16 0.0
bss 110132 110132 0 0.0
text 769284 769298 14 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 915040 915056 16 0.0
bss 92888 92888 0 0.0
text 656056 656070 14 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836478 836494 16 0.0
bss 49988 49988 0 0.0
text 626364 626378 14 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 947512 947528 16 0.0
bss 76580 76580 0 0.0
text 713244 713258 14 0.0
lighting-app-ota-factory-data tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 770060 770068 8 0.0
bss 75336 75336 0 0.0
noinit 46096 46096 0 0.0
text 555210 555224 14 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090208 1090224 16 0.0
bss 99980 99980 0 0.0
text 792640 792654 14 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911268 911284 16 0.0
bss 69268 69268 0 0.0
text 659408 659422 14 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933860 933876 16 0.0
bss 92620 92620 0 0.0
text 674938 674952 14 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831560 831576 16 0.0
bss 58232 58232 0 0.0
text 620996 621010 14 0.0
pump-controller-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 606944 606960 16 0.0
bss 44160 44160 0 0.0
noinit 32512 32512 0 0.0
text 450112 450126 14 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675304 675304 0 0.0
bss 71852 71852 0 0.0
text 462250 462250 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844106 844122 16 0.0
bss 51616 51616 0 0.0
text 632764 632778 14 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 859613 859621 8 0.0
bss 59804 59804 0 0.0
text 642474 642488 14 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825704 825712 8 0.0
bss 56492 56492 0 0.0
text 617822 617836 14 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835832 835848 16 0.0
bss 58448 58448 0 0.0
text 622766 622780 14 0.0

bzbarsky-apple
bzbarsky-apple reviewed May 29, 2024
View reviewed changes
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/data-model/EncoderToTLV.h Outdated Show resolved Hide resolved
src/app/data-model/EncoderToTLV.h Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

PR #33658: Size comparison from 6d51857 to cb51aa5

Increases (42 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, nxp, telink)
platform target config section 6d51857 cb51aa5 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 797332 797340 8 0.0
.text 711200 711208 8 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813040 813064 24 0.0
.text 733432 733456 24 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 802380 802388 8 0.0
.text 695448 695456 8 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755292 755300 8 0.0
.text 673752 673760 8 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740964 740972 8 0.0
.text 663640 663648 8 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 740491 740499 8 0.0
.app_xip_area 660437 660445 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
CYW930739M2EVB-02 (read/write) 712347 712355 8 0.0
.app_xip_area 637225 637233 8 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678683 678691 8 0.0
.app_xip_area 602925 602933 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 697043 697051 8 0.0
.app_xip_area 618269 618277 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 659795 659803 8 0.0
.app_xip_area 587053 587061 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 682271 682279 8 0.0
.app_xip_area 606897 606905 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 682271 682279 8 0.0
.app_xip_area 606897 606905 8 0.0
esp32 all-clusters-app c3devkit (read only) 1210344 1210360 16 0.0
.flash.text 1210344 1210360 16 0.0
m5stack (read only) 1253351 1253367 16 0.0
.flash.text 1247187 1247203 16 0.0
linux thermostat-no-ble arm64 (read/write) 250472 250520 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 769516 769520 4 0.0
nrf7002dk_nrf5340_cpuapp text 795816 795820 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 731204 731208 4 0.0
nxp contact k32w1+release (read/write) 703876 703892 16 0.0
.text 590352 590368 16 0.0
light k32w1+release (read/write) 795568 795576 8 0.0
.text 673304 673312 8 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 834626 834642 16 0.0
text 624558 624574 16 0.0
all-clusters-app tlsr9118bdk40d (read/write) 840068 840084 16 0.0
text 596920 596936 16 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1056676 1056692 16 0.0
text 769284 769300 16 0.0
bridge-app tlsr9518adk80d (read/write) 915040 915056 16 0.0
text 656056 656072 16 0.0
contact-sensor-app tlsr9528a_retention (read/write) 836478 836494 16 0.0
text 626364 626380 16 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 947512 947528 16 0.0
text 713244 713260 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d (read/write) 770060 770076 16 0.0
text 555210 555226 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1090208 1090224 16 0.0
text 792640 792656 16 0.0
lock-app-dfu tlsr9528a (read/write) 911268 911284 16 0.0
text 659408 659424 16 0.0
ota-requestor-app tlsr9518adk80d (read/write) 933860 933876 16 0.0
text 674938 674954 16 0.0
pump-app tlsr9258a (read/write) 831560 831576 16 0.0
text 620996 621012 16 0.0
pump-controller-app tlsr9118bdk40d (read/write) 606944 606960 16 0.0
text 450112 450128 16 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 844106 844122 16 0.0
text 632764 632780 16 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 859613 859629 16 0.0
text 642474 642490 16 0.0
thermostat tlsr9518adk80d (read/write) 825704 825720 16 0.0
text 617822 617838 16 0.0
window-covering tlsr9258a (read/write) 835832 835848 16 0.0
text 622766 622782 16 0.0
Decreases (28 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, psoc6)
platform target config section 6d51857 cb51aa5 change % change
bl602 lighting-app bl602 (read/write) 1444642 1444010 -632 -0.0
.text 1108552 1107918 -634 -0.1
bl602+mfd (read/write) 1459082 1458706 -376 -0.0
.text 1123870 1123492 -378 -0.0
bl602+rpc (read/write) 1492058 1491682 -376 -0.0
.text 1139942 1139564 -378 -0.0
bl702 lighting-app bl702 (read/write) 1210491 1210115 -376 -0.0
.text 978956 978578 -378 -0.0
bl702+mfd (read/write) 1221563 1220927 -636 -0.1
.text 990966 990332 -634 -0.1
bl702+rpc (read/write) 1301963 1301331 -632 -0.0
.text 1053664 1053030 -634 -0.1
bl706-eth (read/write) 1027837 1027461 -376 -0.0
.text 769760 769382 -378 -0.0
bl706-wifi (read/write) 1261750 1261138 -612 -0.0
.text 1000766 1000156 -610 -0.1
bl702l lighting-app bl702l (read/write) 1180084 1179960 -124 -0.0
.text 972086 971452 -634 -0.1
bl702l+mfd (read/write) 1191488 1191368 -120 -0.0
.text 984408 983774 -634 -0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606454 -16 -0.0
.text 514144 514128 -16 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651734 -16 -0.0
.text 538540 538524 -16 -0.0
efr32 lock-app BRD4338a (read/write) 962508 962476 -32 -0.0
.text 700432 700400 -32 -0.0
linux air-purifier-app debug (read only) 2713765 2713717 -48 -0.0
.text 2341157 2341109 -48 -0.0
all-clusters-app debug (read only) 6002961 6002929 -32 -0.0
.text 5204963 5204931 -32 -0.0
all-clusters-minimal-app debug (read only) 5289897 5289849 -48 -0.0
.text 4752563 4752515 -48 -0.0
bridge-app debug (read only) 4701937 4701889 -48 -0.0
.text 4240259 4240211 -48 -0.0
fabric-bridge-app debug (read only) 4569561 4569529 -32 -0.0
.text 4116851 4116819 -32 -0.0
lighting-app debug+rpc+ui (read only) 5615409 5615361 -48 -0.0
.text 5002275 5002227 -48 -0.0
lock-app debug (read only) 4757313 4757265 -48 -0.0
.text 4278419 4278371 -48 -0.0
ota-provider-app debug (read only) 4374217 4374169 -48 -0.0
.text 3962435 3962387 -48 -0.0
ota-requestor-app debug (read only) 4503001 4502953 -48 -0.0
.text 4080451 4080403 -48 -0.0
shell debug (read only) 2976065 2976017 -48 -0.0
.text 2602818 2602770 -48 -0.0
thermostat-no-ble arm64 (read only) 4491676 4491628 -48 -0.0
.text 3985768 3985720 -48 -0.0
tv-app debug (read only) 5831329 5831281 -48 -0.0
.text 5280787 5280739 -48 -0.0
tv-casting-app debug (read only) 9996521 9996473 -48 -0.0
.text 9133843 9133795 -48 -0.0
psoc6 light cy8ckit_062s2_43012 (read/write) 1665548 1665532 -16 -0.0
.text 1459764 1459748 -16 -0.0
lock cy8ckit_062s2_43012 (read/write) 1694748 1694732 -16 -0.0
.text 1461900 1461884 -16 -0.0
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
platform target config section 6d51857 cb51aa5 change % change
bl602 lighting-app bl602 (read/write) 1444642 1444010 -632 -0.0
.bss 85896 85896 0 0.0
.data 9512 9512 0 0.0
.rodata 160028 160028 0 0.0
.text 1108552 1107918 -634 -0.1
bl602+mfd (read/write) 1459082 1458706 -376 -0.0
.bss 86072 86072 0 0.0
.data 9488 9488 0 0.0
.rodata 158988 158988 0 0.0
.text 1123870 1123492 -378 -0.0
bl602+rpc (read/write) 1492058 1491682 -376 -0.0
.bss 93944 93944 0 0.0
.data 9896 9896 0 0.0
.rodata 167604 167604 0 0.0
.text 1139942 1139564 -378 -0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210491 1210115 -376 -0.0
.bss 11185 11185 0 0.0
.data 3712 3712 0 0.0
.rodata 109580 109580 0 0.0
.text 978956 978578 -378 -0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1221563 1220927 -636 -0.1
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 108520 108520 0 0.0
.text 990966 990332 -634 -0.1
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301963 1301331 -632 -0.0
.bss 19669 19669 0 0.0
.data 4256 4256 0 0.0
.rodata 124952 124952 0 0.0
.text 1053664 1053030 -634 -0.1
bl706-eth (read/write) 1027837 1027461 -376 -0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 102596 102596 0 0.0
.text 769760 769382 -378 -0.0
bl706-wifi (read/write) 1261750 1261138 -612 -0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 123716 123716 0 0.0
.text 1000766 1000156 -610 -0.1
bl702l lighting-app bl702l (read/write) 1180084 1179960 -124 -0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 103584 103584 0 0.0
.text 972086 971452 -634 -0.1
bl702l+mfd (read/write) 1191488 1191368 -120 -0.0
.bss 16572 16572 0 0.0
.data 5056 5056 0 0.0
.rodata 102524 102524 0 0.0
.text 984408 983774 -634 -0.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 797332 797340 8 0.0
(read/write) 177700 177700 0 0.0
.bss 99612 99612 0 0.0
.data 3604 3604 0 0.0
.rodata 85868 85868 0 0.0
.text 711200 711208 8 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813040 813064 24 0.0
(read/write) 188172 188172 0 0.0
.bss 110100 110100 0 0.0
.data 3596 3596 0 0.0
.rodata 79344 79344 0 0.0
.text 733432 733456 24 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 802380 802388 8 0.0
(read/write) 182292 182292 0 0.0
.bss 104220 104220 0 0.0
.data 3596 3596 0 0.0
.rodata 106668 106668 0 0.0
.text 695448 695456 8 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755292 755300 8 0.0
(read/write) 176644 176644 0 0.0
.bss 98336 98336 0 0.0
.data 3588 3588 0 0.0
.rodata 81276 81276 0 0.0
.text 673752 673760 8 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740964 740972 8 0.0
(read/write) 176884 176884 0 0.0
.bss 98576 98576 0 0.0
.data 3588 3588 0 0.0
.rodata 77060 77060 0 0.0
.text 663640 663648 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606454 -16 -0.0
(read/write) 209716 209716 0 0.0
.bss 202932 202932 0 0.0
.data 1660 1660 0 0.0
.rodata 90206 90206 0 0.0
.text 514144 514128 -16 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651734 -16 -0.0
(read/write) 209972 209972 0 0.0
.bss 203328 203328 0 0.0
.data 1524 1524 0 0.0
.rodata 111086 111086 0 0.0
.text 538540 538524 -16 -0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 740491 740499 8 0.0
.app_xip_area 660437 660445 8 0.0
.bss 73652 73652 0 0.0
.data 940 940 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 712347 712355 8 0.0
.app_xip_area 637225 637233 8 0.0
.bss 68776 68776 0 0.0
.data 884 884 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678683 678691 8 0.0
.app_xip_area 602925 602933 8 0.0
.bss 69236 69236 0 0.0
.data 1060 1060 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 697043 697051 8 0.0
.app_xip_area 618269 618277 8 0.0
.bss 72284 72284 0 0.0
.data 1028 1028 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 659795 659803 8 0.0
.app_xip_area 587053 587061 8 0.0
.bss 66444 66444 0 0.0
.data 836 836 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 682271 682279 8 0.0
.app_xip_area 606897 606905 8 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 682271 682279 8 0.0
.app_xip_area 606897 606905 8 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1070772 1070772 0 0.0
.bss 180056 180056 0 0.0
.data 3448 3448 0 0.0
.text 887248 887248 0 0.0
lock-app BRD4338a (read/write) 962508 962476 -32 -0.0
.bss 213260 213260 0 0.0
.data 29448 29448 0 0.0
.text 700432 700400 -32 -0.0
window-app BRD4187C (read/write) 1135104 1135104 0 0.0
.bss 164584 164584 0 0.0
.data 3352 3352 0 0.0
.text 967148 967148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1210344 1210360 16 0.0
(read/write) 1752704 1752704 0 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 13660 13660 0 0.0
.flash.rodata 254768 254768 0 0.0
.flash.text 1210344 1210360 16 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1253351 1253367 16 0.0
(read/write) 537300 537300 0 0.0
.dram0.bss 79680 79680 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 286504 286504 0 0.0
.flash.text 1247187 1247203 16 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2713765 2713717 -48 -0.0
(read/write) 133328 133328 0 0.0
.bss 47880 47880 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 77144 77144 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 188400 188400 0 0.0
.text 2341157 2341109 -48 -0.0
all-clusters-app debug (read only) 6002961 6002929 -32 -0.0
(read/write) 486344 486344 0 0.0
.bss 136160 136160 0 0.0
.data 4592 4592 0 0.0
.data.rel.ro 338136 338136 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 355824 355824 0 0.0
.text 5204963 5204931 -32 -0.0
all-clusters-minimal-app debug (read only) 5289897 5289849 -48 -0.0
(read/write) 241720 241720 0 0.0
.bss 129024 129024 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 101112 101112 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 294570 294570 0 0.0
.text 4752563 4752515 -48 -0.0
bridge-app debug (read only) 4701937 4701889 -48 -0.0
(read/write) 221736 221736 0 0.0
.bss 119552 119552 0 0.0
.data 6272 6272 0 0.0
.data.rel.ro 89168 89168 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 234986 234986 0 0.0
.text 4240259 4240211 -48 -0.0
chip-tool debug (read only) 12185321 12185321 0 0.0
(read/write) 525376 525376 0 0.0
.bss 95128 95128 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 417896 417896 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 459801 459801 0 0.0
.text 11013155 11013155 0 0.0
chip-tool-ipv6only arm64 (read only) 11514036 11514036 0 0.0
(read/write) 592320 592320 0 0.0
.bss 104152 104152 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 458064 458064 0 0.0
.dynamic 512 512 0 0.0
.got 17288 17288 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 361332 361332 0 0.0
.text 10266008 10266008 0 0.0
fabric-admin debug (read only) 11933881 11933881 0 0.0
(read/write) 518440 518440 0 0.0
.bss 94488 94488 0 0.0
.data 4866 4866 0 0.0
.data.rel.ro 412088 412088 0 0.0
.dynamic 624 624 0 0.0
.got 5584 5584 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 430873 430873 0 0.0
.text 10805443 10805443 0 0.0
fabric-bridge-app debug (read only) 4569561 4569529 -32 -0.0
(read/write) 213744 213744 0 0.0
.bss 115104 115104 0 0.0
.data 5056 5056 0 0.0
.data.rel.ro 86896 86896 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228362 228362 0 0.0
.text 4116851 4116819 -32 -0.0
lighting-app debug+rpc+ui (read only) 5615409 5615361 -48 -0.0
(read/write) 230920 230920 0 0.0
.bss 120496 120496 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 98000 98000 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 359220 359220 0 0.0
.text 5002275 5002227 -48 -0.0
lock-app debug (read only) 4757313 4757265 -48 -0.0
(read/write) 209120 209120 0 0.0
.bss 114792 114792 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 83416 83416 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 260842 260842 0 0.0
.text 4278419 4278371 -48 -0.0
ota-provider-app debug (read only) 4374217 4374169 -48 -0.0
(read/write) 197464 197464 0 0.0
.bss 114624 114624 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 72464 72464 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 212746 212746 0 0.0
.text 3962435 3962387 -48 -0.0
ota-requestor-app debug (read only) 4503001 4502953 -48 -0.0
(read/write) 201896 201896 0 0.0
.bss 115520 115520 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 75632 75632 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 218826 218826 0 0.0
.text 4080451 4080403 -48 -0.0
shell debug (read only) 2976065 2976017 -48 -0.0
(read/write) 158320 158320 0 0.0
.bss 60752 60752 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 90288 90288 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 191456 191456 0 0.0
.text 2602818 2602770 -48 -0.0
thermostat-no-ble arm64 (read only) 4491676 4491628 -48 -0.0
(read/write) 250472 250520 48 0.0
.bss 123144 123144 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 106768 106768 0 0.0
.dynamic 512 512 0 0.0
.got 9144 9144 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 162516 162516 0 0.0
.text 3985768 3985720 -48 -0.0
tv-app debug (read only) 5831329 5831281 -48 -0.0
(read/write) 350008 350008 0 0.0
.bss 238640 238640 0 0.0
.data 6592 6592 0 0.0
.data.rel.ro 97480 97480 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 302346 302346 0 0.0
.text 5280787 5280739 -48 -0.0
tv-casting-app debug (read only) 9996521 9996473 -48 -0.0
(read/write) 344104 344104 0 0.0
.bss 156728 156728 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 177392 177392 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 389720 389720 0 0.0
.text 9133843 9133795 -48 -0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535776 2535776 0 0.0
.bss 220928 220928 0 0.0
.data 5224 5224 0 0.0
.text 1498460 1498460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1058788 1058788 0 0.0
bss 139209 139209 0 0.0
rodata 102788 102788 0 0.0
text 769516 769520 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1235720 1235720 0 0.0
bss 137637 137637 0 0.0
rodata 152224 152224 0 0.0
text 795816 795820 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1006532 1006532 0 0.0
bss 138107 138107 0 0.0
rodata 90004 90004 0 0.0
text 731204 731208 4 0.0
nxp contact k32w0+release (read only) 575876 575876 0 0.0
(read/write) 83212 83212 0 0.0
.bss 67920 67920 0 0.0
.data 2204 2204 0 0.0
.text 575340 575340 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703876 703892 16 0.0
.bss 71272 71272 0 0.0
.data 2872 2872 0 0.0
.text 590352 590368 16 0.0
light k32w0+release (read only) 609768 609768 0 0.0
(read/write) 82696 82696 0 0.0
.bss 67376 67376 0 0.0
.data 2224 2224 0 0.0
.text 609232 609232 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795568 795576 8 0.0
.bss 80816 80816 0 0.0
.data 2080 2080 0 0.0
.text 673304 673312 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826128 826128 0 0.0
(read/write) 1824412 1824412 0 0.0
.bss 204460 204460 0 0.0
.data 2752 2752 0 0.0
.text 1608812 1608812 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829224 829224 0 0.0
(read/write) 1745900 1745900 0 0.0
.bss 201388 201388 0 0.0
.data 2728 2728 0 0.0
.text 1533396 1533396 0 0.0
light cy8ckit_062s2_43012 (read only) 835944 835944 0 0.0
(read/write) 1665548 1665532 -16 -0.0
.bss 194852 194852 0 0.0
.data 2544 2544 0 0.0
.text 1459764 1459748 -16 -0.0
lock cy8ckit_062s2_43012 (read only) 808880 808880 0 0.0
(read/write) 1694748 1694732 -16 -0.0
.bss 221932 221932 0 0.0
.data 2528 2528 0 0.0
.text 1461900 1461884 -16 -0.0
qpg lighting-app qpg6105+debug (read/write) 838532 838532 0 0.0
.bss 103780 103780 0 0.0
.data 864 864 0 0.0
.text 649920 649920 0 0.0
lock-app qpg6105+debug (read/write) 798380 798380 0 0.0
.bss 98444 98444 0 0.0
.data 876 876 0 0.0
.text 609772 609772 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834626 834642 16 0.0
bss 49944 49944 0 0.0
text 624558 624574 16 0.0
all-clusters-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 840068 840084 16 0.0
bss 79088 79088 0 0.0
noinit 46096 46096 0 0.0
text 596920 596936 16 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1056676 1056692 16 0.0
bss 110132 110132 0 0.0
text 769284 769300 16 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 915040 915056 16 0.0
bss 92888 92888 0 0.0
text 656056 656072 16 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836478 836494 16 0.0
bss 49988 49988 0 0.0
text 626364 626380 16 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 947512 947528 16 0.0
bss 76580 76580 0 0.0
text 713244 713260 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 770060 770076 16 0.0
bss 75336 75336 0 0.0
noinit 46096 46096 0 0.0
text 555210 555226 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090208 1090224 16 0.0
bss 99980 99980 0 0.0
text 792640 792656 16 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911268 911284 16 0.0
bss 69268 69268 0 0.0
text 659408 659424 16 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933860 933876 16 0.0
bss 92620 92620 0 0.0
text 674938 674954 16 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831560 831576 16 0.0
bss 58232 58232 0 0.0
text 620996 621012 16 0.0
pump-controller-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 606944 606960 16 0.0
bss 44160 44160 0 0.0
noinit 32512 32512 0 0.0
text 450112 450128 16 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675304 675304 0 0.0
bss 71852 71852 0 0.0
text 462250 462250 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844106 844122 16 0.0
bss 51616 51616 0 0.0
text 632764 632780 16 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 859613 859629 16 0.0
bss 59804 59804 0 0.0
text 642474 642490 16 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825704 825720 16 0.0
bss 56492 56492 0 0.0
text 617822 617838 16 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835832 835848 16 0.0
bss 58448 58448 0 0.0
text 622766 622782 16 0.0

bzbarsky-apple
bzbarsky-apple reviewed May 29, 2024
View reviewed changes
src/app/data-model/EncodableToTLV.h Outdated Show resolved Hide resolved
src/app/data-model/EncodableToTLV.h Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

PR #33658: Size comparison from 6d51857 to db0d74c

Increases (42 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, nxp, telink)
platform target config section 6d51857 db0d74ce change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 797332 797340 8 0.0
.text 711200 711208 8 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813040 813064 24 0.0
.text 733432 733456 24 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 802380 802388 8 0.0
.text 695448 695456 8 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755292 755300 8 0.0
.text 673752 673760 8 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740964 740972 8 0.0
.text 663640 663648 8 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 740491 740499 8 0.0
.app_xip_area 660437 660445 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
CYW930739M2EVB-02 (read/write) 712347 712355 8 0.0
.app_xip_area 637225 637233 8 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678683 678691 8 0.0
.app_xip_area 602925 602933 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 697043 697051 8 0.0
.app_xip_area 618269 618277 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 659795 659803 8 0.0
.app_xip_area 587053 587061 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 682271 682279 8 0.0
.app_xip_area 606897 606905 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 682271 682279 8 0.0
.app_xip_area 606897 606905 8 0.0
esp32 all-clusters-app c3devkit (read only) 1210344 1210360 16 0.0
.flash.text 1210344 1210360 16 0.0
m5stack (read only) 1253351 1253367 16 0.0
.flash.text 1247187 1247203 16 0.0
linux thermostat-no-ble arm64 (read/write) 250472 250520 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 769516 769520 4 0.0
nrf7002dk_nrf5340_cpuapp text 795816 795820 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 731204 731208 4 0.0
nxp contact k32w1+release (read/write) 703876 703892 16 0.0
.text 590352 590368 16 0.0
light k32w1+release (read/write) 795568 795576 8 0.0
.text 673304 673312 8 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 834626 834642 16 0.0
text 624558 624574 16 0.0
all-clusters-app tlsr9118bdk40d (read/write) 840068 840084 16 0.0
text 596920 596936 16 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1056676 1056692 16 0.0
text 769284 769300 16 0.0
bridge-app tlsr9518adk80d (read/write) 915040 915056 16 0.0
text 656056 656072 16 0.0
contact-sensor-app tlsr9528a_retention (read/write) 836478 836494 16 0.0
text 626364 626380 16 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 947512 947528 16 0.0
text 713244 713260 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d (read/write) 770060 770076 16 0.0
text 555210 555226 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1090208 1090224 16 0.0
text 792640 792656 16 0.0
lock-app-dfu tlsr9528a (read/write) 911268 911284 16 0.0
text 659408 659424 16 0.0
ota-requestor-app tlsr9518adk80d (read/write) 933860 933876 16 0.0
text 674938 674954 16 0.0
pump-app tlsr9258a (read/write) 831560 831576 16 0.0
text 620996 621012 16 0.0
pump-controller-app tlsr9118bdk40d (read/write) 606944 606960 16 0.0
text 450112 450128 16 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 844106 844122 16 0.0
text 632764 632780 16 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 859613 859629 16 0.0
text 642474 642490 16 0.0
thermostat tlsr9518adk80d (read/write) 825704 825720 16 0.0
text 617822 617838 16 0.0
window-covering tlsr9258a (read/write) 835832 835848 16 0.0
text 622766 622782 16 0.0
Decreases (28 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, psoc6)
platform target config section 6d51857 db0d74ce change % change
bl602 lighting-app bl602 (read/write) 1444642 1444010 -632 -0.0
.text 1108552 1107918 -634 -0.1
bl602+mfd (read/write) 1459082 1458706 -376 -0.0
.text 1123870 1123492 -378 -0.0
bl602+rpc (read/write) 1492058 1491682 -376 -0.0
.text 1139942 1139564 -378 -0.0
bl702 lighting-app bl702 (read/write) 1210491 1210115 -376 -0.0
.text 978956 978578 -378 -0.0
bl702+mfd (read/write) 1221563 1220927 -636 -0.1
.text 990966 990332 -634 -0.1
bl702+rpc (read/write) 1301963 1301331 -632 -0.0
.text 1053664 1053030 -634 -0.1
bl706-eth (read/write) 1027837 1027461 -376 -0.0
.text 769760 769382 -378 -0.0
bl706-wifi (read/write) 1261750 1261138 -612 -0.0
.text 1000766 1000156 -610 -0.1
bl702l lighting-app bl702l (read/write) 1180084 1179960 -124 -0.0
.text 972086 971452 -634 -0.1
bl702l+mfd (read/write) 1191488 1191368 -120 -0.0
.text 984408 983774 -634 -0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606454 -16 -0.0
.text 514144 514128 -16 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651734 -16 -0.0
.text 538540 538524 -16 -0.0
efr32 lock-app BRD4338a (read/write) 962508 962476 -32 -0.0
.text 700432 700400 -32 -0.0
linux air-purifier-app debug (read only) 2713765 2713717 -48 -0.0
.text 2341157 2341109 -48 -0.0
all-clusters-app debug (read only) 6002961 6002929 -32 -0.0
.text 5204963 5204931 -32 -0.0
all-clusters-minimal-app debug (read only) 5289897 5289849 -48 -0.0
.text 4752563 4752515 -48 -0.0
bridge-app debug (read only) 4701937 4701889 -48 -0.0
.text 4240259 4240211 -48 -0.0
fabric-bridge-app debug (read only) 4569561 4569529 -32 -0.0
.text 4116851 4116819 -32 -0.0
lighting-app debug+rpc+ui (read only) 5615409 5615361 -48 -0.0
.text 5002275 5002227 -48 -0.0
lock-app debug (read only) 4757313 4757265 -48 -0.0
.text 4278419 4278371 -48 -0.0
ota-provider-app debug (read only) 4374217 4374169 -48 -0.0
.text 3962435 3962387 -48 -0.0
ota-requestor-app debug (read only) 4503001 4502953 -48 -0.0
.text 4080451 4080403 -48 -0.0
shell debug (read only) 2976065 2976017 -48 -0.0
.text 2602818 2602770 -48 -0.0
thermostat-no-ble arm64 (read only) 4491676 4491628 -48 -0.0
.text 3985768 3985720 -48 -0.0
tv-app debug (read only) 5831329 5831281 -48 -0.0
.text 5280787 5280739 -48 -0.0
tv-casting-app debug (read only) 9996521 9996473 -48 -0.0
.text 9133843 9133795 -48 -0.0
psoc6 light cy8ckit_062s2_43012 (read/write) 1665548 1665532 -16 -0.0
.text 1459764 1459748 -16 -0.0
lock cy8ckit_062s2_43012 (read/write) 1694748 1694732 -16 -0.0
.text 1461900 1461884 -16 -0.0
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
platform target config section 6d51857 db0d74ce change % change
bl602 lighting-app bl602 (read/write) 1444642 1444010 -632 -0.0
.bss 85896 85896 0 0.0
.data 9512 9512 0 0.0
.rodata 160028 160028 0 0.0
.text 1108552 1107918 -634 -0.1
bl602+mfd (read/write) 1459082 1458706 -376 -0.0
.bss 86072 86072 0 0.0
.data 9488 9488 0 0.0
.rodata 158988 158988 0 0.0
.text 1123870 1123492 -378 -0.0
bl602+rpc (read/write) 1492058 1491682 -376 -0.0
.bss 93944 93944 0 0.0
.data 9896 9896 0 0.0
.rodata 167604 167604 0 0.0
.text 1139942 1139564 -378 -0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210491 1210115 -376 -0.0
.bss 11185 11185 0 0.0
.data 3712 3712 0 0.0
.rodata 109580 109580 0 0.0
.text 978956 978578 -378 -0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1221563 1220927 -636 -0.1
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 108520 108520 0 0.0
.text 990966 990332 -634 -0.1
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301963 1301331 -632 -0.0
.bss 19669 19669 0 0.0
.data 4256 4256 0 0.0
.rodata 124952 124952 0 0.0
.text 1053664 1053030 -634 -0.1
bl706-eth (read/write) 1027837 1027461 -376 -0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 102596 102596 0 0.0
.text 769760 769382 -378 -0.0
bl706-wifi (read/write) 1261750 1261138 -612 -0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 123716 123716 0 0.0
.text 1000766 1000156 -610 -0.1
bl702l lighting-app bl702l (read/write) 1180084 1179960 -124 -0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 103584 103584 0 0.0
.text 972086 971452 -634 -0.1
bl702l+mfd (read/write) 1191488 1191368 -120 -0.0
.bss 16572 16572 0 0.0
.data 5056 5056 0 0.0
.rodata 102524 102524 0 0.0
.text 984408 983774 -634 -0.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 797332 797340 8 0.0
(read/write) 177700 177700 0 0.0
.bss 99612 99612 0 0.0
.data 3604 3604 0 0.0
.rodata 85868 85868 0 0.0
.text 711200 711208 8 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813040 813064 24 0.0
(read/write) 188172 188172 0 0.0
.bss 110100 110100 0 0.0
.data 3596 3596 0 0.0
.rodata 79344 79344 0 0.0
.text 733432 733456 24 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 802380 802388 8 0.0
(read/write) 182292 182292 0 0.0
.bss 104220 104220 0 0.0
.data 3596 3596 0 0.0
.rodata 106668 106668 0 0.0
.text 695448 695456 8 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755292 755300 8 0.0
(read/write) 176644 176644 0 0.0
.bss 98336 98336 0 0.0
.data 3588 3588 0 0.0
.rodata 81276 81276 0 0.0
.text 673752 673760 8 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740964 740972 8 0.0
(read/write) 176884 176884 0 0.0
.bss 98576 98576 0 0.0
.data 3588 3588 0 0.0
.rodata 77060 77060 0 0.0
.text 663640 663648 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606470 606454 -16 -0.0
(read/write) 209716 209716 0 0.0
.bss 202932 202932 0 0.0
.data 1660 1660 0 0.0
.rodata 90206 90206 0 0.0
.text 514144 514128 -16 -0.0
lock CC3235SF_LAUNCHXL (read only) 651750 651734 -16 -0.0
(read/write) 209972 209972 0 0.0
.bss 203328 203328 0 0.0
.data 1524 1524 0 0.0
.rodata 111086 111086 0 0.0
.text 538540 538524 -16 -0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 740491 740499 8 0.0
.app_xip_area 660437 660445 8 0.0
.bss 73652 73652 0 0.0
.data 940 940 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 762967 762975 8 0.0
.app_xip_area 680281 680289 8 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 712347 712355 8 0.0
.app_xip_area 637225 637233 8 0.0
.bss 68776 68776 0 0.0
.data 884 884 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678683 678691 8 0.0
.app_xip_area 602925 602933 8 0.0
.bss 69236 69236 0 0.0
.data 1060 1060 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 700879 700887 8 0.0
.app_xip_area 622569 622577 8 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 697043 697051 8 0.0
.app_xip_area 618269 618277 8 0.0
.bss 72284 72284 0 0.0
.data 1028 1028 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 719311 719319 8 0.0
.app_xip_area 637985 637993 8 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 659795 659803 8 0.0
.app_xip_area 587053 587061 8 0.0
.bss 66444 66444 0 0.0
.data 836 836 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 682271 682279 8 0.0
.app_xip_area 606897 606905 8 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 682271 682279 8 0.0
.app_xip_area 606897 606905 8 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1070772 1070772 0 0.0
.bss 180056 180056 0 0.0
.data 3448 3448 0 0.0
.text 887248 887248 0 0.0
lock-app BRD4338a (read/write) 962508 962476 -32 -0.0
.bss 213260 213260 0 0.0
.data 29448 29448 0 0.0
.text 700432 700400 -32 -0.0
window-app BRD4187C (read/write) 1135104 1135104 0 0.0
.bss 164584 164584 0 0.0
.data 3352 3352 0 0.0
.text 967148 967148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1210344 1210360 16 0.0
(read/write) 1752704 1752704 0 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 13660 13660 0 0.0
.flash.rodata 254768 254768 0 0.0
.flash.text 1210344 1210360 16 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1253351 1253367 16 0.0
(read/write) 537300 537300 0 0.0
.dram0.bss 79680 79680 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 286504 286504 0 0.0
.flash.text 1247187 1247203 16 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2713765 2713717 -48 -0.0
(read/write) 133328 133328 0 0.0
.bss 47880 47880 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 77144 77144 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 188400 188400 0 0.0
.text 2341157 2341109 -48 -0.0
all-clusters-app debug (read only) 6002961 6002929 -32 -0.0
(read/write) 486344 486344 0 0.0
.bss 136160 136160 0 0.0
.data 4592 4592 0 0.0
.data.rel.ro 338136 338136 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 355824 355824 0 0.0
.text 5204963 5204931 -32 -0.0
all-clusters-minimal-app debug (read only) 5289897 5289849 -48 -0.0
(read/write) 241720 241720 0 0.0
.bss 129024 129024 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 101112 101112 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 294570 294570 0 0.0
.text 4752563 4752515 -48 -0.0
bridge-app debug (read only) 4701937 4701889 -48 -0.0
(read/write) 221736 221736 0 0.0
.bss 119552 119552 0 0.0
.data 6272 6272 0 0.0
.data.rel.ro 89168 89168 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 234986 234986 0 0.0
.text 4240259 4240211 -48 -0.0
chip-tool debug (read only) 12185321 12185321 0 0.0
(read/write) 525376 525376 0 0.0
.bss 95128 95128 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 417896 417896 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 459801 459801 0 0.0
.text 11013155 11013155 0 0.0
chip-tool-ipv6only arm64 (read only) 11514036 11514036 0 0.0
(read/write) 592320 592320 0 0.0
.bss 104152 104152 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 458064 458064 0 0.0
.dynamic 512 512 0 0.0
.got 17288 17288 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 361332 361332 0 0.0
.text 10266008 10266008 0 0.0
fabric-admin debug (read only) 11933881 11933881 0 0.0
(read/write) 518440 518440 0 0.0
.bss 94488 94488 0 0.0
.data 4866 4866 0 0.0
.data.rel.ro 412088 412088 0 0.0
.dynamic 624 624 0 0.0
.got 5584 5584 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 430873 430873 0 0.0
.text 10805443 10805443 0 0.0
fabric-bridge-app debug (read only) 4569561 4569529 -32 -0.0
(read/write) 213744 213744 0 0.0
.bss 115104 115104 0 0.0
.data 5056 5056 0 0.0
.data.rel.ro 86896 86896 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228362 228362 0 0.0
.text 4116851 4116819 -32 -0.0
lighting-app debug+rpc+ui (read only) 5615409 5615361 -48 -0.0
(read/write) 230920 230920 0 0.0
.bss 120496 120496 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 98000 98000 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 359220 359220 0 0.0
.text 5002275 5002227 -48 -0.0
lock-app debug (read only) 4757313 4757265 -48 -0.0
(read/write) 209120 209120 0 0.0
.bss 114792 114792 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 83416 83416 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 260842 260842 0 0.0
.text 4278419 4278371 -48 -0.0
ota-provider-app debug (read only) 4374217 4374169 -48 -0.0
(read/write) 197464 197464 0 0.0
.bss 114624 114624 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 72464 72464 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 212746 212746 0 0.0
.text 3962435 3962387 -48 -0.0
ota-requestor-app debug (read only) 4503001 4502953 -48 -0.0
(read/write) 201896 201896 0 0.0
.bss 115520 115520 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 75632 75632 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 218826 218826 0 0.0
.text 4080451 4080403 -48 -0.0
shell debug (read only) 2976065 2976017 -48 -0.0
(read/write) 158320 158320 0 0.0
.bss 60752 60752 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 90288 90288 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 191456 191456 0 0.0
.text 2602818 2602770 -48 -0.0
thermostat-no-ble arm64 (read only) 4491676 4491628 -48 -0.0
(read/write) 250472 250520 48 0.0
.bss 123144 123144 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 106768 106768 0 0.0
.dynamic 512 512 0 0.0
.got 9144 9144 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 162516 162516 0 0.0
.text 3985768 3985720 -48 -0.0
tv-app debug (read only) 5831329 5831281 -48 -0.0
(read/write) 350008 350008 0 0.0
.bss 238640 238640 0 0.0
.data 6592 6592 0 0.0
.data.rel.ro 97480 97480 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 302346 302346 0 0.0
.text 5280787 5280739 -48 -0.0
tv-casting-app debug (read only) 9996521 9996473 -48 -0.0
(read/write) 344104 344104 0 0.0
.bss 156728 156728 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 177392 177392 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 389720 389720 0 0.0
.text 9133843 9133795 -48 -0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535776 2535776 0 0.0
.bss 220928 220928 0 0.0
.data 5224 5224 0 0.0
.text 1498460 1498460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1058788 1058788 0 0.0
bss 139209 139209 0 0.0
rodata 102788 102788 0 0.0
text 769516 769520 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1235720 1235720 0 0.0
bss 137637 137637 0 0.0
rodata 152224 152224 0 0.0
text 795816 795820 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1006532 1006532 0 0.0
bss 138107 138107 0 0.0
rodata 90004 90004 0 0.0
text 731204 731208 4 0.0
nxp contact k32w0+release (read only) 575876 575876 0 0.0
(read/write) 83212 83212 0 0.0
.bss 67920 67920 0 0.0
.data 2204 2204 0 0.0
.text 575340 575340 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703876 703892 16 0.0
.bss 71272 71272 0 0.0
.data 2872 2872 0 0.0
.text 590352 590368 16 0.0
light k32w0+release (read only) 609768 609768 0 0.0
(read/write) 82696 82696 0 0.0
.bss 67376 67376 0 0.0
.data 2224 2224 0 0.0
.text 609232 609232 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795568 795576 8 0.0
.bss 80816 80816 0 0.0
.data 2080 2080 0 0.0
.text 673304 673312 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826128 826128 0 0.0
(read/write) 1824412 1824412 0 0.0
.bss 204460 204460 0 0.0
.data 2752 2752 0 0.0
.text 1608812 1608812 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829224 829224 0 0.0
(read/write) 1745900 1745900 0 0.0
.bss 201388 201388 0 0.0
.data 2728 2728 0 0.0
.text 1533396 1533396 0 0.0
light cy8ckit_062s2_43012 (read only) 835944 835944 0 0.0
(read/write) 1665548 1665532 -16 -0.0
.bss 194852 194852 0 0.0
.data 2544 2544 0 0.0
.text 1459764 1459748 -16 -0.0
lock cy8ckit_062s2_43012 (read only) 808880 808880 0 0.0
(read/write) 1694748 1694732 -16 -0.0
.bss 221932 221932 0 0.0
.data 2528 2528 0 0.0
.text 1461900 1461884 -16 -0.0
qpg lighting-app qpg6105+debug (read/write) 838532 838532 0 0.0
.bss 103780 103780 0 0.0
.data 864 864 0 0.0
.text 649920 649920 0 0.0
lock-app qpg6105+debug (read/write) 798380 798380 0 0.0
.bss 98444 98444 0 0.0
.data 876 876 0 0.0
.text 609772 609772 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834626 834642 16 0.0
bss 49944 49944 0 0.0
text 624558 624574 16 0.0
all-clusters-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 840068 840084 16 0.0
bss 79088 79088 0 0.0
noinit 46096 46096 0 0.0
text 596920 596936 16 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1056676 1056692 16 0.0
bss 110132 110132 0 0.0
text 769284 769300 16 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 915040 915056 16 0.0
bss 92888 92888 0 0.0
text 656056 656072 16 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836478 836494 16 0.0
bss 49988 49988 0 0.0
text 626364 626380 16 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 947512 947528 16 0.0
bss 76580 76580 0 0.0
text 713244 713260 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 770060 770076 16 0.0
bss 75336 75336 0 0.0
noinit 46096 46096 0 0.0
text 555210 555226 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090208 1090224 16 0.0
bss 99980 99980 0 0.0
text 792640 792656 16 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911268 911284 16 0.0
bss 69268 69268 0 0.0
text 659408 659424 16 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933860 933876 16 0.0
bss 92620 92620 0 0.0
text 674938 674954 16 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831560 831576 16 0.0
bss 58232 58232 0 0.0
text 620996 621012 16 0.0
pump-controller-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 606944 606960 16 0.0
bss 44160 44160 0 0.0
noinit 32512 32512 0 0.0
text 450112 450128 16 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675304 675304 0 0.0
bss 71852 71852 0 0.0
text 462250 462250 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844106 844122 16 0.0
bss 51616 51616 0 0.0
text 632764 632780 16 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 859613 859629 16 0.0
bss 59804 59804 0 0.0
text 642474 642490 16 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825704 825720 16 0.0
bss 56492 56492 0 0.0
text 617822 617838 16 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835832 835848 16 0.0
bss 58448 58448 0 0.0
text 622766 622782 16 0.0

@andy31415 andy31415 merged commit 90c5cd4 into project-chip:master May 29, 2024
68 of 69 checks passed
kiel-apple pushed a commit to kiel-apple/connectedhomeip that referenced this pull request Jun 3, 2024
@andy31415 @kiel-apple
Post merge review updates for CommandHandler updates (project-chip#33658
0906f39 
)

* Several updates: comments and remove inline

* Restyle

* Move TryAddResponseData into the cpp instead of the header

* Add override, virtual was a copy and paste

* Name argument

* Argument renaming and comment update

* Move EncoderToTLV into DataModel as it looks like a more generic place, maybe we end up re-using it

* Restyle

* Update copyright year

* Renames based on review comments

* More renames of args

* Fix compile

* Slight comment update

* More comment update after self-review

* More comment update after self-review

* Some renaming

* Restyle

* One more rename: EncodableType

* EncodeTo should be const
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Jun 5, 2024
@andy31415 @austina-csa
Post merge review updates for CommandHandler updates (project-chip#33658
1a1dbaa 
)

* Several updates: comments and remove inline

* Restyle

* Move TryAddResponseData into the cpp instead of the header

* Add override, virtual was a copy and paste

* Name argument

* Argument renaming and comment update

* Move EncoderToTLV into DataModel as it looks like a more generic place, maybe we end up re-using it

* Restyle

* Update copyright year

* Renames based on review comments

* More renames of args

* Fix compile

* Slight comment update

* More comment update after self-review

* More comment update after self-review

* Some renaming

* Restyle

* One more rename: EncodableType

* EncodeTo should be const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehampson tehampson tehampson approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @tcarmelveilleux @tehampson @bzbarsky-apple