-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pw_unit_test migration: apps-1 and stub-refactoring #33638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33638: Size comparison from 533df0c to af22724 Decreases (3 builds for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33638: Size comparison from 533df0c to db7c410 Increases (8 builds for cc32xx, esp32, linux, nxp, psoc6)
Decreases (49 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, telink)
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, telink)
|
Alami-Amine
force-pushed
the
AA/AppNoContext
branch
from
May 30, 2024 16:04
db7c410
to
5f1c359
Compare
PR #33638: Size comparison from 201d5fa to 7f90876 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
carol-apple,
chrisdecenzo,
chshu,
chulspro and
cliffamzn
May 30, 2024 19:00
Alami-Amine
changed the title
pw_unit_test migration: apps 1
pw_unit_test migration: apps-1 and stub-refactoring
May 30, 2024
andy31415
reviewed
May 30, 2024
PR #33638: Size comparison from 201d5fa to 88e479d Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
May 30, 2024
andy31415
reviewed
May 30, 2024
andy31415
reviewed
May 30, 2024
andy31415
reviewed
May 30, 2024
andy31415
reviewed
May 30, 2024
andy31415
reviewed
May 30, 2024
andy31415
reviewed
May 30, 2024
andy31415
approved these changes
May 30, 2024
feasel0
reviewed
May 30, 2024
feasel0
reviewed
May 30, 2024
feasel0
reviewed
May 30, 2024
feasel0
reviewed
May 30, 2024
bzbarsky-apple
approved these changes
May 30, 2024
feasel0
reviewed
May 31, 2024
feasel0
approved these changes
May 31, 2024
PR #33638: Size comparison from 201d5fa to 3441641 Increases above 0.2%:
Increases (13 builds for linux)
Decreases (10 builds for linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33638: Size comparison from 909c69b to 3b37a19 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of migration from nl_test to pw_unit_test, effort first discussed in issue #29342
In this PR:
consolidation and refactoring of stub functions that are used by Unit Tests and are related to Interaction Model and ember.
the files with the stubs are
test-interaction-model-api
andtest-ember-api
these stub functions were previously defined in the unit test scripts.
decoupling them is necessary to allow us to convert tests one by one (to NOT need to convert all tests at once) or we will get linking errors
The functions to decouple are in TestReadInteraction.cpp , TestWritenteraction.cpp , TestCommandInteraction.cpp, TestAclAttribute.cpp as well as in
TestPowerSourceCluster
Functions from TestCommandInteraction.cpp weren't moved yet as they use Asserts specific to the unit-test-framework. So i defined them with a weak link.
conversion of a bunch of Tests in
src/app/tests
(Interaction Layer)