TC-DA-1.2: Fix for numberic PIDs with fallback #33621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently isupper is false if there are no letters at all. Adds a fix for TC-DA-1.2 and test vector that exposes this condition. Also adds the pid as a variable to the test vectors.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33621: Size comparison from 6b83689 to d3ba007 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
cecille
changed the title
|
PR #33621: Size comparison from 6b83689 to 1378001 Increases (2 builds for linux)
Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33621: Size comparison from 533df0c to e802a2f Increases (2 builds for linux)
Decreases (3 builds for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33621: Size comparison from 533df0c to 16db135 Increases (15 builds for cc32xx, esp32, linux, nxp, psoc6)
Decreases (64 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33621: Size comparison from 47ab39e to f20a37a Increases (2 builds for linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tcarmelveilleux
approved these changes
Jun 3, 2024
- added a new test vector with the non-numeric PID - confirmed in the log that the test failure now happens on line 81 rather than line 90. This is a manual only verification, I am not adjusting the test-test to expect this, any failure is equally valid as far as the test-test is concerned. - remaning tests are still correct per test_TC_DA_1_2.py
yinyihu-silabs
approved these changes
Jun 4, 2024
Alami-Amine
pushed a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Jun 12, 2024
* TC-DA-1.2: Fix for numberic PIDs will fallback Apparently isupper is false if there are no letters at all. Adds a fix for TC-DA-1.2 and test vector that exposes this condition. Also adds the pid as a variable to the test vectors. * Fix test to use pid from json * Restyled by clang-format * Change to regular expression - added a new test vector with the non-numeric PID - confirmed in the log that the test failure now happens on line 81 rather than line 90. This is a manual only verification, I am not adjusting the test-test to expect this, any failure is equally valid as far as the test-test is concerned. - remaning tests are still correct per test_TC_DA_1_2.py --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently isupper is false if there are no letters at all. Adds a fix for TC-DA-1.2 and test vector that exposes this condition.
Also adds the pid as a variable to the test vectors.
Test: test_TC_DA_1_2.py
Fixes: project-chip/certification-tool#268