-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pigweed-string-format adapter for CHIP_ERROR since that makes unit test debugability a LOT better #33505
Merged
mergify
merged 6 commits into
project-chip:master
from
andy31415:string_builder_adapters
May 20, 2024
Merged
Add a pigweed-string-format adapter for CHIP_ERROR since that makes unit test debugability a LOT better #33505
mergify
merged 6 commits into
project-chip:master
from
andy31415:string_builder_adapters
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
May 17, 2024 14:49
pullapprove
bot
requested review from
vivien-apple,
younghak-hwang,
wiba-nordic,
yufengwangca,
woody-apple and
yunhanw-google
May 17, 2024 14:49
pullapprove
bot
added
review - pending
setup payload
lib
core
and removed
setup payload
lib
core
labels
May 17, 2024
arkq
approved these changes
May 17, 2024
PR #33505: Size comparison from fa28631 to 697e4d8 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
yufengwangca
approved these changes
May 17, 2024
PR #33505: Size comparison from fa28631 to bd212f1 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
feasel0
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we have:
and with this we have:
Started using this in one example unit test, however did not update all of them as that seems quite a bit of work. We can update as a followup or add these when we find errors or for new tests.