-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix historical event detection in MTRDevice. #33462
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-historical-event-detection
May 16, 2024
Merged
Fix historical event detection in MTRDevice. #33462
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-historical-event-detection
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
May 15, 2024 00:56
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
May 15, 2024 00:56
kiel-apple
approved these changes
May 15, 2024
PR #33462: Size comparison from 42c0aa5 to ff8d297 Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
May 15, 2024
bzbarsky-apple
force-pushed
the
fix-historical-event-detection
branch
from
May 15, 2024 03:08
ff8d297
to
02fc6cc
Compare
Fast-tracking platform-specific change with platform owner review. |
PR #33462: Size comparison from eef8ea4 to 02fc6cc Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jtung-apple
approved these changes
May 15, 2024
jtung-apple
approved these changes
May 15, 2024
A few fixes here: * Fix MTRDeviceTests to clean up MTRDevice between tests, so each test starts with a known clean slate. * Fix the "are we getting a priming report?" detection in MTRDevice. Relying on reachability state is not correct, because unsolicited reports can mark us reachable even while we are in the middle of a priming report.
bzbarsky-apple
force-pushed
the
fix-historical-event-detection
branch
from
May 15, 2024 22:33
02fc6cc
to
7bcc9c5
Compare
PR #33462: Size comparison from 1b455b5 to 7bcc9c5 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes here: