-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding config checks for functions specific to only wifi and thread in NetworkCommissioning Cluster code. #33268
Adding config checks for functions specific to only wifi and thread in NetworkCommissioning Cluster code. #33268
Conversation
PR #33268: Size comparison from f6b3594 to 5f21e1b Decreases (3 builds for linux, mbed)
Full report (18 builds for cc32xx, linux, mbed, stm32)
|
5f21e1b
to
4e9dbc7
Compare
PR #33268: Size comparison from f6b3594 to 4e9dbc7 Decreases (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
4e9dbc7
to
da26bb6
Compare
PR #33268: Size comparison from fcfc9bc to da26bb6 Decreases (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg)
Full report (55 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
3867202
to
3f4c505
Compare
3f4c505
to
7419c5b
Compare
PR #33268: Size comparison from fcfc9bc to 7419c5b Decreases (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, mbed, nrfconnect, nxp, psoc6, qpg)
Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
…n NetworkCommissioning
7419c5b
to
9860bc5
Compare
PR #33268: Size comparison from fcfc9bc to 9860bc5 Decreases (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
0cd859b
to
7c5d5a7
Compare
7c5d5a7
to
e0dd983
Compare
PR #33268: Size comparison from fcfc9bc to e0dd983 Decreases (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the goal here codesize reduction?
Yes. |
@shripad621git Please create a backport for v1.3-branch |
…n NetworkCommissioning Cluster code. (project-chip#33268) * Adding config checks for fucntions specific to only wifi and thread in NetworkCommissioning * Restlyed
…n NetworkCommissioning Cluster code. (project-chip#33268) * Adding config checks for fucntions specific to only wifi and thread in NetworkCommissioning * Restlyed
Change Overview:
added a few config checks around those functions.
Testing: