-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the kDNSServiceFlagsTimeout flag when calling DNSServiceGetAdd… #33266
Merged
mergify
merged 6 commits into
project-chip:master
from
nivi-apple:remove_kDNSServiceFlagsTimeout_when_calling_DndsdGetAddrInfo
May 2, 2024
Merged
Remove the kDNSServiceFlagsTimeout flag when calling DNSServiceGetAdd… #33266
mergify
merged 6 commits into
project-chip:master
from
nivi-apple:remove_kDNSServiceFlagsTimeout_when_calling_DndsdGetAddrInfo
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
May 2, 2024 01:12
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
May 2, 2024 01:12
nivi-apple
commented
May 2, 2024
PR #33266: Size comparison from 5570be9 to 3cb192a Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…rInfo - We should not be terminating the queries if we do not get anything back quickly The queries should be running until we get something back
- Either use the DNSServiceFlags value directly in the DNS SD API calls or define a local scoped variable
nivi-apple
force-pushed
the
remove_kDNSServiceFlagsTimeout_when_calling_DndsdGetAddrInfo
branch
from
May 2, 2024 16:33
3cb192a
to
63e79e4
Compare
kiel-apple
approved these changes
May 2, 2024
PR #33266: Size comparison from 3fa70cf to 63e79e4 Full report (3 builds for cc32xx, stm32)
|
kiel-apple
reviewed
May 2, 2024
kiel-apple
approved these changes
May 2, 2024
PR #33266: Size comparison from 3fa70cf to 97e89db Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
May 2, 2024
PR #33266: Size comparison from 3fa70cf to 88f0357 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rInfo
Fixes: #33051