-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GenerateRefreshKey #33202
Merged
yunhanw-google
merged 7 commits into
project-chip:master
from
yunhanw-google:feature/on_create_refresh_key
Apr 27, 2024
Merged
Add GenerateRefreshKey #33202
yunhanw-google
merged 7 commits into
project-chip:master
from
yunhanw-google:feature/on_create_refresh_key
Apr 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33202: Size comparison from 5ce992d to 5fc7ceb Decreases (1 build for efr32)
Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
bzbarsky-apple
approved these changes
Apr 26, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
pullapprove
bot
requested review from
andy31415,
arkq,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no,
kpschoedel and
lazarkov
April 26, 2024 20:47
pullapprove
bot
requested review from
mkardous-silabs,
mspang,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang and
yufengwangca
April 26, 2024 20:47
yunhanw-google
force-pushed
the
feature/on_create_refresh_key
branch
from
April 26, 2024 20:55
f98cb0e
to
c5e72a9
Compare
PR #33202: Size comparison from a45386b to c5e72a9 Decreases (1 build for efr32)
Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
yufengwangca
approved these changes
Apr 26, 2024
yunhanw-google
force-pushed
the
feature/on_create_refresh_key
branch
from
April 26, 2024 22:49
c5e72a9
to
2cfa991
Compare
PR #33202: Size comparison from dd5f6b7 to 2cfa991 Increases (2 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to provide a way to generate the unique key for application when using DefaultCheckInDelegate, for example, c++ chip-tool, we can create virtual GenerateRefreshKey method.