-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thread] Enhance/Optimize attach to thread network #33191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance attaching to Thread network by verifying if the current dataset is the same as provided. In the current solution implementation will not reset the Thread interface while the dataset are equal to the active dataset.
kkasperczyk-no
force-pushed
the
thread_attach
branch
from
April 26, 2024 09:20
4de0bb2
to
5131ffd
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
April 26, 2024 09:20
pullapprove
bot
requested review from
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 26, 2024 09:20
Damian-Nordic
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth mentioning in the PR description that this is to avoid interface reset on fail-safe timeout (if network credentials have not been changed since the fail-safe was armed). At least I believe that was the purpose.
PR #33191: Size comparison from cfb9404 to 5131ffd Increases (41 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, nrfconnect, nxp, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Apr 26, 2024
kkasperczyk-no
added a commit
to kkasperczyk-no/connectedhomeip
that referenced
this pull request
May 8, 2024
Enhance attaching to Thread network by verifying if the current dataset is the same as provided. In the current solution implementation will not reset the Thread interface while the dataset are equal to the active dataset.
kkasperczyk-no
added a commit
that referenced
this pull request
May 8, 2024
Enhance attaching to Thread network by verifying if the current dataset is the same as provided. In the current solution implementation will not reset the Thread interface while the dataset are equal to the active dataset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance attaching to Thread network by verifying if the current dataset is the same as provided.
In the current solution implementation will not reset the Thread interface while the dataset
are equal to the active dataset.