-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform Event when ble is deinitialized #33186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
April 26, 2024 06:57
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 26, 2024 06:57
PR #33186: Size comparison from 8b1fd13 to 7a408bd Increases (2 builds for esp32)
Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
dhrishi
approved these changes
Apr 26, 2024
arkq
approved these changes
Apr 26, 2024
IDF prior to v5.0, nimble_port_deinit() have a return type as void.
PR #33186: Size comparison from 8b1fd13 to 80f0f75 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (13 builds for linux, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Apr 29, 2024
* Platform Event when ble is deinitialized * [ESP32] remove error check on nimble_port_deinit() IDF prior to v5.0, nimble_port_deinit() have a return type as void.
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Apr 29, 2024
* Platform Event when ble is deinitialized * [ESP32] remove error check on nimble_port_deinit() IDF prior to v5.0, nimble_port_deinit() have a return type as void.
This was referenced Apr 29, 2024
espressif-bot
pushed a commit
to espressif/connectedhomeip
that referenced
this pull request
Apr 29, 2024
* Platform Event when ble is deinitialized * [ESP32] remove error check on nimble_port_deinit() IDF prior to v5.0, nimble_port_deinit() have a return type as void.
espressif-bot
pushed a commit
to espressif/connectedhomeip
that referenced
this pull request
Apr 29, 2024
[v1.2] Platform Event when ble is deinitialized (project-chip#33186) See merge request espressif/connectedhomeip!16
dhrishi
pushed a commit
that referenced
this pull request
Apr 29, 2024
andy31415
pushed a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #33109, added the support for ble manager shutdown. Adding an event when the deinitialization is complete.
Tests
Verified that event is handled