-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for notifying the delegate when device configuration changes #33146
Merged
mergify
merged 18 commits into
project-chip:master
from
nivi-apple:add_support_for_device_changed_notification_rebased
May 3, 2024
Merged
Add support for notifying the delegate when device configuration changes #33146
mergify
merged 18 commits into
project-chip:master
from
nivi-apple:add_support_for_device_changed_notification_rebased
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Device configuration changes include updates in attributes parts list, server list, device type list, cluster revision or feature map in the descriptor cluster - Add a test to verify the delegate is notified when device configuration changes
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
April 24, 2024 19:48
nivi-apple
force-pushed
the
add_support_for_device_changed_notification_rebased
branch
from
April 30, 2024 19:09
c39d0e9
to
e964cd1
Compare
PR #33146: Size comparison from 4b58ad2 to 928c255 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #33146: Size comparison from 4b58ad2 to d873d21 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…butesToReportWithReportedValues - Add more tests to verify that for attributes that don't affect device configuration changed, the delegate callback is not called. Also add tests for testing an attribute report having multiple attributes one of which causes device configuration changed.
PR #33146: Size comparison from 4b58ad2 to bf87bcd Decreases (2 builds for efr32)
Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33146: Size comparison from 4b58ad2 to 214244a Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (21 builds for bl602, bl702, bl702l, esp32, nrfconnect, psoc6, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…rt the expectation for device configuration changed when expectConfigurationChanged is set to NO
PR #33146: Size comparison from 4b58ad2 to 217cd66 Increases above 0.2%:
Increases (4 builds for cc32xx, mbed, stm32)
Decreases (1 build for stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
PR #33146: Size comparison from 4b58ad2 to e98778c Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (21 builds for bl602, bl702, bl702l, esp32, nrfconnect, psoc6, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
May 2, 2024
woody-apple
approved these changes
May 2, 2024
bzbarsky-apple
approved these changes
May 2, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device configuration changes include updates in attributes parts list, server list, device type list, cluster revision or feature map in the descriptor cluster
Add a test to verify the delegate is notified when device configuration changes
Fixes: #32353