Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch MTRDevice to using MTRDeviceClusterData for its attribute cache. #33114

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Switch MTRDevice to using MTRDeviceClusterData for its attribute cache. #33114

merged 1 commit into from
Apr 23, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

Use these to store attribute values too, not just data versions.

@bzbarsky-apple
Switch MTRDevice to using MTRDeviceClusterData for its attribute cache.
206f7ed 
Use these to store attribute values too, not just data versions.
@bzbarsky-apple bzbarsky-apple force-pushed the store-MTRDevice-cache-per-cluster branch from 0a3cd24 to 206f7ed Compare April 23, 2024 16:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

PR #33114: Size comparison from c223397 to 206f7ed

Decreases (1 build for efr32)
platform target config section c223397 206f7ed change % change
efr32 window-app BRD4187C (read/write) 1135972 1135964 -8 -0.0
.text 968096 968088 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section c223397 206f7ed change % change
bl602 lighting-app bl602 (read/write) 1442578 1442578 0 0.0
.bss 85448 85448 0 0.0
.data 9512 9512 0 0.0
.rodata 159092 159092 0 0.0
.text 1107870 1107870 0 0.0
bl602+mfd (read/write) 1457002 1457002 0 0.0
.bss 85616 85616 0 0.0
.data 9488 9488 0 0.0
.rodata 158052 158052 0 0.0
.text 1123188 1123188 0 0.0
bl602+rpc (read/write) 1490226 1490226 0 0.0
.bss 93488 93488 0 0.0
.data 9888 9888 0 0.0
.rodata 166660 166660 0 0.0
.text 1139516 1139516 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209255 1209255 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108788 108788 0 0.0
.text 978630 978630 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220075 1220075 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107728 107728 0 0.0
.text 990384 990384 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1300743 1300743 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124160 124160 0 0.0
.text 1053338 1053338 0 0.0
bl706-eth (read/write) 1024969 1024969 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101776 101776 0 0.0
.text 768142 768142 0 0.0
bl706-wifi (read/write) 1259646 1259646 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122776 122776 0 0.0
.text 1000050 1000050 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1178576 1178576 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102792 102792 0 0.0
.text 971484 971484 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1189992 1189992 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101732 101732 0 0.0
.text 983806 983806 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 783684 783684 0 0.0
(read/write) 176668 176668 0 0.0
.bss 98612 98612 0 0.0
.data 3588 3588 0 0.0
.rodata 82964 82964 0 0.0
.text 700452 700452 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799564 799564 0 0.0
(read/write) 187156 187156 0 0.0
.bss 109100 109100 0 0.0
.data 3588 3588 0 0.0
.rodata 76948 76948 0 0.0
.text 722348 722348 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788436 788436 0 0.0
(read/write) 181276 181276 0 0.0
.bss 103220 103220 0 0.0
.data 3588 3588 0 0.0
.rodata 103868 103868 0 0.0
.text 684300 684300 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 740684 740684 0 0.0
(read/write) 175644 175644 0 0.0
.bss 97352 97352 0 0.0
.data 3580 3580 0 0.0
.rodata 78628 78628 0 0.0
.text 661788 661788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726308 726308 0 0.0
(read/write) 175852 175852 0 0.0
.bss 97576 97576 0 0.0
.data 3572 3572 0 0.0
.rodata 74404 74404 0 0.0
.text 651636 651636 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586710 586710 0 0.0
(read/write) 208100 208100 0 0.0
.bss 201324 201324 0 0.0
.data 1652 1652 0 0.0
.rodata 87526 87526 0 0.0
.text 497060 497060 0 0.0
lock CC3235SF_LAUNCHXL (read only) 632870 632870 0 0.0
(read/write) 208364 208364 0 0.0
.bss 201728 201728 0 0.0
.data 1516 1516 0 0.0
.rodata 108206 108206 0 0.0
.text 522544 522544 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570359 570359 0 0.0
.app_xip_area 460269 460269 0 0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552575 552575 0 0.0
.app_xip_area 437813 437813 0 0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573111 573111 0 0.0
.app_xip_area 464517 464517 0 0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565559 565559 0 0.0
.app_xip_area 453781 453781 0 0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069600 1069600 0 0.0
.bss 179920 179920 0 0.0
.data 3432 3432 0 0.0
.text 886228 886228 0 0.0
lock-app BRD4338a (read/write) 961956 961956 0 0.0
.bss 210236 210236 0 0.0
.data 30288 30288 0 0.0
.text 702064 702064 0 0.0
window-app BRD4187C (read/write) 1135972 1135964 -8 -0.0
.bss 164520 164520 0 0.0
.data 3336 3336 0 0.0
.text 968096 968088 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214528 1214528 0 0.0
(read/write) 1750984 1750984 0 0.0
.dram0.bss 74360 74360 0 0.0
.dram0.data 13652 13652 0 0.0
.flash.rodata 253432 253432 0 0.0
.flash.text 1214528 1214528 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1257271 1257271 0 0.0
(read/write) 537356 537356 0 0.0
.dram0.bss 81104 81104 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 285136 285136 0 0.0
.flash.text 1251107 1251107 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2649037 2649037 0 0.0
(read/write) 130064 130064 0 0.0
.bss 46728 46728 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75112 75112 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 185072 185072 0 0.0
.text 2284853 2284853 0 0.0
all-clusters-app debug (read only) 5963921 5963921 0 0.0
(read/write) 481704 481704 0 0.0
.bss 135040 135040 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334664 334664 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 352016 352016 0 0.0
.text 5176643 5176643 0 0.0
all-clusters-minimal-app debug (read only) 5243897 5243897 0 0.0
(read/write) 237656 237656 0 0.0
.bss 127872 127872 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98248 98248 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290666 290666 0 0.0
.text 4716627 4716627 0 0.0
bridge-app debug (read only) 4635153 4635153 0 0.0
(read/write) 218568 218568 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87200 87200 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230890 230890 0 0.0
.text 4182083 4182083 0 0.0
chip-tool debug (read only) 12086153 12086153 0 0.0
(read/write) 523136 523136 0 0.0
.bss 94744 94744 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416032 416032 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451353 451353 0 0.0
.text 10926323 10926323 0 0.0
chip-tool-ipv6only arm64 (read only) 11405268 11405268 0 0.0
(read/write) 590040 590040 0 0.0
.bss 103720 103720 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 455976 455976 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356276 356276 0 0.0
.text 10167192 10167192 0 0.0
lighting-app debug+rpc+ui (read only) 5558689 5558689 0 0.0
(read/write) 227336 227336 0 0.0
.bss 119344 119344 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95568 95568 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354804 354804 0 0.0
.text 4955315 4955315 0 0.0
lock-app debug (read only) 4701065 4701065 0 0.0
(read/write) 205792 205792 0 0.0
.bss 113704 113704 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81192 81192 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 256746 256746 0 0.0
.text 4231203 4231203 0 0.0
ota-provider-app debug (read only) 4310825 4310825 0 0.0
(read/write) 194232 194232 0 0.0
.bss 113440 113440 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70480 70480 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209514 209514 0 0.0
.text 3906707 3906707 0 0.0
ota-requestor-app debug (read only) 4441449 4441449 0 0.0
(read/write) 198600 198600 0 0.0
.bss 114336 114336 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73584 73584 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215594 215594 0 0.0
.text 4026707 4026707 0 0.0
shell debug (read only) 2931985 2931985 0 0.0
(read/write) 157072 157072 0 0.0
.bss 62512 62512 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87344 87344 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 188384 188384 0 0.0
.text 2568370 2568370 0 0.0
thermostat-no-ble arm64 (read only) 4434540 4434540 0 0.0
(read/write) 244992 244992 0 0.0
.bss 121976 121976 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104464 104464 0 0.0
.dynamic 512 512 0 0.0
.got 8720 8720 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160388 160388 0 0.0
.text 3937208 3937208 0 0.0
tv-app debug (read only) 5775009 5775009 0 0.0
(read/write) 353560 353560 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95368 95368 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295242 295242 0 0.0
.text 5235891 5235891 0 0.0
tv-casting-app debug (read only) 9900753 9900753 0 0.0
(read/write) 342784 342784 0 0.0
.bss 157976 157976 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174896 174896 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384536 384536 0 0.0
.text 9049219 9049219 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535584 2535584 0 0.0
.bss 220488 220488 0 0.0
.data 5216 5216 0 0.0
.text 1498268 1498268 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1065856 1065856 0 0.0
bss 133119 133119 0 0.0
rodata 103432 103432 0 0.0
text 782088 782088 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1226296 1226296 0 0.0
bss 127175 127175 0 0.0
rodata 151384 151384 0 0.0
text 797712 797712 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1013424 1013424 0 0.0
bss 131977 131977 0 0.0
rodata 90696 90696 0 0.0
text 743432 743432 0 0.0
nxp contact k32w0+release (read only) 575676 575676 0 0.0
(read/write) 83140 83140 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575140 575140 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 702996 702996 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589552 589552 0 0.0
light k32w0+release (read only) 609688 609688 0 0.0
(read/write) 82600 82600 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609152 609152 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 794888 794888 0 0.0
.bss 80744 80744 0 0.0
.data 2064 2064 0 0.0
.text 672712 672712 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832272 832272 0 0.0
(read/write) 1804644 1804644 0 0.0
.bss 198380 198380 0 0.0
.data 2688 2688 0 0.0
.text 1595188 1595188 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835424 835424 0 0.0
(read/write) 1726548 1726548 0 0.0
.bss 195260 195260 0 0.0
.data 2656 2656 0 0.0
.text 1520244 1520244 0 0.0
light cy8ckit_062s2_43012 (read only) 842144 842144 0 0.0
(read/write) 1645284 1645284 0 0.0
.bss 188724 188724 0 0.0
.data 2472 2472 0 0.0
.text 1445700 1445700 0 0.0
lock cy8ckit_062s2_43012 (read only) 815072 815072 0 0.0
(read/write) 1673948 1673948 0 0.0
.bss 215804 215804 0 0.0
.data 2464 2464 0 0.0
.text 1447292 1447292 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133220 1133220 0 0.0
.bss 102588 102588 0 0.0
.data 856 856 0 0.0
.text 645600 645600 0 0.0
lock-app qpg6105+debug (read/write) 1093220 1093220 0 0.0
.bss 97260 97260 0 0.0
.data 860 860 0 0.0
.text 605604 605604 0 0.0
stm32 light STM32WB5MM-DK (read/write) 604809 604809 0 0.0
.bss 128444 128444 0 0.0
.data 688 688 0 0.0
.rodata 80532 80532 0 0.0
.text 385400 385400 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833942 833942 0 0.0
bss 49856 49856 0 0.0
text 624610 624610 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1097020 1097020 0 0.0
bss 101540 101540 0 0.0
text 798010 798010 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058476 1058476 0 0.0
bss 109988 109988 0 0.0
text 772372 772372 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 913996 913996 0 0.0
bss 92744 92744 0 0.0
text 655852 655852 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 835962 835962 0 0.0
bss 49900 49900 0 0.0
text 626710 626710 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 936636 936636 0 0.0
bss 77512 77512 0 0.0
text 703252 703252 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090508 1090508 0 0.0
bss 99836 99836 0 0.0
text 793954 793954 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911216 911216 0 0.0
bss 69180 69180 0 0.0
text 660246 660246 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932848 932848 0 0.0
bss 92448 92448 0 0.0
text 674888 674888 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833520 833520 0 0.0
bss 58144 58144 0 0.0
text 623710 623710 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799640 799640 0 0.0
bss 56072 56072 0 0.0
text 598616 598616 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676128 676128 0 0.0
bss 73424 73424 0 0.0
text 461864 461864 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843694 843694 0 0.0
bss 51528 51528 0 0.0
text 633242 633242 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858521 858521 0 0.0
bss 59696 59696 0 0.0
text 642200 642200 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825188 825188 0 0.0
bss 56404 56404 0 0.0
text 618166 618166 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838408 838408 0 0.0
bss 58360 58360 0 0.0
text 626174 626174 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific fix with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit a456135 into project-chip:master Apr 23, 2024
65 checks passed
@bzbarsky-apple bzbarsky-apple deleted the store-MTRDevice-cache-per-cluster branch April 23, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @jtung-apple