-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched to pw_unit_test in src/lib/dnssd/minimal_mdns/responders/ #33071
Switched to pw_unit_test in src/lib/dnssd/minimal_mdns/responders/ #33071
Conversation
PR #33071: Size comparison from 80b2f61 to 19429c2 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
@mbknust should this be in draft? Looks good and passes CI. Could you maybe add comments in your descriptions or as separate items on why things are in draft in case they really should be? |
src/lib/dnssd/minimal_mdns/responders/tests/TestIPResponder.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for splitting this up into pieces that can be reviewed in finite time!
PR #33071: Size comparison from e62bc1c to 9632eb4 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
This used to be part of #33045, but was split into smaller pieces to make review easier.