-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Remove global function from the SilabsTestEventTriggerDelegate #32969
Merged
mergify
merged 3 commits into
project-chip:master
from
mkardous-silabs:fix/remove_global_test_event_trigger
Apr 12, 2024
Merged
[Silabs] Remove global function from the SilabsTestEventTriggerDelegate #32969
mergify
merged 3 commits into
project-chip:master
from
mkardous-silabs:fix/remove_global_test_event_trigger
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
April 12, 2024 16:32
pullapprove
bot
requested review from
LuDuda,
mhazley,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 12, 2024 16:32
PR #32969: Size comparison from d65f300 to 4654f36 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tcarmelveilleux
approved these changes
Apr 12, 2024
jmartinez-silabs
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SilabsTestEventTriggerDelegate
was implemented in such a way that it required the implementation of a global function that would implement the buisness logic of the handler.This prevented the sample apps from using the
SilabsTestEventTriggerDelegate
for a common test event trigger handler without providing its own implementation.PR removes the global function and makes consummers of the
SilabsTestEventTriggerDelegate
to use the AddHandler if they need to add a handler.emberAfHandleEventTrigger
emberAfHandleEventTrigger
is no longuer a requirementTests
Manual tests to validate the Smoke & Co and LIT test event triggers work