-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DGWIFI_2_1 Beacon Rx count for linux platform #32963
Merged
mergify
merged 2 commits into
project-chip:master
from
Thirsrin:bugfix/DGWIFI_2_1_beacon_rx_count_issue
Apr 12, 2024
Merged
DGWIFI_2_1 Beacon Rx count for linux platform #32963
mergify
merged 2 commits into
project-chip:master
from
Thirsrin:bugfix/DGWIFI_2_1_beacon_rx_count_issue
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32963: Size comparison from bcebbc6 to 9f09a2f Full report (3 builds for cc32xx, stm32)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
April 12, 2024 10:43
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 12, 2024 10:43
PR #32963: Size comparison from bcebbc6 to 7279ba3 Increases (14 builds for linux)
Decreases (2 builds for linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
arkq
approved these changes
Apr 12, 2024
bzbarsky-apple
approved these changes
Apr 12, 2024
kurvaSai
pushed a commit
to SiliconLabs/matter-for-unify
that referenced
this pull request
May 29, 2024
* added condition for beacon Rx count in DiagnosticDataProviderImpl * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #25747
Old PR: #32805
Description of Problem:
When the WiFi interface is not enabled, Beacon Rx count should be null.
When enabled, need to get Beacon Rx count, but allowed to always return 0 if not tracking that count.
Description of Fix:
added condition for beacon Rx count as per the problem.
Testing:
Tested locally, working as expected.