-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Moved nvm RebootCount and TotalOperationalHours keys to config #32917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
requested changes
Apr 9, 2024
PR #32917: Size comparison from 774f6c4 to 8c030e5 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32917: Size comparison from 1cbd57d to 4ef86c9 Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmeg-sfy
April 11, 2024 02:10
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 11, 2024 02:10
PR #32917: Size comparison from 1cbd57d to 21c20a1 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32917: Size comparison from 1cbd57d to 3e853dd Increases (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, stm32)
Decreases (1 build for linux)
Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #32917: Size comparison from 1cbd57d to e98a098 Increases (1 build for stm32)
Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
PR #32917: Size comparison from 1cbd57d to 5af9f17 Increases (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (2 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32917: Size comparison from 1cbd57d to cec150c Increases (4 builds for nrfconnect, stm32)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
jmartinez-silabs
approved these changes
Apr 11, 2024
PR #32917: Size comparison from 1fdd217 to 3acd3a6 Increases (3 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
Apr 12, 2024
jmartinez-silabs
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
May 8, 2024
…nd TotalOperationalHours keys to config (project-chip#32917) Merge in WMN_TOOLS/matter from cherry-pick/migrate_config_keys to RC_2.3.0-1.3 Squashed commit of the following: commit 389f528fd134c4ede6f58a95039a9ff28f7a1156 Author: Curtis Rahman <[email protected]> Date: Fri Apr 12 12:12:48 2024 -0400 Updated include directory commit 1cecef54e5718263aa486de9440017e0f13ebe58 Author: Curtis Rahman <[email protected]> Date: Fri Apr 12 10:40:53 2024 -0400 [Silabs] Moved nvm RebootCount and TotalOperationalHours keys to config (project-chip#32917) * Moved nvm counter vals to config vals * Removed getter function * Updated include dir * Restyled by whitespace * Restyled by clang-format * Upaded include directory * Moved MigrateCounterConfigs() to MigrationManager * Added MigrationManager * Updated config key base max val --------- Co-authored-by: Restyled.io <[email protected]>
rcasallas-silabs
pushed a commit
to rcasallas-silabs/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…nd TotalOperationalHours keys to config (project-chip#32917) Merge in WMN_TOOLS/matter from cherry-pick/migrate_config_keys to RC_2.3.0-1.3 Squashed commit of the following: commit 389f528fd134c4ede6f58a95039a9ff28f7a1156 Author: Curtis Rahman <[email protected]> Date: Fri Apr 12 12:12:48 2024 -0400 Updated include directory commit 1cecef54e5718263aa486de9440017e0f13ebe58 Author: Curtis Rahman <[email protected]> Date: Fri Apr 12 10:40:53 2024 -0400 [Silabs] Moved nvm RebootCount and TotalOperationalHours keys to config (project-chip#32917) * Moved nvm counter vals to config vals * Removed getter function * Updated include dir * Restyled by whitespace * Restyled by clang-format * Upaded include directory * Moved MigrateCounterConfigs() to MigrationManager * Added MigrationManager * Updated config key base max val --------- Co-authored-by: Restyled.io <[email protected]>
chirag-silabs
pushed a commit
to rosahay-silabs/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…ig (project-chip#32917) * Moved nvm counter vals to config vals * Removed getter function * Updated include dir * Restyled by whitespace * Restyled by clang-format * Upaded include directory * Moved MigrateCounterConfigs() to MigrationManager * Added MigrationManager * Updated config key base max val --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem/Feature:
Description of Fix/Solution:
The update of TotalOperationalHours was not properly being handled within a shutdown function in the platform manager. I removed the update logic within the shutdown function and moved it within a function that is triggered hourly to increment and save it.
The storage of both TotalOperationalHours and RebootCount was configured to not reset to 0 upon factory reset as well. I updated the memory region to be reset to 0 upon factory reset within src/platform/silabs/SilabsConfig.h.