Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pre-composing log strings in MTRASyncWorkQueue. #32915

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Just log the data we want directly instead of building up a string and logging it.

Just log the data we want directly instead of building up a string and logging it.
@ksperling-apple
Copy link
Contributor

Fast-tracking Darwin-only change

Copy link

github-actions bot commented Apr 9, 2024

PR #32915: Size comparison from 774f6c4 to e4f951c

Decreases (3 builds for efr32)
platform target config section 774f6c4 e4f951c change % change
efr32 lighting-app BRD4187C (read/write) 1099136 1099128 -8 -0.0
.text 915756 915748 -8 -0.0
lock-app BRD4338a (read/write) 960136 960128 -8 -0.0
.text 700292 700284 -8 -0.0
window-app BRD4187C (read/write) 1158664 1158656 -8 -0.0
.text 990780 990772 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 774f6c4 e4f951c change % change
bl602 lighting-app bl602 (read/write) 1442386 1442386 0 0.0
.bss 85432 85432 0 0.0
.data 9504 9504 0 0.0
.rodata 159044 159044 0 0.0
.text 1107738 1107738 0 0.0
bl602+mfd (read/write) 1456802 1456802 0 0.0
.bss 85600 85600 0 0.0
.data 9480 9480 0 0.0
.rodata 158004 158004 0 0.0
.text 1123056 1123056 0 0.0
bl602+rpc (read/write) 1490026 1490026 0 0.0
.bss 93480 93480 0 0.0
.data 9880 9880 0 0.0
.rodata 166612 166612 0 0.0
.text 1139384 1139384 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1207079 1207079 0 0.0
.bss 11217 11217 0 0.0
.data 3688 3688 0 0.0
.rodata 108404 108404 0 0.0
.text 976886 976886 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1217891 1217891 0 0.0
.bss 11393 11393 0 0.0
.data 3664 3664 0 0.0
.rodata 107344 107344 0 0.0
.text 988640 988640 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1298815 1298815 0 0.0
.bss 19701 19701 0 0.0
.data 4224 4224 0 0.0
.rodata 123776 123776 0 0.0
.text 1051850 1051850 0 0.0
bl706-eth (read/write) 1024513 1024513 0 0.0
.bss 23792 23792 0 0.0
.data 3264 3264 0 0.0
.rodata 101728 101728 0 0.0
.text 767742 767742 0 0.0
bl706-wifi (read/write) 1259190 1259190 0 0.0
.bss 10677 10677 0 0.0
.data 3696 3696 0 0.0
.rodata 122728 122728 0 0.0
.text 999650 999650 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1176420 1176420 0 0.0
.bss 16428 16428 0 0.0
.data 5048 5048 0 0.0
.rodata 102408 102408 0 0.0
.text 969752 969752 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1187828 1187828 0 0.0
.bss 16604 16604 0 0.0
.data 5032 5032 0 0.0
.rodata 101348 101348 0 0.0
.text 982074 982074 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782140 782140 0 0.0
(read/write) 168824 168824 0 0.0
.bss 90780 90780 0 0.0
.data 3584 3584 0 0.0
.rodata 82596 82596 0 0.0
.text 699276 699276 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798188 798188 0 0.0
(read/write) 178976 178976 0 0.0
.bss 100948 100948 0 0.0
.data 3576 3576 0 0.0
.rodata 76684 76684 0 0.0
.text 721236 721236 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 786932 786932 0 0.0
(read/write) 173416 173416 0 0.0
.bss 95388 95388 0 0.0
.data 3576 3576 0 0.0
.rodata 103500 103500 0 0.0
.text 683164 683164 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739244 739244 0 0.0
(read/write) 167784 167784 0 0.0
.bss 89520 89520 0 0.0
.data 3568 3568 0 0.0
.rodata 78260 78260 0 0.0
.text 660716 660716 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724884 724884 0 0.0
(read/write) 168000 168000 0 0.0
.bss 89736 89736 0 0.0
.data 3568 3568 0 0.0
.rodata 74036 74036 0 0.0
.text 650580 650580 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586338 586338 0 0.0
(read/write) 208080 208080 0 0.0
.bss 201308 201308 0 0.0
.data 1648 1648 0 0.0
.rodata 87482 87482 0 0.0
.text 496732 496732 0 0.0
lock CC3235SF_LAUNCHXL (read only) 631138 631138 0 0.0
(read/write) 208336 208336 0 0.0
.bss 201712 201712 0 0.0
.data 1504 1504 0 0.0
.rodata 107826 107826 0 0.0
.text 521188 521188 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569287 569287 0 0.0
.app_xip_area 459205 459205 0 0.0
.bss 64908 64908 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551551 551551 0 0.0
.app_xip_area 436797 436797 0 0.0
.bss 69572 69572 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572503 572503 0 0.0
.app_xip_area 463925 463925 0 0.0
.bss 63444 63444 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564575 564575 0 0.0
.app_xip_area 452805 452805 0 0.0
.bss 66556 66556 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1099136 1099128 -8 -0.0
.bss 179928 179928 0 0.0
.data 3432 3432 0 0.0
.text 915756 915748 -8 -0.0
lock-app BRD4338a (read/write) 960136 960128 -8 -0.0
.bss 210204 210204 0 0.0
.data 30272 30272 0 0.0
.text 700292 700284 -8 -0.0
window-app BRD4187C (read/write) 1158664 1158656 -8 -0.0
.bss 164528 164528 0 0.0
.data 3336 3336 0 0.0
.text 990780 990772 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1213346 1213346 0 0.0
(read/write) 1750312 1750312 0 0.0
.dram0.bss 74384 74384 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252776 252776 0 0.0
.flash.text 1213346 1213346 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1255151 1255151 0 0.0
(read/write) 536460 536460 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284296 284296 0 0.0
.flash.text 1248987 1248987 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2644477 2644477 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46736 46736 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184848 184848 0 0.0
.text 2280613 2280613 0 0.0
all-clusters-app debug (read only) 5952953 5952953 0 0.0
(read/write) 481536 481536 0 0.0
.bss 135072 135072 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334472 334472 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1432 1432 0 0.0
.rodata 350384 350384 0 0.0
.text 5167763 5167763 0 0.0
all-clusters-minimal-app debug (read only) 5233169 5233169 0 0.0
(read/write) 237488 237488 0 0.0
.bss 127904 127904 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98056 98056 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 289322 289322 0 0.0
.text 4707699 4707699 0 0.0
bridge-app debug (read only) 4626665 4626665 0 0.0
(read/write) 218336 218336 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86976 86976 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 230186 230186 0 0.0
.text 4174755 4174755 0 0.0
chip-tool debug (read only) 12081769 12081769 0 0.0
(read/write) 523032 523032 0 0.0
.bss 94680 94680 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 451225 451225 0 0.0
.text 10922163 10922163 0 0.0
chip-tool-ipv6only arm64 (read only) 11401300 11401300 0 0.0
(read/write) 589952 589952 0 0.0
.bss 103736 103736 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455952 455952 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 355924 355924 0 0.0
.text 10163640 10163640 0 0.0
lighting-app debug+rpc+ui (read only) 5549529 5549529 0 0.0
(read/write) 227096 227096 0 0.0
.bss 119336 119336 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 95376 95376 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 354004 354004 0 0.0
.text 4947411 4947411 0 0.0
lock-app debug (read only) 4691633 4691633 0 0.0
(read/write) 205552 205552 0 0.0
.bss 113696 113696 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 81016 81016 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 255882 255882 0 0.0
.text 4223091 4223091 0 0.0
ota-provider-app debug (read only) 4308057 4308057 0 0.0
(read/write) 194224 194224 0 0.0
.bss 113472 113472 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 209098 209098 0 0.0
.text 3904451 3904451 0 0.0
ota-requestor-app debug (read only) 4437721 4437721 0 0.0
(read/write) 198592 198592 0 0.0
.bss 114368 114368 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73552 73552 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 215338 215338 0 0.0
.text 4023331 4023331 0 0.0
shell debug (read only) 2918993 2918993 0 0.0
(read/write) 156936 156936 0 0.0
.bss 62544 62544 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87168 87168 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1104 1104 0 0.0
.rodata 186208 186208 0 0.0
.text 2558082 2558082 0 0.0
thermostat-no-ble arm64 (read only) 4426780 4426780 0 0.0
(read/write) 244496 244496 0 0.0
.bss 121976 121976 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 104312 104312 0 0.0
.dynamic 512 512 0 0.0
.got 8712 8712 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160052 160052 0 0.0
.text 3930136 3930136 0 0.0
tv-app debug (read only) 5762161 5762161 0 0.0
(read/write) 353200 353200 0 0.0
.bss 244240 244240 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95128 95128 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 293194 293194 0 0.0
.text 5225715 5225715 0 0.0
tv-casting-app debug (read only) 9892001 9892001 0 0.0
(read/write) 342608 342608 0 0.0
.bss 157904 157904 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174816 174816 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1208 1208 0 0.0
.rodata 383576 383576 0 0.0
.text 9041715 9041715 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2534408 2534408 0 0.0
.bss 220472 220472 0 0.0
.data 5216 5216 0 0.0
.text 1497092 1497092 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1064428 1064428 0 0.0
bss 133107 133107 0 0.0
rodata 103020 103020 0 0.0
text 781076 781076 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1225420 1225420 0 0.0
bss 127163 127163 0 0.0
rodata 151304 151304 0 0.0
text 796920 796920 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1011908 1011908 0 0.0
bss 131965 131965 0 0.0
rodata 90284 90284 0 0.0
text 742444 742444 0 0.0
nxp contact k32w0+release (read only) 574524 574524 0 0.0
(read/write) 79988 79988 0 0.0
.bss 67824 67824 0 0.0
.data 2180 2180 0 0.0
.text 573988 573988 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 701604 701604 0 0.0
.bss 71176 71176 0 0.0
.data 2856 2856 0 0.0
.text 588192 588192 0 0.0
light k32w0+release (read only) 608600 608600 0 0.0
(read/write) 79464 79464 0 0.0
.bss 67280 67280 0 0.0
.data 2200 2200 0 0.0
.text 608064 608064 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 793520 793520 0 0.0
.bss 80728 80728 0 0.0
.data 2056 2056 0 0.0
.text 671368 671368 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832280 832280 0 0.0
(read/write) 1802724 1802724 0 0.0
.bss 198372 198372 0 0.0
.data 2688 2688 0 0.0
.text 1593276 1593276 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835432 835432 0 0.0
(read/write) 1724612 1724612 0 0.0
.bss 195252 195252 0 0.0
.data 2656 2656 0 0.0
.text 1518316 1518316 0 0.0
light cy8ckit_062s2_43012 (read only) 842160 842160 0 0.0
(read/write) 1643348 1643348 0 0.0
.bss 188716 188716 0 0.0
.data 2464 2464 0 0.0
.text 1443780 1443780 0 0.0
lock cy8ckit_062s2_43012 (read only) 815096 815096 0 0.0
(read/write) 1672116 1672116 0 0.0
.bss 215788 215788 0 0.0
.data 2456 2456 0 0.0
.text 1445484 1445484 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1131888 1131888 0 0.0
.bss 102572 102572 0 0.0
.data 844 844 0 0.0
.text 644272 644272 0 0.0
lock-app qpg6105+debug (read/write) 1091688 1091688 0 0.0
.bss 97236 97236 0 0.0
.data 856 856 0 0.0
.text 604068 604068 0 0.0
stm32 light STM32WB5MM-DK (read/write) 603437 603437 0 0.0
.bss 128436 128436 0 0.0
.data 676 676 0 0.0
.rodata 80180 80180 0 0.0
.text 384400 384400 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832358 832358 0 0.0
bss 49820 49820 0 0.0
text 623476 623476 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1095832 1095832 0 0.0
bss 101520 101520 0 0.0
text 797210 797210 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1057288 1057288 0 0.0
bss 109968 109968 0 0.0
text 771572 771572 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 912776 912776 0 0.0
bss 92724 92724 0 0.0
text 655010 655010 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834338 834338 0 0.0
bss 49864 49864 0 0.0
text 625522 625522 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 935040 935040 0 0.0
bss 77476 77476 0 0.0
text 702140 702140 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1089192 1089192 0 0.0
bss 99816 99816 0 0.0
text 793020 793020 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 909624 909624 0 0.0
bss 69144 69144 0 0.0
text 659102 659102 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932476 932476 0 0.0
bss 92428 92428 0 0.0
text 674582 674582 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 837082 837082 0 0.0
bss 49968 49968 0 0.0
text 628590 628590 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 798160 798160 0 0.0
bss 56036 56036 0 0.0
text 597580 597580 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675812 675812 0 0.0
bss 73412 73412 0 0.0
text 461586 461586 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 842070 842070 0 0.0
bss 51500 51500 0 0.0
text 632064 632064 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 857825 857825 0 0.0
bss 59660 59660 0 0.0
text 641630 641630 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 823652 823652 0 0.0
bss 56368 56368 0 0.0
text 617072 617072 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 842676 842676 0 0.0
bss 68008 68008 0 0.0
text 633094 633094 0 0.0

@mergify mergify bot merged commit d7dde9b into project-chip:master Apr 9, 2024
66 checks passed
@bzbarsky-apple bzbarsky-apple deleted the async-work-queue-descriptions branch April 9, 2024 20:53
shaoltan-amazon pushed a commit to shaoltan-amazon/connectedhomeip that referenced this pull request Apr 10, 2024
)

Just log the data we want directly instead of building up a string and logging it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants