-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add TestEventTrigger support to the ICDManager #32898
Merged
mergify
merged 13 commits into
project-chip:master
from
mkardous-silabs:feature/icd_test_event_trigger
Apr 10, 2024
Merged
[ICD] Add TestEventTrigger support to the ICDManager #32898
mergify
merged 13 commits into
project-chip:master
from
mkardous-silabs:feature/icd_test_event_trigger
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
github
workflows
tests
icd
Intermittently Connected Devices
labels
Apr 8, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
April 8, 2024 14:43
PR #32898: Size comparison from 0515c61 to 94808d3 Increases (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
mkardous-silabs
force-pushed
the
feature/icd_test_event_trigger
branch
from
April 9, 2024 14:39
4a346ae
to
25ab0db
Compare
PR #32898: Size comparison from 45a9a66 to 25ab0db Increases (14 builds for efr32, linux, qpg, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Apr 9, 2024
mkardous-silabs
force-pushed
the
feature/icd_test_event_trigger
branch
from
April 9, 2024 16:07
25ab0db
to
e00e9e9
Compare
mkardous-silabs
force-pushed
the
feature/icd_test_event_trigger
branch
from
April 9, 2024 16:08
e00e9e9
to
bb0e414
Compare
mkardous-silabs
force-pushed
the
feature/icd_test_event_trigger
branch
from
April 9, 2024 16:26
95413e6
to
d68ef85
Compare
PR #32898: Size comparison from bc9fc76 to d68ef85 Full report (3 builds for cc32xx, stm32)
|
PR #32898: Size comparison from bc9fc76 to d5b61f0 Increases above 0.2%:
Increases (16 builds for efr32, linux, nxp, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32898: Size comparison from bc9fc76 to d0f8957 Increases (17 builds for efr32, linux, nxp, qpg, telink)
Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32898: Size comparison from bc9fc76 to 03cafe0 Increases (17 builds for efr32, linux, nxp, qpg, telink)
Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
shaoltan-amazon
pushed a commit
to shaoltan-amazon/connectedhomeip
that referenced
this pull request
Apr 10, 2024
) * Add TestEventTrigger to the ICDManager * Update copyright year * Update init / shutdown to not modify them * Remove unnecessary import * Fix nxp build * remove unnused import * add test event trigger to the app layer * Remove TestEventTrigger from known problems linter * fix typo * fix merge conflicts * update TestICDManager inits * Fix TestCommissionManager * move enum to the impl anonymous namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Adds support for the TestEventTrigger to the ICDManager class
Tests
fixes: #31379
Associated test plan PR : https://github.com/CHIP-Specifications/chip-test-plans/pull/4100