Fix Darwin dns-sd handling of results on interface index 0. #32872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-chip#32513 introduced a bug, in that we would ignore all results associated with interface index 0. But that's perfectly valid for dns-sd results in general. What we want to ignore are cases where if_nametoindex returned 0, since those correspond to "no such interface name". The fix is to move "interfaceIndex == 0" check to the right spot. The rest of the changes are just there to improve logging. Specifically, log what's going on with our SRP resolve timer, and include the instance name being resolved in various logs so we can tell which logs have to do with which node being resolved.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
nivi-apple
approved these changes
Apr 5, 2024
andy31415
approved these changes
Apr 5, 2024
|
PR #32872: Size comparison from 11da2b1 to 1f46234 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32513 introduced a bug, in that we would ignore all results associated with interface index 0.
But that's perfectly valid for dns-sd results in general. What we want to ignore are cases where if_nametoindex returned 0, since those correspond to "no such interface name".
The fix is to move "interfaceIndex == 0" check to the right spot.
The rest of the changes are just there to improve logging. Specifically, log what's going on with our SRP resolve timer, and include the instance name being resolved in various logs so we can tell which logs have to do with which node being resolved.