-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Move warning settings into the Xcode project #32828
Merged
bzbarsky-apple
merged 8 commits into
project-chip:master
from
ksperling-apple:darwin-warnings
Apr 3, 2024
Merged
Darwin: Move warning settings into the Xcode project #32828
bzbarsky-apple
merged 8 commits into
project-chip:master
from
ksperling-apple:darwin-warnings
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable warnings in the build settings rather than feeding them in during CI builds only. Also build targets within the project with MTR_NO_AVAILABILITY=1 and provisional / experimental APIs enabled. This means actual warnings now don't get drowned out by thousands of availability warnings. Explicitly suppress certain warnings within third-party code in dft.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
lazarkov
April 3, 2024 09:44
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple and
wiba-nordic
April 3, 2024 09:44
pullapprove
bot
requested review from
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 3, 2024 09:44
PR #32828: Size comparison from a7c9a7b to 29f6a84 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Apr 3, 2024
PR #32828: Size comparison from a7c9a7b to 580826c Increases above 0.2%:
Increases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (49 builds for bl602, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32828: Size comparison from a7c9a7b to a477eab Increases above 0.2%:
Increases (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
Decreases (26 builds for bl602, cc32xx, cyw30739, esp32, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
bzbarsky-apple
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable warnings in the build settings rather than feeding them in during CI
builds only. Also build targets within the project with MTR_NO_AVAILABILITY=1
and provisional / experimental APIs enabled. This means actual warnings now
don't get drowned out by thousands of availability warnings.
The key build settings are
CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION
andGCC_TREAT_WARNINGS_AS_ERRORS
.Explicitly suppress certain warnings within third-party code in dft.