-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for arm64 build failure with bluetooth enabled in linux platform #32806
Merged
mergify
merged 3 commits into
project-chip:master
from
sabollim-silabs:bugfix/fixing-arm64-build-failure-in-linux-platform
Apr 2, 2024
Merged
Fix for arm64 build failure with bluetooth enabled in linux platform #32806
mergify
merged 3 commits into
project-chip:master
from
sabollim-silabs:bugfix/fixing-arm64-build-failure-in-linux-platform
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabollim-silabs
changed the title
fix for arm64 build failure in linux platform
[Silabs]Fix for arm64 build failure with bluetooth enabled in linux platform
Apr 2, 2024
PR #32806: Size comparison from 6c89640 to 5552b86 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
changed the title
[Silabs]Fix for arm64 build failure with bluetooth enabled in linux platform
Fix for arm64 build failure with bluetooth enabled in linux platform
Apr 2, 2024
jmartinez-silabs
approved these changes
Apr 2, 2024
andy31415
approved these changes
Apr 2, 2024
@sabollim-silabs please sign the CLA |
bzbarsky-apple
approved these changes
Apr 2, 2024
PR #32806: Size comparison from 3099269 to e69aa94 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
arkq,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no and
lazarkov
April 2, 2024 16:34
pullapprove
bot
requested review from
LuDuda,
mhazley,
p0fi,
plauric,
saurabhst,
sharadb-amazon,
tima-q,
tobiasgraf,
wiba-nordic and
younghak-hwang
April 2, 2024 16:34
sure.will sign CLA |
kurvaSai
pushed a commit
to SiliconLabs/matter-for-unify
that referenced
this pull request
May 29, 2024
Co-authored-by: sabollim <[email protected]>
chirag-silabs
pushed a commit
to rosahay-silabs/connectedhomeip
that referenced
this pull request
Jul 15, 2024
Co-authored-by: sabollim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem: In the platform/Linux code for bluetooth, we are using "typeof" in ConnectDevice function. which throws an error ("typeof not found") for the arm64 build.
Description of Fix:
Changed the "typeof" to "decltype" which is a valid C++ Standard keyword.
Testing Done:
Locally tested, arm64 build successful