-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NXP][platform][common] Fix for WiFi scenario: connect -> disconnect-> connect #32785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-ignat
force-pushed
the
upstream-wifi-scenario-fix
branch
from
March 29, 2024 11:41
f04c777
to
fe34e19
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
March 29, 2024 11:42
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
March 29, 2024 11:42
PR #32785: Size comparison from f2353ad to fe34e19 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Damian-Nordic
approved these changes
Mar 29, 2024
mihai-ignat
force-pushed
the
upstream-wifi-scenario-fix
branch
from
April 3, 2024 15:34
fe34e19
to
9e3c8bb
Compare
PR #32785: Size comparison from c172e30 to 9e3c8bb Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
mihai-ignat
force-pushed
the
upstream-wifi-scenario-fix
branch
from
April 4, 2024 07:37
9e3c8bb
to
c8b8de0
Compare
PR #32785: Size comparison from 6a7961d to c8b8de0 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
arkq
approved these changes
Apr 4, 2024
…-> connect. Wifi network was connected previous, then a disconnect event happened, after which a connection command was issued again. In this case, the WiFi driver keeps the previous network credentials and it will not add them again.
mihai-ignat
force-pushed
the
upstream-wifi-scenario-fix
branch
from
April 8, 2024 07:57
c8b8de0
to
a4fe4a1
Compare
PR #32785: Size comparison from f46cdf3 to a4fe4a1 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Apr 29, 2024
… -> disconnect -> connect. Wifi network was connected previous, then a disconnect event happened, after which a connection command was issued again. In this case, the WiFi driver keeps the previous network credentials and it will not add them again. (project-chip#32785) (cherry picked from commit 696ae98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wifi network was connected previous, then a disconnect event happened, after which a connection command was issued again. In this case, the WiFi driver keeps the previous network credentials and it will not add them again. This fix allows the connection event to be called even if network was previously added.