-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to browse and resolve on both local and SRP domain #32779
Add support to browse and resolve on both local and SRP domain #32779
Conversation
This is needed to pass the domain returned from a call to Browse to the Resolve.
PR #32779: Size comparison from c89090c to bc4dd91 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32779: Size comparison from c5fba0c to 0b28c78 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #32779: Size comparison from c5fba0c to b35892c Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #32779: Size comparison from c5fba0c to d822cbd Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #32779: Size comparison from c5fba0c to 5a02f62 Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
PR #32779: Size comparison from c5fba0c to 5b9b5e9 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32779: Size comparison from c5fba0c to 072d568 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…ect ResolveContextWithType for the case where domain is not null during resolve
PR #32779: Size comparison from c5fba0c to 04875e8 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Fast-tracking platform-specific change with platform owner review. |
…ct-chip#32779) * Add domain names matching the DnssdServices stored in Browse Context This is needed to pass the domain returned from a call to Browse to the Resolve. * Restyled by clang-format * Add the domain names to the services vector * Restyled by clang-format * Add support to browse and resolve on both local and SRP domain * Restyled by clang-format * Fix the code that gets the domain name returned from browse and pass it into the resolve * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments * Updated the comment about shouldStartSRPTimerForResolve * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Addressed more review comments * Restyled by clang-format * Add a null check for domain when erasing the contents of services * Fix the check for domain name when erasing services and pass the correct ResolveContextWithType for the case where domain is not null during resolve * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Fixes: #32681 #32678