[Darwin] MTRDevice attribute storage should store values by cluster #32765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #32765: Size comparison from 4e582fc to cc80b77 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #32765: Size comparison from 4e582fc to 8edbf80 Increases (4 builds for k32w)
Full report (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
|
PR #32765: Size comparison from 4e582fc to bcaf6ca Increases (6 builds for efr32, k32w)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
Mar 28, 2024
Comment on lines
+29
to
+30
| typedef NSDictionary<NSString *, id> * MTRDeviceResponseValueDictionary; | ||
| typedef NSDictionary<NSString *, id> * MTRDeviceDataValueDictionary; |
There was a problem hiding this comment.
Please let's not have this be public API for now... There are some issues with having public typedefs (like promising that the names will stay stable, etc)... For now, we should just have the typedef in one of the project headers and then think about the public API aspect.
There was a problem hiding this comment.
Addressed in #32778
| return [NSString stringWithFormat:@"<MTRDeviceClusterData: dataVersion %@ attributes count %lu>", _dataVersion, static_cast<unsigned long>(_attributes.count)]; | ||
| } | ||
|
|
||
| - (nullable instancetype)initWithDataVersion:(NSNumber * _Nullable)dataVersion attributes:(NSDictionary<NSNumber *, MTRDeviceDataValueDictionary> * _Nullable)attributes |
There was a problem hiding this comment.
Please document that the number is the attribute id.
There was a problem hiding this comment.
Addressed in #32778
jtung-apple
added a commit
to jtung-apple/connectedhomeip
that referenced
this pull request
Mar 28, 2024
woody-apple
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the attribute storage from storing each attributes with their own keys, to storing them by clusters. This should reduce the number of writes significantly.
Should this test well, there are some follow up changes to consolidate how the in-memory read cache is represented to using the
MTRDeviceClusterDataclass. But for now I'm keeping this structure in case we want to switch back to by-attribute storage.