-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for localization-configuration cluster and time-format-localization cluster init callback #32747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wqx6
changed the title
Add checks for localization-configuration cluster and time-format-localization cluster
Add checks for localization-configuration cluster and time-format-localization cluster init callback
Mar 27, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
March 27, 2024 09:36
pullapprove
bot
requested review from
yufengwangca,
tobiasgraf,
yunhanw-google,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
March 27, 2024 09:36
PR #32747: Size comparison from f15d3ae to d7e7330 Increases (44 builds for bl602, bl702, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (1 build for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
Mar 28, 2024
bzbarsky-apple
approved these changes
Mar 30, 2024
src/app/clusters/time-format-localization-server/time-format-localization-server.cpp
Outdated
Show resolved
Hide resolved
PR #32747: Size comparison from f46cdf3 to 9778d1b Increases (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (2 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…alization cluster
…ocalization-server.cpp Co-authored-by: Boris Zbarsky <[email protected]>
yunhanw-google
force-pushed
the
add_check_lc_tfl
branch
from
April 10, 2024 16:35
9778d1b
to
7a103d6
Compare
PR #32747: Size comparison from e05d08e to 7a103d6 Increases (44 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (1 build for linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
wqx6
added a commit
to wqx6/connectedhomeip
that referenced
this pull request
May 14, 2024
…alization cluster init callback (project-chip#32747) * Add checks for localization-configuration cluster and time-format-localization cluster * Update src/app/clusters/time-format-localization-server/time-format-localization-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
May 14, 2024
* esp32: service type should be case-insensitive for endpoint filter of mdns packets (#33206) * Add checks for localization-configuration cluster and time-format-localization cluster init callback (#32747) * Add checks for localization-configuration cluster and time-format-localization cluster * Update src/app/clusters/time-format-localization-server/time-format-localization-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emberAfTimeFormatLocalizationClusterServerInitCallback
callsActiveCalendarType::Get()
without checking whether the cluster supports CalendarFormat feature.emberAfLocalizationConfigurationClusterServerInitCallback
tries to setActiveLocale
without checkingvalidLocaleCached
.