-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android]CHIP_ERROR should be handled by Long in Java/Kotlin #32702
[Android]CHIP_ERROR should be handled by Long in Java/Kotlin #32702
Conversation
d4118dd
to
1062456
Compare
PR #32702: Size comparison from 04251f1 to 1062456 Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
1062456
to
a23163d
Compare
PR #32702: Size comparison from 74b151e to a23163d Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
a23163d
to
48078be
Compare
01919fe
to
6290f8e
Compare
PR #32702: Size comparison from d26d2e5 to 6290f8e Full report (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
20d6fbe
to
65b69ed
Compare
PR #32702: Size comparison from d26d2e5 to 65b69ed Decreases (1 build for efr32)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
In Java, due to the lack of native unsigned types, converting from native unsigned numbers often requires using larger signed types to accurately represent the same range of values. However, Kotlin introduces native support for unsigned types, eliminating the need for such workarounds. It's important to ensure that Kotlin's unsigned types are correctly aligned with their native counterparts to maintain data integrity during conversions. |
ecdf1f7
to
a6eff3a
Compare
PR #32702: Size comparison from 31fa02f to 9837917 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
9837917
to
364bf36
Compare
PR #32702: Size comparison from 72bd295 to 1cccbc2 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
1cccbc2
to
91bf271
Compare
PR #32702: Size comparison from eed2a1a to 91bf271 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32702: Size comparison from eed2a1a to 4d5e360 Increases above 0.2%:
Increases (5 builds for efr32, linux)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32702: Size comparison from eed2a1a to 66b2767 Increases above 0.2%:
Increases (5 builds for efr32, linux)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32702: Size comparison from eed2a1a to 72ddaf5 Increases above 0.2%:
Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32702: Size comparison from eed2a1a to 20733d5 Increases above 0.2%:
Increases (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (11 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
20733d5
to
8322679
Compare
PR #32702: Size comparison from 60b6beb to 8322679 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
-- CHIP_ERROR should be handled by Long in Java since CHIP_ERROR is uint32_t and Java Int cannot hold it up , fix across jni/java/kotlin
fixes: #32560