-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NXP] Some fixes for k32w platforms #32684
Merged
mergify
merged 6 commits into
project-chip:master
from
NXP:k32w-platform-examples-updates
Mar 28, 2024
Merged
[NXP] Some fixes for k32w platforms #32684
mergify
merged 6 commits into
project-chip:master
from
NXP:k32w-platform-examples-updates
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
March 22, 2024 06:50
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
March 22, 2024 06:50
PR #32684: Size comparison from ea29531 to 870a452 Increases (4 builds for k32w)
Full report (12 builds for cc32xx, k32w, nrfconnect, qpg, stm32)
|
marius-alex-tache
force-pushed
the
k32w-platform-examples-updates
branch
from
March 22, 2024 07:14
870a452
to
b7d3978
Compare
Signed-off-by: marius-alex-tache <[email protected]>
* Clear buffer that just handled the private key. The other variables (P256Keypair, P256SerializedKeypair) are automatically cleared when destroyed. Signed-off-by: Andrei Menzopol <[email protected]>
* update Basic Information cluster revision * update ICDM cluster revision Signed-off-by: Doru Gucea <[email protected]>
Signed-off-by: Doru Gucea <[email protected]>
…improve commissioning behavior
marius-alex-tache
force-pushed
the
k32w-platform-examples-updates
branch
from
March 25, 2024 08:07
b7d3978
to
2eab729
Compare
PR #32684: Size comparison from 437c574 to 9767113 Increases (5 builds for efr32, k32w)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Mar 26, 2024
andy31415
approved these changes
Mar 28, 2024
marius-alex-tache
added a commit
to NXP/matter
that referenced
this pull request
Apr 29, 2024
* [NXP][k32w0] Update KVS logs to specify storage name Signed-off-by: marius-alex-tache <[email protected]> * [NXP][k32w] Sanitize temporary buffer * Clear buffer that just handled the private key. The other variables (P256Keypair, P256SerializedKeypair) are automatically cleared when destroyed. Signed-off-by: Andrei Menzopol <[email protected]> * [NXP][k32w] Update contact sensor zap files * update Basic Information cluster revision * update ICDM cluster revision Signed-off-by: Doru Gucea <[email protected]> * [NXP][k32w1] Fix ECDSA signature validation Signed-off-by: Doru Gucea <[email protected]> * [NXP][k32w0] Add check for BLE connection when doing save on idle to improve commissioning behavior * [NXP][k32w0] Remove code that generates errors in debug builds for k32w0 --------- Signed-off-by: marius-alex-tache <[email protected]> Signed-off-by: Andrei Menzopol <[email protected]> Signed-off-by: Doru Gucea <[email protected]> Co-authored-by: Andrei Menzopol <[email protected]> Co-authored-by: Doru Gucea <[email protected]> Co-authored-by: Mihai Ignat <[email protected]> (cherry picked from commit bf45f69)
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Apr 29, 2024
…hip#32684)" This reverts commit 0845c05. Signed-off-by: Andrei Menzopol <[email protected]>
marius-alex-tache
added a commit
to NXP/matter
that referenced
this pull request
Apr 29, 2024
* [NXP][k32w0] Update KVS logs to specify storage name Signed-off-by: marius-alex-tache <[email protected]> * [NXP][k32w] Sanitize temporary buffer * Clear buffer that just handled the private key. The other variables (P256Keypair, P256SerializedKeypair) are automatically cleared when destroyed. Signed-off-by: Andrei Menzopol <[email protected]> * [NXP][k32w] Update contact sensor zap files * update Basic Information cluster revision * update ICDM cluster revision Signed-off-by: Doru Gucea <[email protected]> * [NXP][k32w1] Fix ECDSA signature validation Signed-off-by: Doru Gucea <[email protected]> * [NXP][k32w0] Add check for BLE connection when doing save on idle to improve commissioning behavior * [NXP][k32w0] Remove code that generates errors in debug builds for k32w0 --------- Signed-off-by: marius-alex-tache <[email protected]> Signed-off-by: Andrei Menzopol <[email protected]> Signed-off-by: Doru Gucea <[email protected]> Co-authored-by: Andrei Menzopol <[email protected]> Co-authored-by: Doru Gucea <[email protected]> Co-authored-by: Mihai Ignat <[email protected]> (cherry picked from commit bf45f69)
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 31, 2024
* [NXP][k32w0] Update KVS logs to specify storage name Signed-off-by: marius-alex-tache <[email protected]> * [NXP][k32w] Sanitize temporary buffer * Clear buffer that just handled the private key. The other variables (P256Keypair, P256SerializedKeypair) are automatically cleared when destroyed. Signed-off-by: Andrei Menzopol <[email protected]> * [NXP][k32w] Update contact sensor zap files * update Basic Information cluster revision * update ICDM cluster revision Signed-off-by: Doru Gucea <[email protected]> * [NXP][k32w1] Fix ECDSA signature validation Signed-off-by: Doru Gucea <[email protected]> * [NXP][k32w0] Add check for BLE connection when doing save on idle to improve commissioning behavior * [NXP][k32w0] Remove code that generates errors in debug builds for k32w0 --------- Signed-off-by: marius-alex-tache <[email protected]> Signed-off-by: Andrei Menzopol <[email protected]> Signed-off-by: Doru Gucea <[email protected]> Co-authored-by: Andrei Menzopol <[email protected]> Co-authored-by: Doru Gucea <[email protected]> Co-authored-by: Mihai Ignat <[email protected]> (cherry picked from commit bf45f69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common k32w changes:
k32w0: