Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't run bootstrap if we restored from cache #32610

Merged

Conversation

ksperling-apple
Copy link
Contributor

Handle caching and log upload directly within the bootstrap action, and don't perform the actual bootstrap if we have a cache hit. Include the platform name in the cache key.

Handle caching and log upload directly within the bootstrap action, and don't
perform the actual bootstrap if we have a cache hit. Include the platform name
in the cache key.
@andy31415
Copy link
Contributor

@ksperling-apple do you happen to know how large our storage allocation for caching is? I believe our bootstrap includes cipd images for clang at least, so it may be quite large, so if we multiply it by the number of platforms we may increase the storage a lot. My current PW_ENVIRONMENT_ROOT on linux is 5.2GB. In setup we seem to have 15 separate requirements.txt.

@andy31415
Copy link
Contributor

@ksperling-apple do you happen to know how large our storage allocation for caching is? I believe our bootstrap includes cipd images for clang at least, so it may be quite large, so if we multiply it by the number of platforms we may increase the storage a lot. My current PW_ENVIRONMENT_ROOT on linux is 5.2GB. In setup we seem to have 15 separate requirements.txt.

https://buildjet.com/for-github-actions/docs/about/pricing#build-jet-cache-limits says 20GB per week. this seems to work with 5GB, but will not work with 75.

@ksperling-apple
Copy link
Contributor Author

@ksperling-apple do you happen to know how large our storage allocation for caching is? I believe our bootstrap includes cipd images for clang at least, so it may be quite large, so if we multiply it by the number of platforms we may increase the storage a lot. My current PW_ENVIRONMENT_ROOT on linux is 5.2GB. In setup we seem to have 15 separate requirements.txt.

https://buildjet.com/for-github-actions/docs/about/pricing#build-jet-cache-limits says 20GB per week. this seems to work with 5GB, but will not work with 75.

At the moment I'm seeing cache sizes around 1.5-2 GB (tar ball size) in the logs, so I think we should be OK for the time being. If we're starting to hit the limit we can look at bootstrapping for all platforms instead of the targeted platform, so we have one large cache file shared by all jobs.

@mergify mergify bot merged commit 8228705 into project-chip:master Mar 19, 2024
58 checks passed
andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants