-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Expose ActiveModeDuration, ActiveModeThreshold, IdleModeDuration to application #32494
Merged
yunhanw-google
merged 7 commits into
project-chip:master
from
yunhanw-google:feature/icd_more_parameter
Mar 27, 2024
Merged
[ICD] Expose ActiveModeDuration, ActiveModeThreshold, IdleModeDuration to application #32494
yunhanw-google
merged 7 commits into
project-chip:master
from
yunhanw-google:feature/icd_more_parameter
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
changed the title
Expose ICD Active/Idle paramter to application
[ICD] Expose ActiveModeDuration, ActiveModeThreshold, IdleModeDuration to application
Mar 7, 2024
yunhanw-google
force-pushed
the
feature/icd_more_parameter
branch
from
March 7, 2024 20:12
1200544
to
cdaa65c
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
March 7, 2024 20:13
yunhanw-google
force-pushed
the
feature/icd_more_parameter
branch
from
March 20, 2024 21:34
7e9851e
to
beee151
Compare
PR #32494: Size comparison from 03531f7 to f913ada Increases (3 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
force-pushed
the
feature/icd_more_parameter
branch
from
March 26, 2024 07:22
f913ada
to
0636044
Compare
PR #32494: Size comparison from d26d2e5 to 0636044 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for efr32)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
bzbarsky-apple
requested changes
Mar 26, 2024
yunhanw-google
force-pushed
the
feature/icd_more_parameter
branch
from
March 26, 2024 17:29
0636044
to
d043414
Compare
PR #32494: Size comparison from 31fa02f to d043414 Full report (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
yunhanw-google
force-pushed
the
feature/icd_more_parameter
branch
from
March 26, 2024 17:55
d043414
to
90245cb
Compare
PR #32494: Size comparison from 72bd295 to 90245cb Increases (1 build for linux)
Decreases (1 build for linux)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #32494: Size comparison from 72bd295 to d06ec7c Increases (3 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
force-pushed
the
feature/icd_more_parameter
branch
from
March 26, 2024 20:28
d06ec7c
to
1981861
Compare
PR #32494: Size comparison from 813181a to 1981861 Increases (3 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Mar 27, 2024
mkardous-silabs
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--Expose ActiveModeDuration, ActiveModeThreshold, IdleModeDuration to application, and let user decide how to use them, for example, when user tries to interact with lit icd and have the queue, and UI can prompt user with the estimate waiting time window, if that waiting time is very long, user can decide whether to manually wakeup the device immediately.