Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CommandHandler to be more unittestable #32467

Merged
merged 22 commits into from
Apr 3, 2024
Merged

Refactor CommandHandler to be more unittestable #32467

merged 22 commits into from
Apr 3, 2024

Conversation

tehampson
Copy link
Contributor

@tehampson tehampson commented Mar 6, 2024 •
edited
Loading

Ready for review

Summary of what has been refactored:

  • Moved some method declaration in CommandHandler.h that were previously public to private.
  • Inverting it such that CommandResponder contains CommandHandler
  • CommandResponder is entirely responsible for responding for handling exchange. Remove CommandHandler from needing the exchange context. Any previous public APIs that relied on data from exchange now is tunneled through CommandResponderInterface
  • CommandHandler gets object that implementsCommandResponderInterface. This allows CommandHandler to be more unit testable.
  • Allow CommandHandler to intentionally not provide instance of CommandResponderInterface. This allows application code to call an embr clsuter command dispatcher, such as emberAfLevelControlClusterMoveWithOnOffCallback, with a CommandHandler that won't send any responses.
  • Removed declaration of TestCommandHandlerWithSendEmptyResponse from src/app/tests/TestCommandInteraction.cpp. Test itself was removed in IM command needs mandatory path #7538, this declaration stayed around for a long time.

Tests:

  • CI Passes

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

PR #32467: Size comparison from bdb88bd to 97f3fe2

Increases above 0.2%:

platform target config section bdb88bd 97f3fe2 change % change
bl702 lighting-app bl702 .rodata 107732 108036 304 0.3
bl702+mfd .rodata 106672 106976 304 0.3
bl706-eth .rodata 101064 101368 304 0.3
.text 763896 765876 1980 0.3
bl702l lighting-app bl702l .rodata 101736 102040 304 0.3
bl702l+mfd .rodata 100676 100980 304 0.3
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 .rodata 81756 81964 208 0.3
lock-ftd LP_EM_CC1354P10_6 .rodata 76004 76212 208 0.3
pump-app LP_EM_CC1354P10_6 .rodata 77420 77628 208 0.3
pump-controller-app LP_EM_CC1354P10_6 .rodata 73268 73468 200 0.3
cc32xx air-purifier CC3235SF_LAUNCHXL .rodata 86602 86874 272 0.3
lock CC3235SF_LAUNCHXL .rodata 107058 107338 280 0.3
k32w contact k32w0+release (read/write) 79636 82764 3128 3.9
light k32w0+release (read/write) 79520 82636 3116 3.9
lock k32w0+release (read/write) 77508 80628 3120 4.0
linux air-purifier-app debug (read/write) 128960 129376 416 0.3
.data.rel.ro 74248 74680 432 0.6
all-clusters-minimal-app debug .data.rel.ro 97208 97640 432 0.4
bridge-app debug .data.rel.ro 86144 86576 432 0.5
lighting-app debug+rpc+ui .data.rel.ro 94544 94976 432 0.5
lock-app debug (read/write) 204816 205232 416 0.2
.data.rel.ro 80392 80808 416 0.5
ota-provider-app debug (read/write) 193288 193736 448 0.2
.data.rel.ro 69776 70208 432 0.6
ota-requestor-app debug (read/write) 197720 198136 416 0.2
.data.rel.ro 72896 73328 432 0.6
shell debug (read/write) 156352 156768 416 0.3
.data.rel.ro 86464 86888 424 0.5
thermostat-no-ble arm64 (read/write) 245528 246168 640 0.3
.data.rel.ro 103624 104048 424 0.4
tv-app debug .data.rel.ro 94424 94856 432 0.5
tv-casting-app debug .data.rel.ro 174176 174608 432 0.2
stm32 light STM32WB5MM-DK .rodata 79644 79884 240 0.3
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section bdb88bd 97f3fe2 change % change
bl602 lighting-app bl602 (read/write) 1437482 1440002 2520 0.2
.rodata 158376 158680 304 0.2
.text 1103612 1105848 2236 0.2
bl602+mfd (read/write) 1452162 1454426 2264 0.2
.rodata 157336 157640 304 0.2
.text 1119186 1121166 1980 0.2
bl602+rpc (read/write) 1485138 1487658 2520 0.2
.rodata 165952 166256 304 0.2
.text 1135258 1137494 2236 0.2
bl702 lighting-app bl702 (read/write) 1201927 1204451 2524 0.2
.rodata 107732 108036 304 0.3
.text 972512 974748 2236 0.2
bl702+mfd (read/write) 1212983 1215507 2524 0.2
.rodata 106672 106976 304 0.3
.text 984522 986758 2236 0.2
bl702+rpc (read/write) 1293675 1296199 2524 0.2
.rodata 123104 123408 304 0.2
.text 1047476 1049712 2236 0.2
bl706-eth (read/write) 1019897 1022165 2268 0.2
.rodata 101064 101368 304 0.3
.text 763896 765876 1980 0.3
bl706-wifi (read/write) 1254414 1256594 2180 0.2
.rodata 122064 122368 304 0.2
.text 995674 997566 1892 0.2
bl702l lighting-app bl702l (read/write) 1171504 1174028 2524 0.2
.rodata 101736 102040 304 0.3
.text 965610 967846 2236 0.2
bl702l+mfd (read/write) 1182908 1185176 2268 0.2
.rodata 100676 100980 304 0.3
.text 977932 979912 1980 0.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 773956 774732 776 0.1
.rodata 81756 81964 208 0.3
.text 691936 692504 568 0.1
lock-ftd LP_EM_CC1354P10_6 (read only) 790492 791236 744 0.1
.rodata 76004 76212 208 0.3
.text 714224 714760 536 0.1
lock-mtd LP_EM_CC1354P10_6 (read only) 779148 779868 720 0.1
.rodata 102756 102956 200 0.2
.text 676128 676648 520 0.1
pump-app LP_EM_CC1354P10_6 (read only) 731308 731932 624 0.1
.rodata 77420 77628 208 0.3
.text 653624 654040 416 0.1
pump-controller-app LP_EM_CC1354P10_6 (read only) 716948 717564 616 0.1
.rodata 73268 73468 200 0.3
.text 643416 643832 416 0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 583338 584178 840 0.1
.rodata 86602 86874 272 0.3
.text 494612 495180 568 0.1
lock CC3235SF_LAUNCHXL (read only) 628610 629650 1040 0.2
.rodata 107058 107338 280 0.3
.text 519428 520188 760 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 569139 569875 736 0.1
.app_xip_area 458893 459645 752 0.2
lock cyw930739m2evb_01 (read/write) 551867 552555 688 0.1
.app_xip_area 436861 437565 704 0.2
ota-requestor cyw930739m2evb_01 (read/write) 572019 572747 728 0.1
.app_xip_area 463277 464021 744 0.2
switch cyw930739m2evb_01 (read/write) 564923 565547 624 0.1
.app_xip_area 452901 453541 640 0.1
efr32 lighting-app BRD4161A+rs9116 (read/write) 933208 934360 1152 0.1
.text 733852 735020 1168 0.2
BRD4187C (read/write) 1110336 1111128 792 0.1
.text 911724 912532 808 0.1
lock-app BRD4161A+wf200 (read/write) 1122844 1123516 672 0.1
.text 933236 933924 688 0.1
window-app BRD4187C (read/write) 1157080 1158000 920 0.1
.text 986308 987244 936 0.1
esp32 all-clusters-app c3devkit (read only) 1211588 1212270 682 0.1
(read/write) 1749696 1749912 216 0.0
.flash.rodata 252224 252456 232 0.1
.flash.text 1211588 1212270 682 0.1
m5stack (read only) 1253855 1255019 1164 0.1
(read/write) 536248 536568 320 0.1
.dram0.bss 81232 81240 8 0.0
.flash.rodata 283932 284244 312 0.1
.flash.text 1247691 1248855 1164 0.1
k32w contact k32w0+release (read only) 606352 607024 672 0.1
(read/write) 79636 82764 3128 3.9
.bss 67452 67468 16 0.0
.text 605816 606488 672 0.1
k32w1+release (read/write) 747792 748344 552 0.1
.text 626392 626952 560 0.1
light k32w0+release (read only) 610024 610736 712 0.1
(read/write) 79520 82636 3116 3.9
.bss 67332 67340 8 0.0
.text 609488 610200 712 0.1
k32w1+release (read/write) 790460 791132 672 0.1
.text 668464 669144 680 0.1
lock k32w0+release (read only) 589904 590648 744 0.1
(read/write) 77508 80628 3120 4.0
.bss 65372 65388 16 0.0
.text 589368 590112 744 0.1
linux air-purifier-app debug (read only) 2617245 2619509 2264 0.1
(read/write) 128960 129376 416 0.3
.data.rel.ro 74248 74680 432 0.6
.text 2254773 2256325 1552 0.1
all-clusters-app debug (read only) 5923313 5926793 3480 0.1
(read/write) 480432 480880 448 0.1
.bss 134848 134880 32 0.0
.data.rel.ro 333640 334072 432 0.1
.text 5140291 5143187 2896 0.1
all-clusters-minimal-app debug (read only) 5203857 5207145 3288 0.1
(read/write) 236384 236832 448 0.2
.bss 127680 127712 32 0.0
.data.rel.ro 97208 97640 432 0.4
.text 4680467 4683171 2704 0.1
bridge-app debug (read only) 4598305 4600521 2216 0.0
(read/write) 217232 217648 416 0.2
.data.rel.ro 86144 86576 432 0.5
.text 4148723 4150259 1536 0.0
chip-tool debug (read only) 12034281 12042481 8200 0.1
(read/write) 521512 521960 448 0.1
.bss 94424 94456 32 0.0
.data.rel.ro 414744 415168 424 0.1
.rodata 448665 449049 384 0.1
.text 10879843 10886723 6880 0.1
chip-tool-ipv6only arm64 (read only) 11357788 11367372 9584 0.1
.bss 103512 103528 16 0.0
.data.rel.ro 454528 455016 488 0.1
.got 16976 16984 8 0.0
.rodata 354508 355020 512 0.1
.text 10124968 10132888 7920 0.1
lighting-app debug+rpc+ui (read only) 5521945 5524625 2680 0.0
(read/write) 226024 226440 416 0.2
.data.rel.ro 94544 94976 432 0.5
.text 4920787 4922883 2096 0.0
lock-app debug (read only) 4666033 4668553 2520 0.1
(read/write) 204816 205232 416 0.2
.data.rel.ro 80392 80808 416 0.5
.text 4199075 4200915 1840 0.0
ota-provider-app debug (read only) 4297865 4300033 2168 0.1
(read/write) 193288 193736 448 0.2
.data.rel.ro 69776 70208 432 0.6
.text 3897043 3898627 1584 0.0
ota-requestor-app debug (read only) 4427273 4429729 2456 0.1
(read/write) 197720 198136 416 0.2
.data.rel.ro 72896 73328 432 0.6
.text 4015795 4017507 1712 0.0
shell debug (read only) 2891065 2894369 3304 0.1
(read/write) 156352 156768 416 0.3
.data.rel.ro 86464 86888 424 0.5
.text 2532114 2534770 2656 0.1
thermostat-no-ble arm64 (read only) 4417412 4420860 3448 0.1
(read/write) 245528 246168 640 0.3
.data.rel.ro 103624 104048 424 0.4
.got 8616 8624 8 0.1
.rodata 159388 159476 88 0.1
.text 3923384 3925688 2304 0.1
tv-app debug (read only) 5706257 5715161 8904 0.2
(read/write) 352584 353064 480 0.1
.bss 244368 244400 32 0.0
.data.rel.ro 94424 94856 432 0.5
.rodata 289994 290154 160 0.1
.text 5174179 5181987 7808 0.2
tv-casting-app debug (read only) 9865225 9867649 2424 0.0
(read/write) 340296 340744 448 0.1
.data.rel.ro 174176 174608 432 0.2
.text 9016451 9018195 1744 0.0
mbed lock-app-release cy8cproto_062_4343w (read/write) 2532432 2533168 736 0.0
.text 1495116 1495852 736 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1103128 1104032 904 0.1
rodata 112864 113096 232 0.2
text 811580 812260 680 0.1
nrf7002dk_nrf5340_cpuapp (read/write) 1222456 1223256 800 0.1
rodata 141792 141936 144 0.1
text 807192 807868 676 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1051372 1052360 988 0.1
rodata 100220 100456 236 0.2
text 773620 774376 756 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834440 834456 16 0.0
(read/write) 1796556 1798068 1512 0.1
.text 1589268 1590796 1528 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837584 837600 16 0.0
(read/write) 1718612 1720116 1504 0.1
.text 1514468 1515988 1520 0.1
light cy8ckit_062s2_43012 (read only) 844312 844328 16 0.0
(read/write) 1637732 1638868 1136 0.1
.text 1440316 1441468 1152 0.1
lock cy8ckit_062s2_43012 (read only) 817160 817176 16 0.0
(read/write) 1667620 1668636 1016 0.1
.text 1443052 1444084 1032 0.1
qpg lighting-app qpg6105+debug (read/write) 1129932 1130628 696 0.1
.text 642312 643008 696 0.1
lock-app qpg6105+debug (read/write) 1090036 1090796 760 0.1
.text 602420 603180 760 0.1
stm32 light STM32WB5MM-DK (read/write) 601145 601969 824 0.1
.rodata 79644 79884 240 0.3
.text 382760 383360 600 0.2
telink air-quality-sensor-app tlsr9528a_retention (read/write) 824010 824662 652 0.1
text 616812 617228 416 0.1
all-clusters-app tlsr9518adk80d (read/write) 1092708 1093512 804 0.1
text 793840 794424 584 0.1
all-clusters-minimal-app tlsr9528a (read/write) 1050180 1051096 916 0.1
text 765162 765854 692 0.1
bridge-app tlsr9518adk80d (read/write) 910892 911528 636 0.1
text 652636 653052 416 0.1
contact-sensor-app tlsr9528a_retention (read/write) 825642 826326 684 0.1
text 618502 618950 448 0.1
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 931352 931988 636 0.1
text 698646 699046 400 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1074072 1074828 756 0.1
text 778024 778564 540 0.1
lock-app-dfu tlsr9528a (read/write) 903752 904516 764 0.1
text 653914 654438 524 0.1
ota-requestor-app tlsr9518adk80d (read/write) 930012 930680 668 0.1
text 671796 672244 448 0.1
pump-app tlsr9258a_retention (read/write) 828226 828878 652 0.1
text 621482 621898 416 0.1
pump-controller-app tlsr9518adk80d (read/write) 791940 792592 652 0.1
text 592240 592656 416 0.1
smoke_co_alarm-app tlsr9528a_retention (read/write) 833178 833870 692 0.1
text 624872 625330 458 0.1
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 851909 852561 652 0.1
text 636950 637366 416 0.1
thermostat tlsr9518adk80d (read/write) 817596 818280 684 0.1
text 611924 612372 448 0.1
window-covering tlsr9258a (read/write) 835688 836372 684 0.1
text 627180 627628 448 0.1
Decreases (47 builds for bl602, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section bdb88bd 97f3fe2 change % change
bl602 lighting-app bl602 .bss 85352 85336 -16 -0.0
bl602+mfd .bss 85512 85496 -16 -0.0
bl602+rpc .bss 93384 93368 -16 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read/write) 168624 168616 -8 -0.0
.bss 90628 90620 -8 -0.0
lock-ftd LP_EM_CC1354P10_6 (read/write) 178872 178864 -8 -0.0
.bss 100876 100868 -8 -0.0
lock-mtd LP_EM_CC1354P10_6 (read/write) 173312 173304 -8 -0.0
.bss 95316 95308 -8 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read/write) 167800 167792 -8 -0.0
.bss 89584 89576 -8 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read/write) 207992 207976 -16 -0.0
.bss 201228 201212 -16 -0.0
lock CC3235SF_LAUNCHXL (read/write) 208336 208320 -16 -0.0
.bss 201720 201704 -16 -0.0
cyw30739 light cyw930739m2evb_01 .bss 65080 65064 -16 -0.0
lock cyw930739m2evb_01 .bss 69832 69816 -16 -0.0
ota-requestor cyw930739m2evb_01 .bss 63616 63600 -16 -0.0
switch cyw930739m2evb_01 .bss 66816 66800 -16 -0.0
efr32 lighting-app BRD4161A+rs9116 .bss 197936 197920 -16 -0.0
BRD4187C .bss 195176 195160 -16 -0.0
lock-app BRD4161A+wf200 .bss 186788 186772 -16 -0.0
window-app BRD4187C .bss 167424 167408 -16 -0.0
esp32 all-clusters-app c3devkit .dram0.bss 74320 74304 -16 -0.0
k32w contact k32w1+release .bss 79212 79204 -8 -0.0
light k32w1+release .bss 80604 80596 -8 -0.0
linux air-purifier-app debug .rodata 185008 184784 -224 -0.1
all-clusters-app debug .rodata 349648 349296 -352 -0.1
all-clusters-minimal-app debug .rodata 288682 288330 -352 -0.1
bridge-app debug .rodata 229290 229034 -256 -0.1
chip-tool-ipv6only arm64 (read/write) 588160 586784 -1376 -0.2
lighting-app debug+rpc+ui .rodata 354484 354132 -352 -0.1
lock-app debug .rodata 255306 255050 -256 -0.1
ota-provider-app debug .rodata 207850 207498 -352 -0.2
ota-requestor-app debug .rodata 213962 213770 -192 -0.1
shell debug .rodata 185632 185344 -288 -0.2
tv-casting-app debug .rodata 383032 382776 -256 -0.1
mbed lock-app-release cy8cproto_062_4343w .bss 220472 220456 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 130855 130839 -16 -0.0
nrf7002dk_nrf5340_cpuapp bss 122945 122929 -16 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 bss 129713 129697 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .bss 196236 196220 -16 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .bss 193116 193100 -16 -0.0
light cy8ckit_062s2_43012 .bss 186580 186564 -16 -0.0
lock cy8ckit_062s2_43012 .bss 213740 213724 -16 -0.0
qpg lighting-app qpg6105+debug .bss 102480 102472 -8 -0.0
lock-app qpg6105+debug .bss 97224 97216 -8 -0.0
stm32 light STM32WB5MM-DK .bss 128344 128328 -16 -0.0
telink all-clusters-app tlsr9518adk80d bss 101804 101788 -16 -0.0
all-clusters-minimal-app tlsr9528a bss 110108 110092 -16 -0.0
bridge-app tlsr9518adk80d bss 93140 93124 -16 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d bss 100220 100204 -16 -0.0
ota-requestor-app tlsr9518adk80d bss 92720 92704 -16 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section bdb88bd 97f3fe2 change % change
bl602 lighting-app bl602 (read/write) 1437482 1440002 2520 0.2
.bss 85352 85336 -16 -0.0
.data 9496 9496 0 0.0
.rodata 158376 158680 304 0.2
.text 1103612 1105848 2236 0.2
bl602+mfd (read/write) 1452162 1454426 2264 0.2
.bss 85512 85496 -16 -0.0
.data 9472 9472 0 0.0
.rodata 157336 157640 304 0.2
.text 1119186 1121166 1980 0.2
bl602+rpc (read/write) 1485138 1487658 2520 0.2
.bss 93384 93368 -16 -0.0
.data 9872 9872 0 0.0
.rodata 165952 166256 304 0.2
.text 1135258 1137494 2236 0.2
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1201927 1204451 2524 0.2
.bss 11133 11133 0 0.0
.data 3680 3680 0 0.0
.rodata 107732 108036 304 0.3
.text 972512 974748 2236 0.2
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1212983 1215507 2524 0.2
.bss 11309 11309 0 0.0
.data 3656 3656 0 0.0
.rodata 106672 106976 304 0.3
.text 984522 986758 2236 0.2
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1293675 1296199 2524 0.2
.bss 19613 19613 0 0.0
.data 4216 4216 0 0.0
.rodata 123104 123408 304 0.2
.text 1047476 1049712 2236 0.2
bl706-eth (read/write) 1019897 1022165 2268 0.2
.bss 23708 23708 0 0.0
.data 3256 3256 0 0.0
.rodata 101064 101368 304 0.3
.text 763896 765876 1980 0.3
bl706-wifi (read/write) 1254414 1256594 2180 0.2
.bss 10577 10577 0 0.0
.data 3688 3688 0 0.0
.rodata 122064 122368 304 0.2
.text 995674 997566 1892 0.2
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1171504 1174028 2524 0.2
.bss 16328 16328 0 0.0
.data 5040 5040 0 0.0
.rodata 101736 102040 304 0.3
.text 965610 967846 2236 0.2
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1182908 1185176 2268 0.2
.bss 16504 16504 0 0.0
.data 5024 5024 0 0.0
.rodata 100676 100980 304 0.3
.text 977932 979912 1980 0.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 773956 774732 776 0.1
(read/write) 168624 168616 -8 -0.0
.bss 90628 90620 -8 -0.0
.data 3560 3560 0 0.0
.rodata 81756 81964 208 0.3
.text 691936 692504 568 0.1
lock-ftd LP_EM_CC1354P10_6 (read only) 790492 791236 744 0.1
(read/write) 178872 178864 -8 -0.0
.bss 100876 100868 -8 -0.0
.data 3560 3560 0 0.0
.rodata 76004 76212 208 0.3
.text 714224 714760 536 0.1
lock-mtd LP_EM_CC1354P10_6 (read only) 779148 779868 720 0.1
(read/write) 173312 173304 -8 -0.0
.bss 95316 95308 -8 -0.0
.data 3560 3560 0 0.0
.rodata 102756 102956 200 0.2
.text 676128 676648 520 0.1
pump-app LP_EM_CC1354P10_6 (read only) 731308 731932 624 0.1
(read/write) 167592 167592 0 0.0
.bss 89360 89360 0 0.0
.data 3552 3552 0 0.0
.rodata 77420 77628 208 0.3
.text 653624 654040 416 0.1
pump-controller-app LP_EM_CC1354P10_6 (read only) 716948 717564 616 0.1
(read/write) 167800 167792 -8 -0.0
.bss 89584 89576 -8 -0.0
.data 3544 3544 0 0.0
.rodata 73268 73468 200 0.3
.text 643416 643832 416 0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 583338 584178 840 0.1
(read/write) 207992 207976 -16 -0.0
.bss 201228 201212 -16 -0.0
.data 1640 1640 0 0.0
.rodata 86602 86874 272 0.3
.text 494612 495180 568 0.1
lock CC3235SF_LAUNCHXL (read only) 628610 629650 1040 0.2
(read/write) 208336 208320 -16 -0.0
.bss 201720 201704 -16 -0.0
.data 1496 1496 0 0.0
.rodata 107058 107338 280 0.3
.text 519428 520188 760 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 569139 569875 736 0.1
.app_xip_area 458893 459645 752 0.2
.bss 65080 65064 -16 -0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551867 552555 688 0.1
.app_xip_area 436861 437565 704 0.2
.bss 69832 69816 -16 -0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572019 572747 728 0.1
.app_xip_area 463277 464021 744 0.2
.bss 63616 63600 -16 -0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564923 565547 624 0.1
.app_xip_area 452901 453541 640 0.1
.bss 66816 66800 -16 -0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 933208 934360 1152 0.1
.bss 197936 197920 -16 -0.0
.data 1396 1396 0 0.0
.text 733852 735020 1168 0.2
BRD4187C (read/write) 1110336 1111128 792 0.1
.bss 195176 195160 -16 -0.0
.data 3416 3416 0 0.0
.text 911724 912532 808 0.1
lock-app BRD4161A+wf200 (read/write) 1122844 1123516 672 0.1
.bss 186788 186772 -16 -0.0
.data 2800 2800 0 0.0
.text 933236 933924 688 0.1
window-app BRD4187C (read/write) 1157080 1158000 920 0.1
.bss 167424 167408 -16 -0.0
.data 3328 3328 0 0.0
.text 986308 987244 936 0.1
esp32 all-clusters-app c3devkit (read only) 1211588 1212270 682 0.1
(read/write) 1749696 1749912 216 0.0
.dram0.bss 74320 74304 -16 -0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 252224 252456 232 0.1
.flash.text 1211588 1212270 682 0.1
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1253855 1255019 1164 0.1
(read/write) 536248 536568 320 0.1
.dram0.bss 81232 81240 8 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 283932 284244 312 0.1
.flash.text 1247691 1248855 1164 0.1
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 606352 607024 672 0.1
(read/write) 79636 82764 3128 3.9
.bss 67452 67468 16 0.0
.data 2200 2200 0 0.0
.text 605816 606488 672 0.1
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 747792 748344 552 0.1
.bss 79212 79204 -8 -0.0
.data 2816 2816 0 0.0
.text 626392 626952 560 0.1
light k32w0+release (read only) 610024 610736 712 0.1
(read/write) 79520 82636 3116 3.9
.bss 67332 67340 8 0.0
.data 2204 2204 0 0.0
.text 609488 610200 712 0.1
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 790460 791132 672 0.1
.bss 80604 80596 -8 -0.0
.data 2032 2032 0 0.0
.text 668464 669144 680 0.1
lock k32w0+release (read only) 589904 590648 744 0.1
(read/write) 77508 80628 3120 4.0
.bss 65372 65388 16 0.0
.data 2152 2152 0 0.0
.text 589368 590112 744 0.1
linux air-purifier-app debug (read only) 2617245 2619509 2264 0.1
(read/write) 128960 129376 416 0.3
.bss 46544 46544 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74248 74680 432 0.6
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 185008 184784 -224 -0.1
.text 2254773 2256325 1552 0.1
all-clusters-app debug (read only) 5923313 5926793 3480 0.1
(read/write) 480432 480880 448 0.1
.bss 134848 134880 32 0.0
.data 4528 4528 0 0.0
.data.rel.ro 333640 334072 432 0.1
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1384 1384 0 0.0
.rodata 349648 349296 -352 -0.1
.text 5140291 5143187 2896 0.1
all-clusters-minimal-app debug (read only) 5203857 5207145 3288 0.1
(read/write) 236384 236832 448 0.2
.bss 127680 127712 32 0.0
.data 4432 4432 0 0.0
.data.rel.ro 97208 97640 432 0.4
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 288682 288330 -352 -0.1
.text 4680467 4683171 2704 0.1
bridge-app debug (read only) 4598305 4600521 2216 0.0
(read/write) 217232 217648 416 0.2
.bss 118176 118176 0 0.0
.data 6208 6208 0 0.0
.data.rel.ro 86144 86576 432 0.5
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 229290 229034 -256 -0.1
.text 4148723 4150259 1536 0.0
chip-tool debug (read only) 12034281 12042481 8200 0.1
(read/write) 521512 521960 448 0.1
.bss 94424 94456 32 0.0
.data 5122 5122 0 0.0
.data.rel.ro 414744 415168 424 0.1
.dynamic 624 624 0 0.0
.got 5768 5768 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 448665 449049 384 0.1
.text 10879843 10886723 6880 0.1
chip-tool-ipv6only arm64 (read only) 11357788 11367372 9584 0.1
(read/write) 588160 586784 -1376 -0.2
.bss 103512 103528 16 0.0
.data 4496 4496 0 0.0
.data.rel.ro 454528 455016 488 0.1
.dynamic 512 512 0 0.0
.got 16976 16984 8 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 354508 355020 512 0.1
.text 10124968 10132888 7920 0.1
lighting-app debug+rpc+ui (read only) 5521945 5524625 2680 0.0
(read/write) 226024 226440 416 0.2
.bss 119144 119144 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94544 94976 432 0.5
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 354484 354132 -352 -0.1
.text 4920787 4922883 2096 0.0
lock-app debug (read only) 4666033 4668553 2520 0.1
(read/write) 204816 205232 416 0.2
.bss 113600 113600 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80392 80808 416 0.5
.dynamic 624 624 0 0.0
.got 5200 5200 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 255306 255050 -256 -0.1
.text 4199075 4200915 1840 0.0
ota-provider-app debug (read only) 4297865 4300033 2168 0.1
(read/write) 193288 193736 448 0.2
.bss 113280 113280 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69776 70208 432 0.6
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207850 207498 -352 -0.2
.text 3897043 3898627 1584 0.0
ota-requestor-app debug (read only) 4427273 4429729 2456 0.1
(read/write) 197720 198136 416 0.2
.bss 114208 114208 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72896 73328 432 0.6
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 213962 213770 -192 -0.1
.text 4015795 4017507 1712 0.0
shell debug (read only) 2891065 2894369 3304 0.1
(read/write) 156352 156768 416 0.3
.bss 62736 62736 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86464 86888 424 0.5
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185632 185344 -288 -0.2
.text 2532114 2534770 2656 0.1
thermostat-no-ble arm64 (read only) 4417412 4420860 3448 0.1
(read/write) 245528 246168 640 0.3
.bss 121832 121832 0 0.0
.data 3376 3376 0 0.0
.data.rel.ro 103624 104048 424 0.4
.dynamic 512 512 0 0.0
.got 8616 8624 8 0.1
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 159388 159476 88 0.1
.text 3923384 3925688 2304 0.1
tv-app debug (read only) 5706257 5715161 8904 0.2
(read/write) 352584 353064 480 0.1
.bss 244368 244400 32 0.0
.data 6528 6528 0 0.0
.data.rel.ro 94424 94856 432 0.5
.dynamic 624 624 0 0.0
.got 5496 5496 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 289994 290154 160 0.1
.text 5174179 5181987 7808 0.2
tv-casting-app debug (read only) 9865225 9867649 2424 0.0
(read/write) 340296 340744 448 0.1
.bss 156272 156272 0 0.0
.data 2976 2976 0 0.0
.data.rel.ro 174176 174608 432 0.2
.dynamic 624 624 0 0.0
.got 5072 5072 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 383032 382776 -256 -0.1
.text 9016451 9018195 1744 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2532432 2533168 736 0.0
.bss 220472 220456 -16 -0.0
.data 5200 5200 0 0.0
.text 1495116 1495852 736 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1103128 1104032 904 0.1
bss 130855 130839 -16 -0.0
rodata 112864 113096 232 0.2
text 811580 812260 680 0.1
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1222456 1223256 800 0.1
bss 122945 122929 -16 -0.0
rodata 141792 141936 144 0.1
text 807192 807868 676 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1051372 1052360 988 0.1
bss 129713 129697 -16 -0.0
rodata 100220 100456 236 0.2
text 773620 774376 756 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834440 834456 16 0.0
(read/write) 1796556 1798068 1512 0.1
.bss 196236 196220 -16 -0.0
.data 2664 2664 0 0.0
.text 1589268 1590796 1528 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837584 837600 16 0.0
(read/write) 1718612 1720116 1504 0.1
.bss 193116 193100 -16 -0.0
.data 2640 2640 0 0.0
.text 1514468 1515988 1520 0.1
light cy8ckit_062s2_43012 (read only) 844312 844328 16 0.0
(read/write) 1637732 1638868 1136 0.1
.bss 186580 186564 -16 -0.0
.data 2448 2448 0 0.0
.text 1440316 1441468 1152 0.1
lock cy8ckit_062s2_43012 (read only) 817160 817176 16 0.0
(read/write) 1667620 1668636 1016 0.1
.bss 213740 213724 -16 -0.0
.data 2440 2440 0 0.0
.text 1443052 1444084 1032 0.1
qpg lighting-app qpg6105+debug (read/write) 1129932 1130628 696 0.1
.bss 102480 102472 -8 -0.0
.data 824 824 0 0.0
.text 642312 643008 696 0.1
lock-app qpg6105+debug (read/write) 1090036 1090796 760 0.1
.bss 97224 97216 -8 -0.0
.data 844 844 0 0.0
.text 602420 603180 760 0.1
stm32 light STM32WB5MM-DK (read/write) 601145 601969 824 0.1
.bss 128344 128328 -16 -0.0
.data 668 668 0 0.0
.rodata 79644 79884 240 0.3
.text 382760 383360 600 0.2
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824010 824662 652 0.1
bss 49684 49684 0 0.0
text 616812 617228 416 0.1
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1092708 1093512 804 0.1
bss 101804 101788 -16 -0.0
text 793840 794424 584 0.1
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1050180 1051096 916 0.1
bss 110108 110092 -16 -0.0
text 765162 765854 692 0.1
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 910892 911528 636 0.1
bss 93140 93124 -16 -0.0
text 652636 653052 416 0.1
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825642 826326 684 0.1
bss 49732 49732 0 0.0
text 618502 618950 448 0.1
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 931352 931988 636 0.1
bss 77732 77732 0 0.0
text 698646 699046 400 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1074072 1074828 756 0.1
bss 100220 100204 -16 -0.0
text 778024 778564 540 0.1
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 903752 904516 764 0.1
bss 69196 69196 0 0.0
text 653914 654438 524 0.1
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 930012 930680 668 0.1
bss 92720 92704 -16 -0.0
text 671796 672244 448 0.1
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 828226 828878 652 0.1
bss 49840 49840 0 0.0
text 621482 621898 416 0.1
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 791940 792592 652 0.1
bss 56040 56040 0 0.0
text 592240 592656 416 0.1
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 677224 677224 0 0.0
bss 73672 73672 0 0.0
text 462484 462484 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833178 833870 692 0.1
bss 51364 51364 0 0.0
text 624872 625330 458 0.1
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 851909 852561 652 0.1
bss 59516 59516 0 0.0
text 636950 637366 416 0.1
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 817596 818280 684 0.1
bss 56328 56328 0 0.0
text 611924 612372 448 0.1
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 835688 836372 684 0.1
bss 68104 68104 0 0.0
text 627180 627628 448 0.1

@tehampson tehampson mentioned this pull request Mar 12, 2024
Open
53 tasks
andy31415
andy31415 reviewed Mar 19, 2024
View reviewed changes
src/app/CommandHandler.h Outdated Show resolved Hide resolved
andy31415
andy31415 reviewed Mar 19, 2024
View reviewed changes
src/app/CommandHandler.h Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Apr 1, 2024
View reviewed changes
.github/workflows/lint.yml Show resolved Hide resolved
src/app/CommandResponderInterface.h Outdated Show resolved Hide resolved
src/app/CommandResponderInterface.h Outdated Show resolved Hide resolved
src/app/CommandResponderInterface.h Outdated Show resolved Hide resolved
src/app/CommandResponderInterface.h Outdated Show resolved Hide resolved
src/app/CommandResponseSender.cpp Outdated Show resolved Hide resolved
src/app/CommandResponseSender.h Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Show resolved Hide resolved
src/app/CommandResponseSender.h Outdated Show resolved Hide resolved
src/app/InteractionModelEngine.cpp Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes Apr 2, 2024
View reviewed changes
src/app/CommandHandlerExchangeInterface.h Outdated Show resolved Hide resolved
src/app/CommandHandlerExchangeInterface.h Outdated Show resolved Hide resolved
src/app/CommandHandlerExchangeInterface.h Outdated Show resolved Hide resolved
src/app/CommandHandlerExchangeInterface.h Outdated Show resolved Hide resolved
src/app/CommandHandlerExchangeInterface.h Show resolved Hide resolved
src/app/CommandResponseSender.h Show resolved Hide resolved
src/app/InteractionModelEngine.cpp Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 5fbe16d into project-chip:master Apr 3, 2024
67 checks passed
@tehampson tehampson mentioned this pull request Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app github review - approved tests workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tehampson @andy31415 @bzbarsky-apple @restyled-commits