-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs][SiWx917] Getting the button pressed and button release in sync in sleep wakeup for btn0 #32458
Conversation
PR #32458: Size comparison from e52724f to 874144d Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32458: Size comparison from e52724f to 4feafff Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove need for global variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is the right way to fix this.
4feafff
to
73aa5cb
Compare
PR #32458: Size comparison from bdb88bd to 8f2bc81 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
8f2bc81
to
1978ef6
Compare
PR #32458: Size comparison from 86af239 to 4970874 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…nc in sleep wakeup for btn0 (project-chip#32458) * fixing the btn0 for 917soc sleepy * Restyled by clang-format * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Issue
Once the device wakes up from sleep it handles a button release event due to the hardware(pull up resistor)
Fix
Checking if the btn was not pressed just released no need of going forward. Making sure pressed and release are in sync