[Silabs]Fix gendiag network interface attribute #32390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #32390: Size comparison from bd6866b to a535c3b Increases (10 builds for bl702, bl702l, efr32, linux)
Decreases (23 builds for bl702l, efr32, linux, nrfconnect, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@jmartinez-silabs This also fixes #32244 too, then! |
mkardous-silabs
approved these changes
Mar 1, 2024
bzbarsky-apple
approved these changes
Mar 1, 2024
Sarthak-Shaha
pushed a commit
to Sarthak-Shaha/connectedhomeip_silabs
that referenced
this pull request
Mar 5, 2024
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Mar 7, 2024
jmartinez-silabs
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Mar 18, 2024
…R-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390) Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_network_interface to RC_2.3.0-1.3-alpha.3 Squashed commit of the following: commit 933bdcd4d196d5d0ec9c18933a54ebb28450c679 Author: Junior Martinez <[email protected]> Date: Tue Mar 5 20:40:01 2024 +0000 Pull request project-chip#1610: MATTER-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390) Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_networkinterace to RC_2.3.0-1.3 Squashed commit of the following: commit 247758db24fd10d49d8376b561905aae96b2cbaf Author: Junior Martinez <[email protected]> Date: Fri Mar 1 20:02:29 2024 -0500 Fix gendiag network interface attribute (project-chip#32390)
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
rcasallas-silabs
pushed a commit
to rcasallas-silabs/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…R-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390) Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_network_interface to RC_2.3.0-1.3-alpha.3 Squashed commit of the following: commit 933bdcd4d196d5d0ec9c18933a54ebb28450c679 Author: Junior Martinez <[email protected]> Date: Tue Mar 5 20:40:01 2024 +0000 Pull request project-chip#1610: MATTER-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390) Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_networkinterace to RC_2.3.0-1.3 Squashed commit of the following: commit 247758db24fd10d49d8376b561905aae96b2cbaf Author: Junior Martinez <[email protected]> Date: Fri Mar 1 20:02:29 2024 -0500 Fix gendiag network interface attribute (project-chip#32390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32243
Fixes #32244
The root issue for the invalid HardwareAddress was from
GenericConfigurationManagerImpl<ConfigClass>::GetPrimary802154MACAddressusing the interface classThreadStackManagerwhich doesn't have the object instead of the singleton implementationThreadStackMgr. It was previously returning garbage and that fix applies to any other users of the genericConfigurationMgr().GetPrimary802154MACAddressAlso, the Silabs Thread interface Ipv6 addresses were not encoded at all in the attribute read response so this PR also adds it.
Manually tested:
Confirmation that it matches the MAC addresses used for the hostname.
First IPV6 address also matches the DNS entry. I validate the rest with the ot cli ipaddr command on the device.