Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose logging backend on a per-target basis #32119

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Choose logging backend on a per-target basis #32119

merged 1 commit into from
Jun 25, 2024

Conversation

mbknust
Copy link
Contributor

@mbknust mbknust commented Feb 14, 2024 •
edited
Loading

Problem

This PR aims to fix #30633, which is due to a hack used for selecting logging backend:

connectedhomeip/src/platform/logging/BUILD.gn

Lines 57 to 68 in 783c3e0

# Depending on this target (via public_deps) pulls in the stdio
# logger and ensures it takes precendce over the platform backend.
group("force_stdio") {
deps = [ ":stdio" ]
public_configs = [ ":force_stdio_config" ]
}
config("force_stdio_config") {
# Ensure the linker sees the stdio implementation first. This
# works because ldflags come before inputs on the command line.
ldflags = [ rebase_path(stdio_archive, root_build_dir) ]
}

Changes

Following suggestions by @ksperling-apple, I created two separate targets: platform/logging:default and platform/logging:stdio. All executables and shared libraries built by this project, will now explicitly depend on one or the other.

External code, which uses chip as a library, now also has an option to choose which logging backend gets used. By default, if it links against libCHIP, nothing should change. But now a second variant is also built, called libCHIP_using_stdio. It is possible to choose which one will get linked from within CMake, by setting CONFIG_CHIP_FORCE_LOGGING_STDIO. This is used by openiotsdk unit tests, which should continue logging to stdio, even though this platform usually uses the other logging backend.

@github-actions GitHub Actions
Copy link

PR #32119: Size comparison from 27b8143 to 630e62b

Full report (2 builds for cc32xx)
platform target config section 27b8143 630e62b change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581170 581170 0 0.0
(read/write) 207960 207960 0 0.0
.bss 201196 201196 0 0.0
.data 1640 1640 0 0.0
.rodata 86474 86474 0 0.0
.text 492576 492576 0 0.0
lock CC3235SF_LAUNCHXL (read only) 626458 626458 0 0.0
(read/write) 208304 208304 0 0.0
.bss 201688 201688 0 0.0
.data 1496 1496 0 0.0
.rodata 106930 106930 0 0.0
.text 517408 517408 0 0.0

@mbknust mbknust force-pushed the fix-logging branch 2 times, most recently from ac38549 to 7a43751 Compare February 14, 2024 14:40
@github-actions GitHub Actions
Copy link

PR #32119: Size comparison from 598356c to 7a43751

Full report (2 builds for cc32xx)
platform target config section 598356c 7a43751 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581170 581170 0 0.0
(read/write) 207960 207960 0 0.0
.bss 201196 201196 0 0.0
.data 1640 1640 0 0.0
.rodata 86474 86474 0 0.0
.text 492576 492576 0 0.0
lock CC3235SF_LAUNCHXL (read only) 626458 626458 0 0.0
(read/write) 208304 208304 0 0.0
.bss 201688 201688 0 0.0
.data 1496 1496 0 0.0
.rodata 106930 106930 0 0.0
.text 517408 517408 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited
Loading

PR #32119: Size comparison from 598356c to 735ae9c

Increases above 0.2%:

platform target config section 598356c 735ae9c change % change
bl702 lighting-app bl702 .bss 11121 11377 256 2.3
bl702+mfd .bss 11297 11553 256 2.3
bl702+rpc .bss 19589 19845 256 1.3
bl706-eth .bss 23680 23936 256 1.1
bl706-wifi .bss 10565 10821 256 2.4
bl702l lighting-app bl702l .bss 16316 16572 256 1.6
bl702l+mfd .bss 16492 16748 256 1.6
Increases (8 builds for bl602, bl702, bl702l)
platform target config section 598356c 735ae9c change % change
bl602 lighting-app bl602+rpc (read/write) 1478062 1478078 16 0.0
.text 1129248 1129262 14 0.0
bl702 lighting-app bl702 (read/write) 1195279 1195411 132 0.0
.bss 11121 11377 256 2.3
.text 966944 967076 132 0.0
bl702+mfd (read/write) 1206335 1206439 104 0.0
.bss 11297 11553 256 2.3
.text 978954 979058 104 0.0
bl702+rpc (read/write) 1287003 1287015 12 0.0
.bss 19589 19845 256 1.3
.text 1041888 1041900 12 0.0
bl706-eth .bss 23680 23936 256 1.1
bl706-wifi .bss 10565 10821 256 2.4
bl702l lighting-app bl702l .bss 16316 16572 256 1.6
bl702l+mfd .bss 16492 16748 256 1.6
Decreases (7 builds for bl602, bl702, bl702l, qpg)
platform target config section 598356c 735ae9c change % change
bl602 lighting-app bl602 .text 1097862 1097860 -2 -0.0
bl602+mfd .text 1113164 1113162 -2 -0.0
bl702 lighting-app bl706-eth (read/write) 1013889 1013885 -4 -0.0
.text 758942 758940 -2 -0.0
bl706-wifi (read/write) 1247094 1247086 -8 -0.0
.text 989390 989382 -8 -0.0
bl702l lighting-app bl702l (read/write) 1164860 1164844 -16 -0.0
.text 960046 960030 -16 -0.0
bl702l+mfd (read/write) 1176776 1176760 -16 -0.0
.text 972368 972352 -16 -0.0
qpg lighting-app qpg6105+debug (read/write) 1124704 1124696 -8 -0.0
.text 637088 637080 -8 -0.0
Full report (15 builds for bl602, bl702, bl702l, cc32xx, qpg, stm32)
platform target config section 598356c 735ae9c change % change
bl602 lighting-app bl602 (read/write) 1430678 1430678 0 0.0
.bss 85304 85304 0 0.0
.data 9496 9496 0 0.0
.rodata 157376 157376 0 0.0
.text 1097862 1097860 -2 -0.0
bl602+mfd (read/write) 1445086 1445086 0 0.0
.bss 85464 85464 0 0.0
.data 9472 9472 0 0.0
.rodata 156336 156336 0 0.0
.text 1113164 1113162 -2 -0.0
bl602+rpc (read/write) 1478062 1478078 16 0.0
.bss 93336 93336 0 0.0
.data 9872 9872 0 0.0
.rodata 164944 164944 0 0.0
.text 1129248 1129262 14 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1195279 1195411 132 0.0
.bss 11121 11377 256 2.3
.data 3680 3680 0 0.0
.rodata 106700 106700 0 0.0
.text 966944 967076 132 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1206335 1206439 104 0.0
.bss 11297 11553 256 2.3
.data 3656 3656 0 0.0
.rodata 105640 105640 0 0.0
.text 978954 979058 104 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1287003 1287015 12 0.0
.bss 19589 19845 256 1.3
.data 4224 4224 0 0.0
.rodata 122072 122072 0 0.0
.text 1041888 1041900 12 0.0
bl706-eth (read/write) 1013889 1013885 -4 -0.0
.bss 23680 23936 256 1.1
.data 3248 3248 0 0.0
.rodata 100080 100080 0 0.0
.text 758942 758940 -2 -0.0
bl706-wifi (read/write) 1247094 1247086 -8 -0.0
.bss 10565 10821 256 2.4
.data 3688 3688 0 0.0
.rodata 121060 121060 0 0.0
.text 989390 989382 -8 -0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1164860 1164844 -16 -0.0
.bss 16316 16572 256 1.6
.data 5040 5040 0 0.0
.rodata 100704 100704 0 0.0
.text 960046 960030 -16 -0.0
bl702l+mfd (read/write) 1176776 1176760 -16 -0.0
.bss 16492 16748 256 1.6
.data 5024 5024 0 0.0
.rodata 99644 99644 0 0.0
.text 972368 972352 -16 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581170 581170 0 0.0
(read/write) 207960 207960 0 0.0
.bss 201196 201196 0 0.0
.data 1640 1640 0 0.0
.rodata 86474 86474 0 0.0
.text 492576 492576 0 0.0
lock CC3235SF_LAUNCHXL (read only) 626458 626458 0 0.0
(read/write) 208304 208304 0 0.0
.bss 201688 201688 0 0.0
.data 1496 1496 0 0.0
.rodata 106930 106930 0 0.0
.text 517408 517408 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1124704 1124696 -8 -0.0
.bss 102376 102376 0 0.0
.data 820 820 0 0.0
.text 637088 637080 -8 -0.0
lock-app qpg6105+debug (read/write) 1084696 1084696 0 0.0
.bss 97128 97128 0 0.0
.data 840 840 0 0.0
.text 597076 597076 0 0.0
stm32 light STM32WB5MM-DK (read/write) 597077 597077 0 0.0
.bss 128288 128288 0 0.0
.data 668 668 0 0.0
.rodata 78708 78708 0 0.0
.text 379688 379688 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 15, 2024 •
edited
Loading

PR #32119: Size comparison from 274719d to 259e656

Increases above 0.2%:

platform target config section 274719d 259e656 change % change
bl702 lighting-app bl702 .bss 11121 11377 256 2.3
bl702+mfd .bss 11297 11553 256 2.3
bl702+rpc .bss 19589 19845 256 1.3
bl706-eth .bss 23680 23936 256 1.1
bl706-wifi .bss 10565 10821 256 2.4
bl702l lighting-app bl702l .bss 16316 16572 256 1.6
bl702l+mfd .bss 16492 16748 256 1.6
Increases (9 builds for bl602, bl702, bl702l, qpg)
platform target config section 274719d 259e656 change % change
bl602 lighting-app bl602+rpc (read/write) 1478062 1478078 16 0.0
.text 1129240 1129254 14 0.0
bl702 lighting-app bl702 .bss 11121 11377 256 2.3
bl702+mfd (read/write) 1206411 1206515 104 0.0
.bss 11297 11553 256 2.3
.text 979012 979116 104 0.0
bl702+rpc (read/write) 1287083 1287095 12 0.0
.bss 19589 19845 256 1.3
.text 1041946 1041958 12 0.0
bl706-eth .bss 23680 23936 256 1.1
bl706-wifi .bss 10565 10821 256 2.4
bl702l lighting-app bl702l .bss 16316 16572 256 1.6
bl702l+mfd .bss 16492 16748 256 1.6
qpg lock-app qpg6105+debug (read/write) 1084920 1084944 24 0.0
.text 597300 597324 24 0.0
Decreases (7 builds for bl602, bl702, bl702l)
platform target config section 274719d 259e656 change % change
bl602 lighting-app bl602 .text 1097854 1097852 -2 -0.0
bl602+mfd .text 1113156 1113154 -2 -0.0
bl702 lighting-app bl702 (read/write) 1195615 1195491 -124 -0.0
.text 967258 967134 -124 -0.0
bl706-eth .text 758904 758902 -2 -0.0
bl706-wifi (read/write) 1247058 1247050 -8 -0.0
.text 989352 989344 -8 -0.0
bl702l lighting-app bl702l (read/write) 1165448 1165432 -16 -0.0
.text 960104 960088 -16 -0.0
bl702l+mfd (read/write) 1176856 1176840 -16 -0.0
.text 972426 972410 -16 -0.0
Full report (15 builds for bl602, bl702, bl702l, cc32xx, qpg, stm32)
platform target config section 274719d 259e656 change % change
bl602 lighting-app bl602 (read/write) 1430670 1430670 0 0.0
.bss 85304 85304 0 0.0
.data 9496 9496 0 0.0
.rodata 157376 157376 0 0.0
.text 1097854 1097852 -2 -0.0
bl602+mfd (read/write) 1445078 1445078 0 0.0
.bss 85464 85464 0 0.0
.data 9472 9472 0 0.0
.rodata 156336 156336 0 0.0
.text 1113156 1113154 -2 -0.0
bl602+rpc (read/write) 1478062 1478078 16 0.0
.bss 93336 93336 0 0.0
.data 9872 9872 0 0.0
.rodata 164952 164952 0 0.0
.text 1129240 1129254 14 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1195615 1195491 -124 -0.0
.bss 11121 11377 256 2.3
.data 3680 3680 0 0.0
.rodata 106720 106720 0 0.0
.text 967258 967134 -124 -0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1206411 1206515 104 0.0
.bss 11297 11553 256 2.3
.data 3656 3656 0 0.0
.rodata 105660 105660 0 0.0
.text 979012 979116 104 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1287083 1287095 12 0.0
.bss 19589 19845 256 1.3
.data 4224 4224 0 0.0
.rodata 122092 122092 0 0.0
.text 1041946 1041958 12 0.0
bl706-eth (read/write) 1013837 1013837 0 0.0
.bss 23680 23936 256 1.1
.data 3248 3248 0 0.0
.rodata 100068 100068 0 0.0
.text 758904 758902 -2 -0.0
bl706-wifi (read/write) 1247058 1247050 -8 -0.0
.bss 10565 10821 256 2.4
.data 3688 3688 0 0.0
.rodata 121064 121064 0 0.0
.text 989352 989344 -8 -0.0
bl702l lighting-app bl702l (read/write) 1165448 1165432 -16 -0.0
.bss 16316 16572 256 1.6
.data 5040 5040 0 0.0
.rodata 100724 100724 0 0.0
.text 960104 960088 -16 -0.0
bl702l+mfd (read/write) 1176856 1176840 -16 -0.0
.bss 16492 16748 256 1.6
.data 5024 5024 0 0.0
.rodata 99664 99664 0 0.0
.text 972426 972410 -16 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581074 581074 0 0.0
(read/write) 207960 207960 0 0.0
.bss 201196 201196 0 0.0
.data 1640 1640 0 0.0
.rodata 86458 86458 0 0.0
.text 492492 492492 0 0.0
lock CC3235SF_LAUNCHXL (read only) 626370 626370 0 0.0
(read/write) 208304 208304 0 0.0
.bss 201688 201688 0 0.0
.data 1496 1496 0 0.0
.rodata 106914 106914 0 0.0
.text 517332 517332 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1124928 1124928 0 0.0
.bss 102376 102376 0 0.0
.data 820 820 0 0.0
.text 637312 637312 0 0.0
lock-app qpg6105+debug (read/write) 1084920 1084944 24 0.0
.bss 97128 97128 0 0.0
.data 840 840 0 0.0
.text 597300 597324 24 0.0
stm32 light STM32WB5MM-DK (read/write) 597461 597461 0 0.0
.bss 128288 128288 0 0.0
.data 668 668 0 0.0
.rodata 78724 78724 0 0.0
.text 380056 380056 0 0.0

@mbknust mbknust force-pushed the fix-logging branch 2 times, most recently from 8b27c3d to f0bdb79 Compare February 15, 2024 14:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 15, 2024 •
edited
Loading

PR #32119: Size comparison from 274719d to f0bdb79

Increases above 0.2%:

platform target config section 274719d f0bdb79 change % change
bl702 lighting-app bl702 .bss 11121 11377 256 2.3
bl702+mfd .bss 11297 11553 256 2.3
bl702+rpc .bss 19589 19845 256 1.3
bl706-eth .bss 23680 23936 256 1.1
bl706-wifi .bss 10565 10821 256 2.4
bl702l lighting-app bl702l .bss 16316 16572 256 1.6
bl702l+mfd .bss 16492 16748 256 1.6
Increases (9 builds for bl602, bl702, bl702l, qpg)
platform target config section 274719d f0bdb79 change % change
bl602 lighting-app bl602+rpc (read/write) 1478062 1478078 16 0.0
.text 1129240 1129254 14 0.0
bl702 lighting-app bl702 .bss 11121 11377 256 2.3
bl702+mfd (read/write) 1206411 1206515 104 0.0
.bss 11297 11553 256 2.3
.text 979012 979116 104 0.0
bl702+rpc (read/write) 1287083 1287095 12 0.0
.bss 19589 19845 256 1.3
.text 1041946 1041958 12 0.0
bl706-eth .bss 23680 23936 256 1.1
bl706-wifi .bss 10565 10821 256 2.4
bl702l lighting-app bl702l .bss 16316 16572 256 1.6
bl702l+mfd .bss 16492 16748 256 1.6
qpg lock-app qpg6105+debug (read/write) 1084920 1084944 24 0.0
.text 597300 597324 24 0.0
Decreases (7 builds for bl602, bl702, bl702l)
platform target config section 274719d f0bdb79 change % change
bl602 lighting-app bl602 .text 1097854 1097852 -2 -0.0
bl602+mfd .text 1113156 1113154 -2 -0.0
bl702 lighting-app bl702 (read/write) 1195615 1195491 -124 -0.0
.text 967258 967134 -124 -0.0
bl706-eth .text 758904 758902 -2 -0.0
bl706-wifi (read/write) 1247058 1247050 -8 -0.0
.text 989352 989344 -8 -0.0
bl702l lighting-app bl702l (read/write) 1165448 1165432 -16 -0.0
.text 960104 960088 -16 -0.0
bl702l+mfd (read/write) 1176856 1176840 -16 -0.0
.text 972426 972410 -16 -0.0
Full report (15 builds for bl602, bl702, bl702l, cc32xx, qpg, stm32)
platform target config section 274719d f0bdb79 change % change
bl602 lighting-app bl602 (read/write) 1430670 1430670 0 0.0
.bss 85304 85304 0 0.0
.data 9496 9496 0 0.0
.rodata 157376 157376 0 0.0
.text 1097854 1097852 -2 -0.0
bl602+mfd (read/write) 1445078 1445078 0 0.0
.bss 85464 85464 0 0.0
.data 9472 9472 0 0.0
.rodata 156336 156336 0 0.0
.text 1113156 1113154 -2 -0.0
bl602+rpc (read/write) 1478062 1478078 16 0.0
.bss 93336 93336 0 0.0
.data 9872 9872 0 0.0
.rodata 164952 164952 0 0.0
.text 1129240 1129254 14 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1195615 1195491 -124 -0.0
.bss 11121 11377 256 2.3
.data 3680 3680 0 0.0
.rodata 106720 106720 0 0.0
.text 967258 967134 -124 -0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1206411 1206515 104 0.0
.bss 11297 11553 256 2.3
.data 3656 3656 0 0.0
.rodata 105660 105660 0 0.0
.text 979012 979116 104 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1287083 1287095 12 0.0
.bss 19589 19845 256 1.3
.data 4224 4224 0 0.0
.rodata 122092 122092 0 0.0
.text 1041946 1041958 12 0.0
bl706-eth (read/write) 1013837 1013837 0 0.0
.bss 23680 23936 256 1.1
.data 3248 3248 0 0.0
.rodata 100068 100068 0 0.0
.text 758904 758902 -2 -0.0
bl706-wifi (read/write) 1247058 1247050 -8 -0.0
.bss 10565 10821 256 2.4
.data 3688 3688 0 0.0
.rodata 121064 121064 0 0.0
.text 989352 989344 -8 -0.0
bl702l lighting-app bl702l (read/write) 1165448 1165432 -16 -0.0
.bss 16316 16572 256 1.6
.data 5040 5040 0 0.0
.rodata 100724 100724 0 0.0
.text 960104 960088 -16 -0.0
bl702l+mfd (read/write) 1176856 1176840 -16 -0.0
.bss 16492 16748 256 1.6
.data 5024 5024 0 0.0
.rodata 99664 99664 0 0.0
.text 972426 972410 -16 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581074 581074 0 0.0
(read/write) 207960 207960 0 0.0
.bss 201196 201196 0 0.0
.data 1640 1640 0 0.0
.rodata 86458 86458 0 0.0
.text 492492 492492 0 0.0
lock CC3235SF_LAUNCHXL (read only) 626370 626370 0 0.0
(read/write) 208304 208304 0 0.0
.bss 201688 201688 0 0.0
.data 1496 1496 0 0.0
.rodata 106914 106914 0 0.0
.text 517332 517332 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1124928 1124928 0 0.0
.bss 102376 102376 0 0.0
.data 820 820 0 0.0
.text 637312 637312 0 0.0
lock-app qpg6105+debug (read/write) 1084920 1084944 24 0.0
.bss 97128 97128 0 0.0
.data 840 840 0 0.0
.text 597300 597324 24 0.0
stm32 light STM32WB5MM-DK (read/write) 597461 597461 0 0.0
.bss 128288 128288 0 0.0
.data 668 668 0 0.0
.rodata 78724 78724 0 0.0
.text 380056 380056 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

PR #32119: Size comparison from 947fef5 to 0f62542

Increases above 0.2%:

platform target config section 947fef5 0f62542 change % change
bl702 lighting-app bl702 RAM 14897 15161 264 1.8
bl702+mfd RAM 15049 15313 264 1.8
bl702+rpc RAM 23925 24181 256 1.1
bl706-eth RAM 27016 27272 256 0.9
bl706-wifi RAM 14349 14605 256 1.8
bl702l lighting-app bl702l RAM 21468 21732 264 1.2
bl702l+mfd RAM 21628 21892 264 1.2
tizen all-clusters-app arm unknown 1548 1556 8 0.5
Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 947fef5 0f62542 change % change
bl602 lighting-app bl602 FLASH 1270530 1270528 -2 -0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284808 1284786 -22 -0.0
RAM 95480 95472 -8 -0.0
bl602+rpc FLASH 1309730 1309744 14 0.0
RAM 103760 103752 -8 -0.0
bl702 lighting-app bl702 FLASH 1091426 1091424 -2 -0.0
RAM 14897 15161 264 1.8
bl702+mfd FLASH 1102120 1102118 -2 -0.0
RAM 15049 15313 264 1.8
bl702+rpc FLASH 1181236 1181234 -2 -0.0
RAM 23925 24181 256 1.1
bl706-eth FLASH 874770 874768 -2 -0.0
RAM 27016 27272 256 0.9
bl706-wifi FLASH 1127064 1127062 -2 -0.0
RAM 14349 14605 256 1.8
bl702l lighting-app bl702l FLASH 1078312 1078310 -2 -0.0
RAM 21468 21732 264 1.2
bl702l+mfd FLASH 1089574 1089572 -2 -0.0
RAM 21628 21892 264 1.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798076 798088 12 0.0
RAM 103088 103096 8 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813752 813748 -4 -0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803268 803272 4 0.0
RAM 107688 107696 8 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756060 756080 20 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741724 741736 12 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605750 605738 -12 -0.0
RAM 204512 204508 -4 -0.0
lock CC3235SF_LAUNCHXL FLASH 650770 650766 -4 -0.0
RAM 204772 204780 8 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661673 661665 -8 -0.0
RAM 74512 74512 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638453 638453 0 0.0
RAM 69580 69580 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 604137 604137 0 0.0
RAM 70216 70216 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623773 623765 -8 -0.0
RAM 72768 72768 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623773 623765 -8 -0.0
RAM 72768 72768 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619641 619641 0 0.0
RAM 73232 73232 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639357 639349 -8 -0.0
RAM 75784 75784 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639357 639349 -8 -0.0
RAM 75784 75784 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 588213 588213 0 0.0
RAM 67200 67200 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 608073 608057 -16 -0.0
RAM 69832 69832 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 608073 608057 -16 -0.0
RAM 69832 69832 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88340 16 0.0
FLASH 1468918 1468928 10 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1538067 1538075 8 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4536 -32 -0.7
FLASH 2535024 2534864 -160 -0.0
RAM 129072 129048 -24 -0.0
all-clusters-app debug unknown 5344 5320 -24 -0.4
FLASH 5581550 5581342 -208 -0.0
RAM 483272 483288 16 0.0
all-clusters-minimal-app debug unknown 5264 5240 -24 -0.5
FLASH 5054984 5054808 -176 -0.0
RAM 236824 236840 16 0.0
bridge-app debug unknown 5232 5208 -24 -0.5
FLASH 4480632 4480392 -240 -0.0
RAM 216736 216736 0 0.0
chip-tool debug unknown 5744 5712 -32 -0.6
FLASH 11527527 11527367 -160 -0.0
RAM 535450 535450 0 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10663892 10663892 0 0.0
RAM 583416 583416 0 0.0
fabric-admin debug unknown 5600 5592 -8 -0.1
FLASH 10526455 10526263 -192 -0.0
RAM 529466 529466 0 0.0
fabric-bridge-app debug unknown 5240 5216 -24 -0.5
FLASH 4350568 4350328 -240 -0.0
RAM 208784 208784 0 0.0
lighting-app debug+rpc+ui unknown 5880 5880 0 0.0
FLASH 5377746 5377298 -448 -0.0
RAM 225640 225608 -32 -0.0
lock-app debug unknown 5184 5160 -24 -0.5
FLASH 4544296 4544088 -208 -0.0
RAM 204192 204184 -8 -0.0
ota-provider-app debug unknown 4552 4528 -24 -0.5
FLASH 4180008 4179768 -240 -0.0
RAM 193216 193200 -16 -0.0
ota-requestor-app debug unknown 4488 4464 -24 -0.5
FLASH 4305496 4305256 -240 -0.0
RAM 197872 197856 -16 -0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2801965 2801997 32 0.0
RAM 154416 154416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4152804 4152780 -24 -0.0
RAM 234608 234608 0 0.0
tv-app debug unknown 5472 5448 -24 -0.4
FLASH 5597304 5597176 -128 -0.0
RAM 345672 345720 48 0.0
tv-casting-app debug unknown 5104 5064 -40 -0.8
FLASH 9572774 9572550 -224 -0.0
RAM 352816 352792 -24 -0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497580 1497564 -16 -0.0
RAM 226072 226072 0 0.0
nxp contact k32w0+release FLASH 575604 575580 -24 -0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590736 590728 -8 -0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609680 609680 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674224 674240 16 0.0
RAM 82808 82816 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613428 1613452 24 0.0
RAM 207132 207148 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534228 1534220 -8 -0.0
RAM 204036 204052 16 0.0
light cy8ckit_062s2_43012 FLASH 1461092 1461100 8 0.0
RAM 197316 197332 16 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224380 224396 16 0.0
qpg lighting-app qpg6105+debug FLASH 650576 650580 4 0.0
RAM 104556 104564 8 0.0
lock-app qpg6105+debug FLASH 610700 610720 20 0.0
RAM 99232 99240 8 0.0
stm32 light STM32WB5MM-DK FLASH 472112 472128 16 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625532 625534 2 0.0
RAM 49904 49904 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 602572 602574 2 0.0
RAM 130288 130288 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770694 770706 12 0.0
RAM 110052 110052 0 0.0
bridge-app tlsr9258a FLASH 668618 668620 2 0.0
RAM 94672 94672 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 627254 627256 2 0.0
RAM 49948 49948 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713368 713384 16 0.0
RAM 76540 76540 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558240 558248 8 0.0
RAM 126544 126544 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793320 793320 0 0.0
RAM 99900 99900 0 0.0
lock-app-dfu tlsr9528a FLASH 660356 660358 2 0.0
RAM 69228 69228 0 0.0
ota-requestor-app tlsr9258a FLASH 687236 687238 2 0.0
RAM 94396 94396 0 0.0
pump-app tlsr9518adk80d FLASH 609474 609476 2 0.0
RAM 56328 56328 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599860 599862 2 0.0
RAM 56128 56128 0 0.0
shell tlsr9518adk80d FLASH 462614 462630 16 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633616 633618 2 0.0
RAM 51576 51576 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642974 642976 2 0.0
RAM 59764 59764 0 0.0
thermostat tlsr9518adk80d FLASH 618750 618752 2 0.0
RAM 56452 56452 0 0.0
window-covering tlsr9118bdk40d FLASH 464942 464952 10 0.0
RAM 82224 82224 0 0.0
tizen all-clusters-app arm unknown 1548 1556 8 0.5
FLASH 1621556 1621412 -144 -0.0
RAM 45420 45412 -8 -0.0
chip-tool-ubsan arm unknown 2360 2364 4 0.2
FLASH 15767058 15766942 -116 -0.0
RAM 6917600 6917600 0 0.0

mbknust
mbknust commented Jun 18, 2024
View reviewed changes
src/lib/BUILD.gn Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

PR #32119: Size comparison from 947fef5 to 658f1ae

Increases above 0.2%:

platform target config section 947fef5 658f1ae change % change
bl702 lighting-app bl702 RAM 14897 15161 264 1.8
bl702+mfd RAM 15049 15313 264 1.8
bl702+rpc RAM 23925 24181 256 1.1
bl706-eth RAM 27016 27272 256 0.9
bl706-wifi RAM 14349 14605 256 1.8
bl702l lighting-app bl702l RAM 21468 21732 264 1.2
bl702l+mfd RAM 21628 21892 264 1.2
tizen all-clusters-app arm unknown 1548 1556 8 0.5
Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nxp, psoc6, qpg, stm32, tizen)
platform target config section 947fef5 658f1ae change % change
bl602 lighting-app bl602 FLASH 1270530 1270528 -2 -0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284808 1284786 -22 -0.0
RAM 95480 95472 -8 -0.0
bl602+rpc FLASH 1309730 1309744 14 0.0
RAM 103760 103752 -8 -0.0
bl702 lighting-app bl702 FLASH 1091426 1091424 -2 -0.0
RAM 14897 15161 264 1.8
bl702+mfd FLASH 1102120 1102118 -2 -0.0
RAM 15049 15313 264 1.8
bl702+rpc FLASH 1181236 1181234 -2 -0.0
RAM 23925 24181 256 1.1
bl706-eth FLASH 874770 874768 -2 -0.0
RAM 27016 27272 256 0.9
bl706-wifi FLASH 1127064 1127062 -2 -0.0
RAM 14349 14605 256 1.8
bl702l lighting-app bl702l FLASH 1078312 1078310 -2 -0.0
RAM 21468 21732 264 1.2
bl702l+mfd FLASH 1089574 1089572 -2 -0.0
RAM 21628 21892 264 1.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798076 798088 12 0.0
RAM 103088 103096 8 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813752 813748 -4 -0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803268 803272 4 0.0
RAM 107688 107696 8 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756060 756080 20 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741724 741736 12 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605750 605738 -12 -0.0
RAM 204512 204508 -4 -0.0
lock CC3235SF_LAUNCHXL FLASH 650770 650766 -4 -0.0
RAM 204772 204780 8 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661673 661665 -8 -0.0
RAM 74512 74512 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638453 638453 0 0.0
RAM 69580 69580 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 604137 604137 0 0.0
RAM 70216 70216 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623773 623765 -8 -0.0
RAM 72768 72768 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623773 623765 -8 -0.0
RAM 72768 72768 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619641 619641 0 0.0
RAM 73232 73232 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639357 639349 -8 -0.0
RAM 75784 75784 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639357 639349 -8 -0.0
RAM 75784 75784 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 588213 588213 0 0.0
RAM 67200 67200 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 608073 608057 -16 -0.0
RAM 69832 69832 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 608073 608057 -16 -0.0
RAM 69832 69832 0 0.0
linux chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10663892 10663892 0 0.0
RAM 583416 583416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4152804 4152780 -24 -0.0
RAM 234608 234608 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497580 1497564 -16 -0.0
RAM 226072 226072 0 0.0
nxp contact k32w0+release FLASH 575604 575580 -24 -0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590736 590728 -8 -0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609680 609680 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674224 674240 16 0.0
RAM 82808 82816 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613428 1613452 24 0.0
RAM 207132 207148 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534228 1534220 -8 -0.0
RAM 204036 204052 16 0.0
light cy8ckit_062s2_43012 FLASH 1461092 1461100 8 0.0
RAM 197316 197332 16 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224380 224396 16 0.0
qpg lighting-app qpg6105+debug FLASH 650576 650580 4 0.0
RAM 104556 104564 8 0.0
lock-app qpg6105+debug FLASH 610700 610720 20 0.0
RAM 99232 99240 8 0.0
stm32 light STM32WB5MM-DK FLASH 472112 472128 16 0.0
RAM 141652 141652 0 0.0
tizen all-clusters-app arm unknown 1548 1556 8 0.5
FLASH 1621556 1621412 -144 -0.0
RAM 45420 45412 -8 -0.0
chip-tool-ubsan arm unknown 2360 2364 4 0.2
FLASH 15767058 15766942 -116 -0.0
RAM 6917600 6917600 0 0.0

@mbknust mbknust force-pushed the fix-logging branch 2 times, most recently from 8348b26 to 0c9a960 Compare June 18, 2024 14:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

PR #32119: Size comparison from 917cf26 to 0c9a960

Increases above 0.2%:

platform target config section 917cf26 0c9a960 change % change
bl702 lighting-app bl702 RAM 14897 15161 264 1.8
bl702+mfd RAM 15049 15313 264 1.8
bl702+rpc RAM 23925 24181 256 1.1
bl706-eth RAM 27016 27272 256 0.9
bl706-wifi RAM 14349 14605 256 1.8
bl702l lighting-app bl702l RAM 21468 21732 264 1.2
bl702l+mfd RAM 21628 21892 264 1.2
tizen all-clusters-app arm unknown 1548 1556 8 0.5
Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 917cf26 0c9a960 change % change
bl602 lighting-app bl602 FLASH 1270530 1270528 -2 -0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284808 1284786 -22 -0.0
RAM 95480 95472 -8 -0.0
bl602+rpc FLASH 1309730 1309744 14 0.0
RAM 103760 103752 -8 -0.0
bl702 lighting-app bl702 FLASH 1091426 1091424 -2 -0.0
RAM 14897 15161 264 1.8
bl702+mfd FLASH 1102120 1102118 -2 -0.0
RAM 15049 15313 264 1.8
bl702+rpc FLASH 1181236 1181234 -2 -0.0
RAM 23925 24181 256 1.1
bl706-eth FLASH 874770 874768 -2 -0.0
RAM 27016 27272 256 0.9
bl706-wifi FLASH 1127064 1127062 -2 -0.0
RAM 14349 14605 256 1.8
bl702l lighting-app bl702l FLASH 1078312 1078310 -2 -0.0
RAM 21468 21732 264 1.2
bl702l+mfd FLASH 1089574 1089572 -2 -0.0
RAM 21628 21892 264 1.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798076 798088 12 0.0
RAM 103088 103096 8 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813752 813748 -4 -0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803268 803272 4 0.0
RAM 107688 107696 8 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756060 756080 20 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741724 741736 12 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605750 605738 -12 -0.0
RAM 204512 204508 -4 -0.0
lock CC3235SF_LAUNCHXL FLASH 650770 650766 -4 -0.0
RAM 204772 204780 8 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661673 661665 -8 -0.0
RAM 74512 74512 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638453 638453 0 0.0
RAM 69580 69580 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 604137 604137 0 0.0
RAM 70216 70216 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623773 623765 -8 -0.0
RAM 72768 72768 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623773 623765 -8 -0.0
RAM 72768 72768 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619641 619641 0 0.0
RAM 73232 73232 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639357 639349 -8 -0.0
RAM 75784 75784 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639357 639349 -8 -0.0
RAM 75784 75784 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 588213 588213 0 0.0
RAM 67200 67200 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 608073 608057 -16 -0.0
RAM 69832 69832 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 608073 608057 -16 -0.0
RAM 69832 69832 0 0.0
efr32 lighting-app BRD4187C FLASH 888232 888236 4 0.0
RAM 183424 183440 16 0.0
lock-app BRD4338a FLASH 699848 699856 8 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969752 4 0.0
RAM 167856 167872 16 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88340 16 0.0
FLASH 1468918 1468928 10 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1538067 1538075 8 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4536 -32 -0.7
FLASH 2535024 2534864 -160 -0.0
RAM 129072 129048 -24 -0.0
all-clusters-app debug unknown 5344 5320 -24 -0.4
FLASH 5581550 5581342 -208 -0.0
RAM 483272 483288 16 0.0
all-clusters-minimal-app debug unknown 5264 5240 -24 -0.5
FLASH 5054984 5054808 -176 -0.0
RAM 236824 236840 16 0.0
bridge-app debug unknown 5232 5208 -24 -0.5
FLASH 4480664 4480424 -240 -0.0
RAM 216736 216736 0 0.0
chip-tool debug unknown 5744 5712 -32 -0.6
FLASH 11527527 11527367 -160 -0.0
RAM 535450 535450 0 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10663892 10663892 0 0.0
RAM 583416 583416 0 0.0
fabric-admin debug unknown 5600 5592 -8 -0.1
FLASH 10526455 10526263 -192 -0.0
RAM 529466 529466 0 0.0
fabric-bridge-app debug unknown 5240 5216 -24 -0.5
FLASH 4350568 4350328 -240 -0.0
RAM 208784 208784 0 0.0
lighting-app debug+rpc+ui unknown 5880 5880 0 0.0
FLASH 5377746 5377298 -448 -0.0
RAM 225640 225608 -32 -0.0
lock-app debug unknown 5184 5160 -24 -0.5
FLASH 4544296 4544088 -208 -0.0
RAM 204192 204184 -8 -0.0
ota-provider-app debug unknown 4552 4528 -24 -0.5
FLASH 4180008 4179768 -240 -0.0
RAM 193216 193200 -16 -0.0
ota-requestor-app debug unknown 4488 4464 -24 -0.5
FLASH 4305496 4305256 -240 -0.0
RAM 197872 197856 -16 -0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2801965 2801997 32 0.0
RAM 154416 154416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4152804 4152780 -24 -0.0
RAM 234608 234608 0 0.0
tv-app debug unknown 5472 5448 -24 -0.4
FLASH 5597304 5597176 -128 -0.0
RAM 345672 345720 48 0.0
tv-casting-app debug unknown 5104 5064 -40 -0.8
FLASH 9572774 9572550 -224 -0.0
RAM 352816 352792 -24 -0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497580 1497564 -16 -0.0
RAM 226072 226072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 876200 876200 0 0.0
RAM 139129 139129 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949232 949232 0 0.0
RAM 137557 137557 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822416 822416 0 0.0
RAM 138027 138027 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 782128 782128 0 0.0
RAM 132088 132088 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 927668 927668 0 0.0
RAM 129781 129781 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 866464 866464 0 0.0
RAM 143839 143839 0 0.0
nrf52840dongle_nrf52840 FLASH 808236 808236 0 0.0
RAM 151844 151844 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 763976 763976 0 0.0
RAM 142645 142645 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 927668 927668 0 0.0
RAM 129781 129781 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 793784 793784 0 0.0
RAM 132611 132611 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 719080 719080 0 0.0
RAM 132677 132677 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 940260 940260 0 0.0
RAM 130304 130304 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 746552 746552 0 0.0
RAM 131296 131296 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 733164 733164 0 0.0
RAM 131095 131095 0 0.0
nxp contact k32w0+release FLASH 575604 575580 -24 -0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590736 590728 -8 -0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609680 609680 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674224 674240 16 0.0
RAM 82808 82816 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613428 1613452 24 0.0
RAM 207132 207148 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534228 1534220 -8 -0.0
RAM 204036 204052 16 0.0
light cy8ckit_062s2_43012 FLASH 1461092 1461100 8 0.0
RAM 197316 197332 16 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224380 224396 16 0.0
qpg lighting-app qpg6105+debug FLASH 650576 650580 4 0.0
RAM 104556 104564 8 0.0
lock-app qpg6105+debug FLASH 610700 610720 20 0.0
RAM 99232 99240 8 0.0
stm32 light STM32WB5MM-DK FLASH 472112 472128 16 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625532 625534 2 0.0
RAM 49904 49904 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 602572 602574 2 0.0
RAM 130288 130288 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770694 770706 12 0.0
RAM 110052 110052 0 0.0
bridge-app tlsr9258a FLASH 668618 668620 2 0.0
RAM 94672 94672 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 627254 627256 2 0.0
RAM 49948 49948 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713368 713384 16 0.0
RAM 76540 76540 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558240 558248 8 0.0
RAM 126544 126544 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793320 793320 0 0.0
RAM 99900 99900 0 0.0
lock-app-dfu tlsr9528a FLASH 660356 660358 2 0.0
RAM 69228 69228 0 0.0
ota-requestor-app tlsr9258a FLASH 687236 687238 2 0.0
RAM 94396 94396 0 0.0
pump-app tlsr9518adk80d FLASH 609474 609476 2 0.0
RAM 56328 56328 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599860 599862 2 0.0
RAM 56128 56128 0 0.0
shell tlsr9518adk80d FLASH 462614 462630 16 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633616 633618 2 0.0
RAM 51576 51576 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642974 642976 2 0.0
RAM 59764 59764 0 0.0
thermostat tlsr9518adk80d FLASH 618750 618752 2 0.0
RAM 56452 56452 0 0.0
window-covering tlsr9118bdk40d FLASH 464942 464952 10 0.0
RAM 82224 82224 0 0.0
tizen all-clusters-app arm unknown 1548 1556 8 0.5
FLASH 1621556 1621412 -144 -0.0
RAM 45420 45412 -8 -0.0
chip-tool-ubsan arm unknown 2360 2364 4 0.2
FLASH 15767058 15766942 -116 -0.0
RAM 6917600 6917600 0 0.0

@pullapprove pullapprove bot requested a review from ReneJosefsen June 18, 2024 15:32
@bzbarsky-apple
Copy link
Contributor

@mbknust Does this potentially fix whatever is going on with #24701 ?

andy31415
andy31415 reviewed Jun 20, 2024
View reviewed changes
src/lib/BUILD.gn Outdated Show resolved Hide resolved
andy31415
andy31415 reviewed Jun 20, 2024
View reviewed changes
src/lib/BUILD.gn Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

PR #32119: Size comparison from 07ac2f1 to 0407588

Increases above 0.2%:

platform target config section 07ac2f1 0407588 change % change
bl702 lighting-app bl702 RAM 14897 15161 264 1.8
bl702+mfd RAM 15049 15313 264 1.8
bl702+rpc RAM 23925 24181 256 1.1
bl706-eth RAM 27016 27272 256 0.9
bl706-wifi RAM 14349 14605 256 1.8
bl702l lighting-app bl702l RAM 21468 21732 264 1.2
bl702l+mfd RAM 21628 21892 264 1.2
tizen all-clusters-app arm unknown 1560 1568 8 0.5
Full report (29 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nxp, qpg, stm32, tizen)
platform target config section 07ac2f1 0407588 change % change
bl602 lighting-app bl602 FLASH 1270550 1270548 -2 -0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284828 1284806 -22 -0.0
RAM 95480 95472 -8 -0.0
bl602+rpc FLASH 1309750 1309764 14 0.0
RAM 103760 103752 -8 -0.0
bl702 lighting-app bl702 FLASH 1091446 1091444 -2 -0.0
RAM 14897 15161 264 1.8
bl702+mfd FLASH 1102140 1102138 -2 -0.0
RAM 15049 15313 264 1.8
bl702+rpc FLASH 1181256 1181254 -2 -0.0
RAM 23925 24181 256 1.1
bl706-eth FLASH 874790 874788 -2 -0.0
RAM 27016 27272 256 0.9
bl706-wifi FLASH 1127090 1127088 -2 -0.0
RAM 14349 14605 256 1.8
bl702l lighting-app bl702l FLASH 1078332 1078330 -2 -0.0
RAM 21468 21732 264 1.2
bl702l+mfd FLASH 1089594 1089592 -2 -0.0
RAM 21628 21892 264 1.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798004 798008 4 0.0
RAM 103088 103096 8 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813768 813764 -4 -0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803292 803288 -4 -0.0
RAM 107688 107696 8 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756068 756080 12 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741732 741752 20 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605766 605754 -12 -0.0
RAM 204512 204508 -4 -0.0
lock CC3235SF_LAUNCHXL FLASH 650786 650782 -4 -0.0
RAM 204772 204780 8 0.0
linux chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10680468 10680468 0 0.0
RAM 580120 580120 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4167108 4167084 -24 -0.0
RAM 235784 235800 16 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502084 1502076 -8 -0.0
RAM 226672 226656 -16 -0.0
nxp contact k32w0+release FLASH 575620 575596 -24 -0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590744 590736 -8 -0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609696 609680 -16 -0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674240 674248 8 0.0
RAM 82808 82816 8 0.0
qpg lighting-app qpg6105+debug FLASH 650608 650612 4 0.0
RAM 104556 104564 8 0.0
lock-app qpg6105+debug FLASH 610708 610736 28 0.0
RAM 99232 99240 8 0.0
stm32 light STM32WB5MM-DK FLASH 472048 472056 8 0.0
RAM 141652 141652 0 0.0
tizen all-clusters-app arm unknown 1560 1568 8 0.5
FLASH 1633100 1632952 -148 -0.0
RAM 46020 46012 -8 -0.0
chip-tool-ubsan arm unknown 2364 2368 4 0.2
FLASH 15882050 1588194 -104 -0.0
RAM 6972112 6972112 0 0.0

@mbknust
Choose logging backend on a per-target basis
2a680bc 
Executables and shared libraries now explicitly link with
`platform/logging:default` or `platform/logging:stdio`, so that the
`platform/logging:force_stdio` kludge is no longer needed.

The `chip_monolithic_tests` gn arg has been moved to `build/chip/tests.gni`.
@github-actions github-actions bot added the inet label Jun 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

PR #32119: Size comparison from 07ac2f1 to 2a680bc

Increases above 0.2%:

platform target config section 07ac2f1 2a680bc change % change
bl702 lighting-app bl702 RAM 14897 15161 264 1.8
bl702+mfd RAM 15049 15313 264 1.8
bl702+rpc RAM 23925 24181 256 1.1
bl706-eth RAM 27016 27272 256 0.9
bl706-wifi RAM 14349 14605 256 1.8
bl702l lighting-app bl702l RAM 21468 21732 264 1.2
bl702l+mfd RAM 21628 21892 264 1.2
tizen all-clusters-app arm unknown 1560 1568 8 0.5
Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 07ac2f1 2a680bc change % change
bl602 lighting-app bl602 FLASH 1270550 1270548 -2 -0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284828 1284806 -22 -0.0
RAM 95480 95472 -8 -0.0
bl602+rpc FLASH 1309750 1309764 14 0.0
RAM 103760 103752 -8 -0.0
bl702 lighting-app bl702 FLASH 1091446 1091444 -2 -0.0
RAM 14897 15161 264 1.8
bl702+mfd FLASH 1102140 1102138 -2 -0.0
RAM 15049 15313 264 1.8
bl702+rpc FLASH 1181256 1181254 -2 -0.0
RAM 23925 24181 256 1.1
bl706-eth FLASH 874790 874788 -2 -0.0
RAM 27016 27272 256 0.9
bl706-wifi FLASH 1127090 1127088 -2 -0.0
RAM 14349 14605 256 1.8
bl702l lighting-app bl702l FLASH 1078332 1078330 -2 -0.0
RAM 21468 21732 264 1.2
bl702l+mfd FLASH 1089594 1089592 -2 -0.0
RAM 21628 21892 264 1.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798004 798008 4 0.0
RAM 103088 103096 8 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813768 813764 -4 -0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803292 803288 -4 -0.0
RAM 107688 107696 8 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756068 756080 12 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741732 741752 20 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605766 605754 -12 -0.0
RAM 204512 204508 -4 -0.0
lock CC3235SF_LAUNCHXL FLASH 650786 650782 -4 -0.0
RAM 204772 204780 8 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 665785 665785 0 0.0
RAM 75100 75100 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 685645 685637 -8 -0.0
RAM 77732 77732 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 685645 685637 -8 -0.0
RAM 77732 77732 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 642573 642565 -8 -0.0
RAM 70168 70168 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608345 608345 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 627973 627981 8 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 627973 627981 8 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623833 623825 -8 -0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643541 643541 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643541 643541 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 592397 592397 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 612249 612249 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 612249 612249 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 888136 888140 4 0.0
RAM 183424 183440 16 0.0
lock-app BRD4338a FLASH 699864 699872 8 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969752 4 0.0
RAM 167856 167872 16 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88340 16 0.0
FLASH 1468846 1468856 10 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1537971 1537975 4 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4560 -32 -0.7
FLASH 2528240 2528064 -176 -0.0
RAM 125072 125048 -24 -0.0
all-clusters-app debug unknown 5368 5344 -24 -0.4
FLASH 5577966 5577774 -192 -0.0
RAM 479304 479320 16 0.0
all-clusters-minimal-app debug unknown 5288 5264 -24 -0.5
FLASH 5050424 5050248 -176 -0.0
RAM 232856 232872 16 0.0
bridge-app debug unknown 5256 5232 -24 -0.5
FLASH 4476456 4476248 -208 -0.0
RAM 212768 212768 0 0.0
chip-tool debug unknown 5728 5696 -32 -0.6
FLASH 11548279 11548103 -176 -0.0
RAM 531386 531386 0 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10680468 10680468 0 0.0
RAM 580120 580120 0 0.0
fabric-admin debug unknown 5584 5576 -8 -0.1
FLASH 10547175 10546967 -208 -0.0
RAM 525466 525434 -32 -0.0
fabric-bridge-app debug unknown 5264 5240 -24 -0.5
FLASH 4346984 4346792 -192 -0.0
RAM 204896 204896 0 0.0
lighting-app debug+rpc+ui unknown 5904 5904 0 0.0
FLASH 5372466 5371954 -512 -0.0
RAM 221672 221576 -96 -0.0
lock-app debug unknown 5192 5168 -24 -0.5
FLASH 4540056 4539848 -208 -0.0
RAM 200192 200184 -8 -0.0
ota-provider-app debug unknown 4576 4552 -24 -0.5
FLASH 4195816 4195592 -224 -0.0
RAM 194432 194448 16 0.0
ota-requestor-app debug unknown 4512 4488 -24 -0.5
FLASH 4321304 4321080 -224 -0.0
RAM 199088 199104 16 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2793693 2793693 0 0.0
RAM 150416 150416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4167108 4167084 -24 -0.0
RAM 235784 235800 16 0.0
tv-app debug unknown 5472 5448 -24 -0.4
FLASH 5593704 5593512 -192 -0.0
RAM 341672 341688 16 0.0
tv-casting-app debug unknown 5096 5056 -40 -0.8
FLASH 9595958 9595798 -160 -0.0
RAM 348848 348792 -56 -0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502084 1502076 -8 -0.0
RAM 226672 226656 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 880800 880800 0 0.0
RAM 139693 139693 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 951612 951612 0 0.0
RAM 138121 138121 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 826356 826356 0 0.0
RAM 138591 138591 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 786172 786172 0 0.0
RAM 132652 132652 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 931716 931716 0 0.0
RAM 130345 130345 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 870416 870416 0 0.0
RAM 144403 144403 0 0.0
nrf52840dongle_nrf52840 FLASH 812188 812188 0 0.0
RAM 152408 152408 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 767932 767932 0 0.0
RAM 143209 143209 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 931716 931716 0 0.0
RAM 130345 130345 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 797828 797828 0 0.0
RAM 133175 133175 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 723124 723124 0 0.0
RAM 133241 133241 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 944312 944312 0 0.0
RAM 130868 130868 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 750592 750592 0 0.0
RAM 131860 131860 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 737204 737204 0 0.0
RAM 131659 131659 0 0.0
nxp contact k32w0+release FLASH 575620 575596 -24 -0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590744 590736 -8 -0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609696 609680 -16 -0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674240 674248 8 0.0
RAM 82808 82816 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613348 1613356 8 0.0
RAM 207132 207148 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534116 1534108 -8 -0.0
RAM 204036 204052 16 0.0
light cy8ckit_062s2_43012 FLASH 1460996 1461004 8 0.0
RAM 197316 197332 16 0.0
lock cy8ckit_062s2_43012 FLASH 1462860 1462860 0 0.0
RAM 224380 224396 16 0.0
qpg lighting-app qpg6105+debug FLASH 650608 650612 4 0.0
RAM 104556 104564 8 0.0
lock-app qpg6105+debug FLASH 610708 610736 28 0.0
RAM 99232 99240 8 0.0
stm32 light STM32WB5MM-DK FLASH 472048 472056 8 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632146 632136 -10 -0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 657038 657028 -10 -0.0
RAM 145872 145872 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 777102 777102 0 0.0
RAM 110684 110684 0 0.0
bridge-app tlsr9258a FLASH 675130 675120 -10 -0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 633730 633720 -10 -0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 719508 719514 6 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 612180 612162 -18 -0.0
RAM 142104 142104 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 799734 799722 -12 -0.0
RAM 100508 100508 0 0.0
lock-app-dfu tlsr9528a FLASH 665294 665284 -10 -0.0
RAM 69860 69860 0 0.0
ota-requestor-app tlsr9258a FLASH 694460 694450 -10 -0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 615994 615984 -10 -0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606378 606368 -10 -0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466170 466182 12 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640090 640080 -10 -0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650204 650194 -10 -0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 625268 625258 -10 -0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 518726 518710 -16 -0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1560 1568 8 0.5
FLASH 1633100 1632952 -148 -0.0
RAM 46020 46012 -8 -0.0
chip-tool-ubsan arm unknown 2364 2368 4 0.2
FLASH 15882050 1588194 -104 -0.0
RAM 6972112 6972112 0 0.0

@mbknust
Copy link
Contributor Author

mbknust commented Jun 24, 2024

@mbknust Does this potentially fix whatever is going on with #24701 ?

It doesn't, timestamp printing would have to be added to the stdio logging backend.

@mergify mergify bot merged commit 686e73b into project-chip:master Jun 25, 2024
68 checks passed
@farshidtz farshidtz mentioned this pull request Jul 3, 2024
Merged
@yeaissa yeaissa mentioned this pull request Jul 5, 2024
Merged
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Jul 10, 2024
@mbknust @austina-csa
Choose logging backend on a per-target basis (project-chip#32119)
2e6b5af 
Executables and shared libraries now explicitly link with
`platform/logging:default` or `platform/logging:stdio`, so that the
`platform/logging:force_stdio` kludge is no longer needed.

The `chip_monolithic_tests` gn arg has been moved to `build/chip/tests.gni`.
@rquidute rquidute mentioned this pull request Jul 12, 2024
Closed
ksperling-apple added a commit to ksperling-apple/connectedhomeip that referenced this pull request Aug 5, 2024
@ksperling-apple
Remove workarounds for stdio logging target
8369c1e 
This is no longer needed as of project-chip#32119
@ksperling-apple ksperling-apple mentioned this pull request Aug 5, 2024
Merged
mergify bot pushed a commit that referenced this pull request Aug 6, 2024
@ksperling-apple
Tidy up logging dependencies (#34789)
653a55f 
* Remove workarounds for stdio logging target

This is no longer needed as of #32119

* Pull in android logging in the standard way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple left review comments

@arkq arkq arkq approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo joonhaengHeo is a code owner

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

Assignees
No one assigned
Labels
app config controller core darwin esp32 examples gn inet lib linux messaging nrf connect platform review - approved silabs telink test driver tests tizen For Tizen platform tools zephyr
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Linux Chip-tool GCC and Chip-tool clang do not link the same Logging implementation
5 participants
@mbknust @andy31415 @bzbarsky-apple @arkq @ksperling-apple