-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WiFi][Shell] Wifi Shell updates to improve shell commands. #31684
[WiFi][Shell] Wifi Shell updates to improve shell commands. #31684
Conversation
PR #31684: Size comparison from 39bcd5d to 34895d5 Full report (5 builds for cc32xx, qpg, stm32)
|
475156e
to
c03fad8
Compare
PR #31684: Size comparison from 9a81bed to c0873fa Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nxp, psoc6, qpg, stm32)
|
PR #31684: Size comparison from 9a81bed to c18c4a9 Full report (4 builds for cc32xx, mbed, stm32)
|
57b136c
to
df038d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some style related comments, but overall looks good.
ea43bbd
to
3f3f43e
Compare
PR #31684: Size comparison from d8245cb to 3f3f43e Full report (4 builds for cc32xx, mbed, stm32)
|
3f3f43e
to
f4983b9
Compare
f4983b9
to
13718f9
Compare
PR #31684: Size comparison from d8245cb to 13718f9 Increases (4 builds for esp32, linux)
Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
13718f9
to
b1878fd
Compare
PR #31684: Size comparison from 47c6d46 to b1878fd Increases (4 builds for esp32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
b1878fd
to
c44741f
Compare
PR #31684: Size comparison from b4a6213 to c44741f Increases (4 builds for esp32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
- "wifi connect" command was improved to work with credentials entered from shell - "wifi disconnect" command was created to disconnect from connected WiFi network
c44741f
to
b050cb4
Compare
PR #31684: Size comparison from 511c974 to b050cb4 Full report (4 builds for cc32xx, mbed, stm32)
|
… and enable CHIP_DEVICE_CONFIG_ENABLE_WIFI_STATION for all NXP WiFi platforms
016a933
to
07b6230
Compare
PR #31684: Size comparison from 9966940 to 982498d Increases (4 builds for esp32, linux)
Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…nds. (project-chip#31684) * [WiFi][Shell] Wifi Shell updates to improve shell commands. - "wifi connect" command was improved to work with credentials entered from shell - "wifi disconnect" command was created to disconnect from connected WiFi network * [NXP][platform][common] Update RemoveNetwork and Disconnect functions and enable CHIP_DEVICE_CONFIG_ENABLE_WIFI_STATION for all NXP WiFi platforms * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Fixes #29823