-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android]Return CHIP_ERROR_INVALID_IPK when providing the invalid IPK from and… #31491
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/return_ipk_error
Jan 18, 2024
Merged
[Android]Return CHIP_ERROR_INVALID_IPK when providing the invalid IPK from and… #31491
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/return_ipk_error
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran and
hawk248
January 17, 2024 18:53
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
January 17, 2024 18:53
PR #31491: Size comparison from 87e6da0 to a52f491 Increases (14 builds for linux)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/return_ipk_error
branch
from
January 18, 2024 01:11
a52f491
to
bc8e0aa
Compare
PR #31491: Size comparison from f2fa44a to bc8e0aa Increases (14 builds for linux)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 18, 2024
yunhanw-google
force-pushed
the
feature/return_ipk_error
branch
from
January 18, 2024 07:02
bc8e0aa
to
87387be
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jan 18, 2024
joonhaengHeo
approved these changes
Jan 18, 2024
PR #31491: Size comparison from b044b5e to 87387be Increases (14 builds for linux)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the IPK with invalid length is injected from android application to android controller jni, return CHIP_ERROR_INVALID_IPK, and print the error.
fixes: #29163