-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux/tv-casting-app: simplified APIs for commands and attributes #31164
Merged
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:interact-20231215
Jan 2, 2024
Merged
Linux/tv-casting-app: simplified APIs for commands and attributes #31164
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:interact-20231215
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
December 21, 2023 23:39
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
December 21, 2023 23:39
sharadb-amazon
force-pushed
the
interact-20231215
branch
from
December 21, 2023 23:48
6fb40e2
to
56f6d89
Compare
PR #31164: Size comparison from 52f66e1 to 56f6d89 Full report (5 builds for cc32xx, mbed, qpg)
|
sharadb-amazon
force-pushed
the
interact-20231215
branch
from
December 22, 2023 00:30
56f6d89
to
7626717
Compare
PR #31164: Size comparison from 52f66e1 to 7626717 Decreases (1 build for efr32)
Full report (60 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Dec 22, 2023
PR #31164: Size comparison from 52f66e1 to dd24db4 Increases above 0.2%:
Increases (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (3 builds for bl702l, linux, psoc6)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
sharadb-amazon
force-pushed
the
interact-20231215
branch
from
December 22, 2023 19:51
dd24db4
to
62a6f8b
Compare
sharadb-amazon
force-pushed
the
interact-20231215
branch
from
December 22, 2023 20:06
62a6f8b
to
8ed3dff
Compare
PR #31164: Size comparison from b364ee6 to 8ed3dff Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
younghak-hwang
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies and decouples the implementation of the APIs command invocations and attribute read/subscriptions old CastingServer.h/cpp for Linux
### Change summary
### Testing
Verified and tested locally with Linux TV app