-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReportScheduler] Empty node pool handling #31136
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/report_scheduler_timer_fired_no_nodes
Dec 21, 2023
Merged
[ReportScheduler] Empty node pool handling #31136
yufengwangca
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/report_scheduler_timer_fired_no_nodes
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
LuDuda,
mhazley,
mkardous-silabs and
mspang
December 20, 2023 16:57
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon and
vivien-apple
December 20, 2023 16:57
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
December 20, 2023 16:57
bzbarsky-apple
approved these changes
Dec 20, 2023
PR #31136: Size comparison from 19e202e to 977d1df Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Dec 20, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
lpbeliveau-silabs
force-pushed
the
bugfix/report_scheduler_timer_fired_no_nodes
branch
from
December 20, 2023 20:36
028d2a0
to
3b290c6
Compare
PR #31136: Size comparison from ad98820 to 3b290c6 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Dec 20, 2023
lpbeliveau-silabs
changed the title
[Report Scheduler] Empty node pool handling
[ReportScheduler] Empty node pool handling
Dec 20, 2023
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jan 10, 2024
…)" This reverts commit bd24a65.
lpbeliveau-silabs
deleted the
bugfix/report_scheduler_timer_fired_no_nodes
branch
December 10, 2024 14:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation led to scheduling an engine run when an empty node pool was encountered.
It didn't make sense so instead we just return on an empty pool in the TimerFired callback.