-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icd] Support Resubscribe when receiving check-in message #30812
[icd] Support Resubscribe when receiving check-in message #30812
Conversation
9cd1c88
to
a15dcd1
Compare
PR #30812: Size comparison from 8686f21 to a15dcd1 Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cc3081b
to
deb9aee
Compare
PR #30812: Size comparison from a4300e7 to deb9aee Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Calling OnActiveModeNotification from https://github.com/project-chip/connectedhomeip/blob/master/src/app/icd/client/DefaultCheckInDelegate.cpp#L40? |
deb9aee
to
175ff69
Compare
PR #30812: Size comparison from a4300e7 to 175ff69 Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
175ff69
to
30142dd
Compare
30142dd
to
138694d
Compare
PR #30812: Size comparison from a4300e7 to 138694d Increases above 0.2%:
Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
We might need to tweak things here as we go to adjust clients (Callback implementations) to handle ICDs, but this seems like a good basis to work from.
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
PR #30812: Size comparison from a4300e7 to 389e757 Increases (17 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #30812: Size comparison from a4300e7 to 5c6ec43 Increases above 0.2%:
Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This PR adds a new state
InactiveICDSubscription
to read client for subscripting to ICD.When the subscriber failed to receive the report, and the max period is passed, the readclient will enter the
InactiveICDSubscription
state.When
Check-In
messages are received by subscriber, it is required toOnActiveModeNotification()
theReadClient
, and resubscription logic will be triggered as usual.#29389