-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix onReport #30724
Merged
mergify
merged 4 commits into
project-chip:master
from
yunhanw-google:feature/fix_on_report
Nov 30, 2023
Merged
[Android] Fix onReport #30724
mergify
merged 4 commits into
project-chip:master
from
yunhanw-google:feature/fix_on_report
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
November 29, 2023 21:58
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
November 29, 2023 21:58
PR #30724: Size comparison from e690996 to db7394c Increases (1 build for cyw30739)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/fix_on_report
branch
from
November 30, 2023 02:46
db7394c
to
0c8c535
Compare
yunhanw-google
changed the title
return when OnError happens in OnReportEnd
[Android]Fix onReport
Nov 30, 2023
PR #30724: Size comparison from 03efab5 to d88e68e Increases (1 build for cyw30739)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yunhanw-google
force-pushed
the
feature/fix_on_report
branch
from
November 30, 2023 03:48
d88e68e
to
fb51c1c
Compare
PR #30724: Size comparison from 03efab5 to fb51c1c Increases (1 build for cyw30739)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
nicelyjust
approved these changes
Nov 30, 2023
andy31415
approved these changes
Nov 30, 2023
PR #30724: Size comparison from 03efab5 to b807c7e Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Nov 30, 2023
Can you add unit tests to verify this behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- return when OnError happens in OnReportEnd
-- in jni, onReport and onError needs to be mutual exclusive becuase onAttribute can be called multiple times
and that will then call OnError multiple times in application which could be the crash...We should follow c++ pattern, where onError and onReport are mutual exclusive.