-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Update ICDM Cluster XML to latest spec #30559
Merged
mkardous-silabs
merged 5 commits into
project-chip:master
from
mkardous-silabs:feature/icd_xml
Nov 19, 2023
Merged
[ICD] Update ICDM Cluster XML to latest spec #30559
mkardous-silabs
merged 5 commits into
project-chip:master
from
mkardous-silabs:feature/icd_xml
Nov 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
November 17, 2023 21:33
yunhanw-google
approved these changes
Nov 17, 2023
PR #30559: Size comparison from 916ba56 to 88c5403 Increases (1 build for linux)
Decreases (1 build for linux)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
andy31415
reviewed
Nov 17, 2023
andy31415
reviewed
Nov 17, 2023
src/app/zap-templates/zcl/data-model/chip/icd-management-cluster.xml
Outdated
Show resolved
Hide resolved
PR #30559: Size comparison from 916ba56 to 81fce2b Increases (5 builds for linux, telink)
Decreases (2 builds for esp32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 18, 2023
bzbarsky-apple
approved these changes
Nov 18, 2023
mkardous-silabs
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Nov 18, 2023
mkardous-silabs
force-pushed
the
feature/icd_xml
branch
from
November 18, 2023 13:46
27f9982
to
f9a257f
Compare
PR #30559: Size comparison from 54ff857 to f9a257f Increases (5 builds for linux, telink)
Decreases (2 builds for esp32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Add response to controller and lit icd app xmls
mkardous-silabs
force-pushed
the
feature/icd_xml
branch
from
November 18, 2023 22:53
f9a257f
to
b0d757b
Compare
PR #30559: Size comparison from d0a7cb1 to b0d757b Increases (5 builds for linux, telink)
Decreases (2 builds for esp32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #30357