-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PDC support in Network Commissioning cluster #30511
Implement PDC support in Network Commissioning cluster #30511
Conversation
PR #30511: Size comparison from d7c7f8e to b7fb256 Increases above 0.2%:
Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30511: Size comparison from d7c7f8e to e4797b8 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for cc13x4_26x4, esp32, linux, nrfconnect, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- Tidy up EnumerateAcceptedCommands - Move constructors out of header - Simplify debug text logic - Simplify enumeration of Iterator - Use CHIP_ERROR_FORMAT for logging errors - Refer to Status type name consistently
and add the relevant APIs to NetworkCommissioning::WiFiDriver.
e4797b8
to
0f8a8d4
Compare
PR #30511: Size comparison from e17a09c to 0f8a8d4 Increases above 0.2%:
Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* @param clientIdentityNetworkIndex If present, the index of the existing network configuration of which the Client | ||
* Identity is to be re-used. Otherwise a new Client Identity shall be generated. | ||
* @param outStatus The application-level status code (Status::kSuccess on success). | ||
* @param outDebugText A debug text buffer that may be populated by the driver when a Status is returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method now no longer ever returns a Status. The comments need to be fixed.
The two commits are best viewed separately:
Small refactorings of network-commissioning.cpp
Implement PDC support in Network Commissioning cluster and add the relevant APIs to NetworkCommissioning::WiFiDriver.