Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kotlin] Simplify the command functions into one by making use of nullable parameters in Kotlin. #30099

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[Kotlin] Simplify the command functions into one by making use of nullable parameters in Kotlin. #30099

merged 1 commit into from
Oct 30, 2023

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Oct 30, 2023 •
edited
Loading

We can merge the following two functions into one by making use of nullable parameters in Kotlin.

  suspend fun off() {  
    // Implementation needs to be added here
  }

  suspend fun off(timedInvokeTimeoutMs: Int) {  
    // Implementation needs to be added here
  }

Here's a simplified version:

suspend fun off(timedInvokeTimeoutMs: Int? = null) {
    // You can check if timedInvokeTimeoutMs is null and act accordingly:
    if (timedInvokeTimeoutMs != null) {
        // Do something with timedInvokeTimeoutMs
    } else {
        // Do the action that corresponds to the original off() without parameters
    }
}

You can now call off() without any argument, or provide an integer argument as required. If you provide an argument, timedInvokeTimeoutMs will hold that value. If you don't, timedInvokeTimeoutMs will be null.

@yufengwangca yufengwangca changed the title Make timedInvokeTimeoutMs optional [Kotlin] Simplify the command functions into one by making use of nullable parameters in Kotlin. Oct 30, 2023
@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

PR #30099: Size comparison from a16d6e9 to 227bbdb

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section a16d6e9 227bbdb change % change
bl602 lighting-app bl602 (read/write) 1409898 1409898 0 0.0
.bss 88488 88488 0 0.0
.data 9360 9360 0 0.0
.text 1075002 1075002 0 0.0
bl602+mfd (read/write) 1424058 1424058 0 0.0
.bss 88656 88656 0 0.0
.data 9336 9336 0 0.0
.text 1090062 1090062 0 0.0
bl602+rpc (read/write) 1456910 1456910 0 0.0
.bss 96520 96520 0 0.0
.data 9736 9736 0 0.0
.text 1106490 1106490 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1207823 1207823 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 32597 32597 0 0.0
.bss_psram 66128 66128 0 0.0
.comment 48 48 0 0.0
.data 3568 3568 0 0.0
.debug_abbrev 1552488 1552488 0 0.0
.debug_aranges 138888 138888 0 0.0
.debug_frame 508848 508848 0 0.0
.debug_info 41551674 41551674 0 0.0
.debug_line 5449608 5449608 0 0.0
.debug_loc 3657637 3657637 0 0.0
.debug_ranges 445216 445216 0 0.0
.debug_str 4085853 4085853 0 0.0
.hbn 584 584 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106572 106572 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 598978 598978 0 0.0
.symtab 178768 178768 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3478 3478 0 0.0
.text 0 0 0 0.0
972600 972600 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1218679 1218679 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 32773 32773 0 0.0
.bss_psram 66128 66128 0 0.0
.comment 48 48 0 0.0
.data 3552 3552 0 0.0
.debug_abbrev 1554219 1554219 0 0.0
.debug_aranges 140056 140056 0 0.0
.debug_frame 514280 514280 0 0.0
.debug_info 41591963 41591963 0 0.0
.debug_line 5489944 5489944 0 0.0
.debug_loc 3695799 3695799 0 0.0
.debug_ranges 447456 447456 0 0.0
.debug_str 4091384 4091384 0 0.0
.hbn 584 584 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105512 105512 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 602738 602738 0 0.0
.symtab 180528 180528 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3478 3478 0 0.0
.text 0 0 0 0.0
984372 984372 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1307835 1307835 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 41061 41061 0 0.0
.bss_psram 66112 66112 0 0.0
.comment 48 48 0 0.0
.data 4120 4120 0 0.0
.debug_abbrev 1733486 1733486 0 0.0
.debug_aranges 147504 147504 0 0.0
.debug_frame 537892 537892 0 0.0
.debug_info 46696336 46696336 0 0.0
.debug_line 5880029 5880029 0 0.0
.debug_loc 3865276 3865276 0 0.0
.debug_ranges 472784 472784 0 0.0
.debug_str 4513725 4513725 0 0.0
.hbn 584 584 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 164 164 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121472 121472 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 662935 662935 0 0.0
.symtab 197888 197888 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3478 3478 0 0.0
.text 0 0 0 0.0
1048152 1048152 0 0.0
bl706-eth (read/write) 995149 995149 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 27752 27752 0 0.0
.bss_psram 97975 97975 0 0.0
.comment 48 48 0 0.0
.data 3120 3120 0 0.0
.debug_abbrev 1071615 1071615 0 0.0
.debug_aranges 111720 111720 0 0.0
.debug_frame 412780 412780 0 0.0
.debug_info 2247366 2247366 0 0.0
.debug_line 4141120 4141120 0 0.0
.debug_loc 3075224 3075224 0 0.0
.debug_ranges 363632 363632 0 0.0
.debug_str 3628823 3628823 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99212 99212 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 457426 457426 0 0.0
.symtab 133408 133408 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3458 3458 0 0.0
.text 0 0 0 0.0
738144 738144 0 0.0
bl706-wifi (read/write) 1229938 1229938 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 14637 14637 0 0.0
.bss_psram 98727 98727 0 0.0
.comment 48 48 0 0.0
.data 3552 3552 0 0.0
.debug_abbrev 1187398 1187398 0 0.0
.debug_aranges 119384 119384 0 0.0
.debug_frame 618432 618432 0 0.0
.debug_info 23859865 23859865 0 0.0
.debug_line 4566030 4566030 0 0.0
.debug_loc 3262471 3262471 0 0.0
.debug_ranges 391488 391488 0 0.0
.debug_str 3730355 3730355 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120072 120072 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 506531 506531 0 0.0
.symtab 152704 152704 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3994 3994 0 0.0
.text 0 0 0 0.0
962204 962204 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1178368 1178368 0 0.0
.boot2 400 400 0 0.0
.bss 20576 20576 0 0.0
.bss_psram 79248 79248 0 0.0
.comment 48 48 0 0.0
.data 4936 4936 0 0.0
.debug_abbrev 1552749 1552749 0 0.0
.debug_aranges 134096 134096 0 0.0
.debug_frame 490804 490804 0 0.0
.debug_info 41369171 41369171 0 0.0
.debug_line 5377654 5377654 0 0.0
.debug_loc 3608145 3608145 0 0.0
.debug_ranges 453376 453376 0 0.0
.debug_str 4115627 4115627 0 0.0
.hbn 3220 3220 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100728 100728 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 602508 602508 0 0.0
.symtab 179392 179392 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 512 512 0 0.0
.text 0 0 0 0.0
962252 962252 0 0.0
bl702l+mfd (read/write) 1190348 1190348 0 0.0
.boot2 400 400 0 0.0
.bss 20752 20752 0 0.0
.bss_psram 79248 79248 0 0.0
.comment 48 48 0 0.0
.data 4912 4912 0 0.0
.debug_abbrev 1554495 1554495 0 0.0
.debug_aranges 135264 135264 0 0.0
.debug_frame 496232 496232 0 0.0
.debug_info 41411503 41411503 0 0.0
.debug_line 5417867 5417867 0 0.0
.debug_loc 3646307 3646307 0 0.0
.debug_ranges 455616 455616 0 0.0
.debug_str 4121148 4121148 0 0.0
.hbn 3220 3220 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99668 99668 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 606336 606336 0 0.0
.symtab 181184 181184 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 512 512 0 0.0
.text 0 0 0 0.0
974628 974628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 735867 735867 0 0.0
(read/write) 166436 166436 0 0.0
.bss 88852 88852 0 0.0
.data 3420 3420 0 0.0
.rodata 84375 84375 0 0.0
.text 651104 651104 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757459 757459 0 0.0
(read/write) 176720 176720 0 0.0
.bss 99100 99100 0 0.0
.data 3440 3440 0 0.0
.rodata 79943 79943 0 0.0
.text 677124 677124 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744795 744795 0 0.0
(read/write) 171176 171176 0 0.0
.bss 93556 93556 0 0.0
.data 3440 3440 0 0.0
.rodata 106031 106031 0 0.0
.text 638372 638372 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 695595 695595 0 0.0
(read/write) 165528 165528 0 0.0
.bss 87720 87720 0 0.0
.data 3408 3408 0 0.0
.rodata 80175 80175 0 0.0
.text 615032 615032 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 681267 681267 0 0.0
(read/write) 165668 165668 0 0.0
.bss 87864 87864 0 0.0
.data 3404 3404 0 0.0
.rodata 76007 76007 0 0.0
.text 604872 604872 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 562098 562098 0 0.0
(read/write) 206492 206492 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 199956 199956 0 0.0
.comment 206 206 0 0.0
.data 1412 1412 0 0.0
.debug_abbrev 903134 903134 0 0.0
.debug_aranges 104328 104328 0 0.0
.debug_frame 351292 351292 0 0.0
.debug_info 19452487 19452487 0 0.0
.debug_line 2592989 2592989 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1578966 1578966 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107629 107629 0 0.0
.debug_str 3391562 3391562 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 83674 83674 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 467751 467751 0 0.0
.symtab 279216 279216 0 0.0
.text 476304 476304 0 0.0
lock CC3235SF_LAUNCHXL (read only) 618282 618282 0 0.0
(read/write) 206896 206896 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200336 200336 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 943794 943794 0 0.0
.debug_aranges 108792 108792 0 0.0
.debug_frame 366572 366572 0 0.0
.debug_info 20629203 20629203 0 0.0
.debug_line 2663362 2663362 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1634657 1634657 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 112166 112166 0 0.0
.debug_str 3455748 3455748 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106242 106242 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 516987 516987 0 0.0
.symtab 298832 298832 0 0.0
.text 0 0 0 0.0
509916 509916 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 553039 553039 0 0.0
.app_xip_area 444257 444257 0 0.0
.bss 63752 63752 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 539143 539143 0 0.0
.app_xip_area 425561 425561 0 0.0
.bss 68520 68520 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574591 574591 0 0.0
.app_xip_area 467137 467137 0 0.0
.bss 62496 62496 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 550895 550895 0 0.0
.app_xip_area 440353 440353 0 0.0
.bss 65488 65488 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1006560 1006560 0 0.0
.bss 171920 171920 0 0.0
.data 2692 2692 0 0.0
.text 831928 831928 0 0.0
BRD4187C (read/write) 1092792 1092792 0 0.0
.bss 195484 195484 0 0.0
.data 3300 3300 0 0.0
.text 893988 893988 0 0.0
lock-app BRD4161A+wf200 (read/write) 1104056 1104056 0 0.0
.bss 186632 186632 0 0.0
.data 2708 2708 0 0.0
.text 914692 914692 0 0.0
window-app BRD4187C (read/write) 1128740 1128740 0 0.0
.bss 167900 167900 0 0.0
.data 3172 3172 0 0.0
.text 957648 957648 0 0.0
esp32 all-clusters-app c3devkit (read only) 1133016 1133016 0 0.0
(read/write) 1670388 1670388 0 0.0
.dram0.bss 71904 71904 0 0.0
.dram0.data 13020 13020 0 0.0
.flash.rodata 241600 241600 0 0.0
.flash.text 1133016 1133016 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1177531 1177531 0 0.0
(read/write) 520292 520292 0 0.0
.dram0.bss 78552 78552 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 273340 273340 0 0.0
.flash.text 1172147 1172147 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 589892 589892 0 0.0
(read/write) 87508 87508 0 0.0
.bss 70752 70752 0 0.0
.data 2132 2132 0 0.0
.text 589356 589356 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 684788 684788 0 0.0
.bss 66952 66952 0 0.0
.data 2716 2716 0 0.0
.text 571640 571640 0 0.0
light k32w0+release (read only) 589596 589596 0 0.0
(read/write) 87184 87184 0 0.0
.bss 70440 70440 0 0.0
.data 2120 2120 0 0.0
.text 589060 589060 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 776744 776744 0 0.0
.bss 76628 76628 0 0.0
.data 1928 1928 0 0.0
.text 654728 654728 0 0.0
lock k32w0+release (read only) 561356 561356 0 0.0
(read/write) 85012 85012 0 0.0
.bss 68328 68328 0 0.0
.data 2060 2060 0 0.0
.text 560820 560820 0 0.0
linux air-purifier-app debug (read only) 2469485 2469485 0 0.0
(read/write) 126232 126232 0 0.0
.bss 46608 46608 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72152 72152 0 0.0
.dynamic 608 608 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 177280 177280 0 0.0
.text 2118357 2118357 0 0.0
all-clusters-app debug (read only) 5291889 5291889 0 0.0
(read/write) 417304 417304 0 0.0
.bss 128944 128944 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 277280 277280 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 300012 300012 0 0.0
.text 4613027 4613027 0 0.0
all-clusters-minimal-app debug (read only) 4884553 4884553 0 0.0
(read/write) 232984 232984 0 0.0
.bss 126672 126672 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 95424 95424 0 0.0
.dynamic 624 624 0 0.0
.got 5320 5320 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 270237 270237 0 0.0
.text 4383171 4383171 0 0.0
bridge-app debug (read only) 4366185 4366185 0 0.0
(read/write) 215096 215096 0 0.0
.bss 118872 118872 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84752 84752 0 0.0
.dynamic 624 624 0 0.0
.got 5288 5288 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 218173 218173 0 0.0
.text 3930355 3930355 0 0.0
chip-tool debug (read only) 10295049 10295049 0 0.0
(read/write) 445632 445632 0 0.0
.bss 93720 93720 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 339704 339704 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 387401 387401 0 0.0
.text 9306403 9306403 0 0.0
chip-tool-ipv6only arm64 (read only) 10178104 10178104 0 0.0
(read/write) 509744 509744 0 0.0
.bss 103048 103048 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 377160 377160 0 0.0
.dynamic 512 512 0 0.0
.got 18552 18552 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 316128 316128 0 0.0
.text 9087816 9087816 0 0.0
lighting-app debug+rpc+ui (read only) 5225193 5225193 0 0.0
(read/write) 223088 223088 0 0.0
.bss 118160 118160 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 92960 92960 0 0.0
.dynamic 672 672 0 0.0
.got 5904 5904 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 336596 336596 0 0.0
.text 4645347 4645347 0 0.0
lock-app debug (read only) 4465753 4465753 0 0.0
(read/write) 203224 203224 0 0.0
.bss 113392 113392 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79432 79432 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 247517 247517 0 0.0
.text 4008611 4008611 0 0.0
ota-provider-app debug (read only) 4121657 4121657 0 0.0
(read/write) 192160 192160 0 0.0
.bss 113536 113536 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68784 68784 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 199805 199805 0 0.0
.text 3730979 3730979 0 0.0
ota-requestor-app debug (read only) 4207121 4207121 0 0.0
(read/write) 196344 196344 0 0.0
.bss 114560 114560 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 71728 71728 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 203261 203261 0 0.0
.text 3808707 3808707 0 0.0
shell debug (read only) 2757841 2757841 0 0.0
(read/write) 149088 149088 0 0.0
.bss 59592 59592 0 0.0
.data 816 816 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180960 180960 0 0.0
.text 2406194 2406194 0 0.0
thermostat-no-ble arm64 (read only) 4359472 4359472 0 0.0
(read/write) 245888 245888 0 0.0
.bss 122168 122168 0 0.0
.data 2792 2792 0 0.0
.data.rel.ro 101608 101608 0 0.0
.dynamic 512 512 0 0.0
.got 11896 11896 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161292 161292 0 0.0
.text 3859464 3859464 0 0.0
tv-app debug (read only) 5289913 5289913 0 0.0
(read/write) 352016 352016 0 0.0
.bss 243104 243104 0 0.0
.data 5024 5024 0 0.0
.data.rel.ro 96512 96512 0 0.0
.dynamic 624 624 0 0.0
.got 5584 5584 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 271277 271277 0 0.0
.text 4774531 4774531 0 0.0
tv-casting-app debug (read only) 8239937 8239937 0 0.0
(read/write) 314488 314488 0 0.0
.bss 155872 155872 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 149296 149296 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 337656 337656 0 0.0
.text 7496899 7496899 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522968 2522968 0 0.0
.bss 219048 219048 0 0.0
.data 5136 5136 0 0.0
.text 1485652 1485652 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1179744 1179744 0 0.0
bss 153980 153980 0 0.0
rodata 118844 118844 0 0.0
text 828016 828016 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1327228 1327228 0 0.0
bss 139990 139990 0 0.0
rodata 134908 134908 0 0.0
text 761684 761684 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1161504 1161504 0 0.0
bss 154219 154219 0 0.0
rodata 113828 113828 0 0.0
text 814540 814540 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 838136 838136 0 0.0
(read/write) 1723540 1723540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 192708 192708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2496 2496 0 0.0
.debug_abbrev 1327158 1327158 0 0.0
.debug_aranges 141008 141008 0 0.0
.debug_frame 467156 467156 0 0.0
.debug_info 30280930 30280930 0 0.0
.debug_line 3898558 3898558 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2245367 2245367 0 0.0
.debug_rnglists 151730 151730 0 0.0
.debug_str 4118416 4118416 0 0.0
.heap 838136 838136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 798235 798235 0 0.0
.symtab 494048 494048 0 0.0
.text 0 0 0 0.0
1519948 1519948 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839936 839936 0 0.0
(read/write) 1682060 1682060 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190932 190932 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1267368 1267368 0 0.0
.debug_aranges 137224 137224 0 0.0
.debug_frame 460544 460544 0 0.0
.debug_info 28552708 28552708 0 0.0
.debug_line 3803635 3803635 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2189783 2189783 0 0.0
.debug_rnglists 147545 147545 0 0.0
.debug_str 4011153 4011153 0 0.0
.heap 839936 839936 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 742590 742590 0 0.0
.symtab 475104 475104 0 0.0
.text 1480268 1480268 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846488 846488 0 0.0
(read/write) 1608236 1608236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184492 184492 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2360 2360 0 0.0
.debug_abbrev 1109046 1109046 0 0.0
.debug_aranges 127296 127296 0 0.0
.debug_frame 423468 423468 0 0.0
.debug_info 23670450 23670450 0 0.0
.debug_line 3377965 3377965 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2026268 2026268 0 0.0
.debug_rnglists 137091 137091 0 0.0
.debug_str 3817975 3817975 0 0.0
.heap 846488 846488 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 655759 655759 0 0.0
.symtab 436608 436608 0 0.0
.text 1412996 1412996 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 819224 819224 0 0.0
(read/write) 1641044 1641044 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211740 211740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2376 2376 0 0.0
.debug_abbrev 1101892 1101892 0 0.0
.debug_aranges 125976 125976 0 0.0
.debug_frame 418704 418704 0 0.0
.debug_info 23480129 23480129 0 0.0
.debug_line 3330301 3330301 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2003000 2003000 0 0.0
.debug_rnglists 135114 135114 0 0.0
.debug_str 3780235 3780235 0 0.0
.heap 819224 819224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 629264 629264 0 0.0
.symtab 428144 428144 0 0.0
.text 1418540 1418540 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177108 1177108 0 0.0
.bss 100608 100608 0 0.0
.data 744 744 0 0.0
.text 623952 623952 0 0.0
lock-app qpg6105+debug (read/write) 1133588 1133588 0 0.0
.bss 95288 95288 0 0.0
.data 748 748 0 0.0
.text 580428 580428 0 0.0
telink air-quality-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 856900 856900 0 0.0
bss 77996 77996 0 0.0
text 604454 604454 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1078520 1078520 0 0.0
bss 112632 112632 0 0.0
text 758132 758132 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1077172 1077172 0 0.0
bss 122460 122460 0 0.0
text 744604 744604 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932204 932204 0 0.0
bss 106876 106876 0 0.0
text 641650 641650 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 860304 860304 0 0.0
bss 78120 78120 0 0.0
text 607552 607552 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 962432 962432 0 0.0
bss 88184 88184 0 0.0
text 683970 683970 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1088200 1088200 0 0.0
bss 112384 112384 0 0.0
text 762322 762322 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 918720 918720 0 0.0
bss 78812 78812 0 0.0
text 638380 638380 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945548 945548 0 0.0
bss 104976 104976 0 0.0
text 657452 657452 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 864128 864128 0 0.0
bss 78228 78228 0 0.0
text 611726 611726 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 804988 804988 0 0.0
bss 66248 66248 0 0.0
text 578762 578762 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 820704 820704 0 0.0
bss 66652 66652 0 0.0
text 589374 589374 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 709036 709036 0 0.0
bss 86424 86424 0 0.0
text 462008 462008 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 862900 862900 0 0.0
bss 78204 78204 0 0.0
text 611088 611088 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 847944 847944 0 0.0
bss 77932 77932 0 0.0
text 598260 598260 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 826072 826072 0 0.0
bss 66536 66536 0 0.0
text 594116 594116 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 823536 823536 0 0.0
bss 66888 66888 0 0.0
text 591166 591166 0 0.0

@mergify mergify bot merged commit 739f72a into project-chip:master Oct 30, 2023
54 checks passed
@yufengwangca yufengwangca deleted the pr/kotlin/timed branch October 30, 2023 22:06
fengdx4 pushed a commit to fengdx4/connectedhomeip that referenced this pull request Oct 31, 2023
@yufengwangca @mideayanghui
Make timedInvokeTimeoutMs optional (project-chip#30099)
59eedbd
shripad621git pushed a commit to shripad621git/connectedhomeip that referenced this pull request Oct 31, 2023
@yufengwangca @shripad621git
Make timedInvokeTimeoutMs optional (project-chip#30099)
d6ce9d5
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
@fengdx4 @mideayanghui
@restyled-commits @dependabot @andy31415 @adabreuti @yufengwangca @wqx6 @kkasperczyk-no
Add microwave oven mode cluster xml (#30018)
c2fae17 
* add microwave oven mode cluster xml

* zap generated

* Restyled by prettier-json

* update cluster-revision

* updated MicorwaveOvenMode for mode-base-cluster.xml

* Bump third_party/imgui/repo from `001f102` to `88fec09` (#30086)

Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `001f102` to `88fec09`.
- [Release notes](https://github.com/ocornut/imgui/releases)
- [Commits](ocornut/imgui@001f102...88fec09)

---
updated-dependencies:
- dependency-name: third_party/imgui/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump third_party/libwebsockets/repo from `a1cbc02` to `816544f` (#30083)

Bumps [third_party/libwebsockets/repo](https://github.com/warmcat/libwebsockets) from `a1cbc02` to `816544f`.
- [Commits](warmcat/libwebsockets@a1cbc02...816544f)

---
updated-dependencies:
- dependency-name: third_party/libwebsockets/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump third_party/ot-br-posix/repo from `69ce2a5` to `184d298` (#30084)

Bumps [third_party/ot-br-posix/repo](https://github.com/openthread/ot-br-posix) from `69ce2a5` to `184d298`.
- [Release notes](https://github.com/openthread/ot-br-posix/releases)
- [Commits](openthread/ot-br-posix@69ce2a5...184d298)

---
updated-dependencies:
- dependency-name: third_party/ot-br-posix/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Make `Power source configuration cluster` match the spec (minor type change) (#30062)

* Type of sources should be endpoint_no instead of raw int8u

* Zap regen

* Make `Localization Configuration Cluster` match the spec (#30058)

* Switch XML to get manage privilege for activeLocale write

* ZAP regen

* [TI] Feature ti sysconfig 1 16 2 update (#30073)

* Update README Files to reference latest SYSCONFIG Version

* Update Sysconfig version for CI

* Update docker version

* [Kotlin] Uses Kotlin's coroutines to handle the asynchronous operation and returns the result directly  (#30082)

* Update the kotlin type mapping

* Remove callback from fun

* Update `Temperature Measurement Cluster` to spec (#30093)

* Update data type

* ZAP regen

* esp32: make the shell command line buffer size configurable (#30050)

* [nrfconnect] Updated nRF Connect SDK version in Docker to 2.5.0 (#30051)

Regular update of nRF Connect SDK to 2.5.0 version including
zephyr toolchain and west versions bump.

* Make timedInvokeTimeoutMs optional (#30099)

* fix MicrowaveOvenMode xml files and re-commit

* fix adding MicrowaveOvenMode xml environment problem

* revised MicrowaveOvenMode xml for the value of revision

* commit to revise revision value and fix environment problem for MicrowaveOvenMode

* revised merged src/controller/data_model/BUILD.gn

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: mideayanghui <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: adabreuti <[email protected]>
Co-authored-by: Yufeng Wang <[email protected]>
Co-authored-by: Wang Qixiang <[email protected]>
Co-authored-by: Kamil Kasperczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@tehampson tehampson tehampson approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @tehampson @Damian-Nordic