Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make group cluster match the spec #30056

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Make group cluster match the spec #30056

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b00983
Set the max length of the group name in command arguments
andy31415 Oct 27, 2023
14ee560
ZAP regen
andy31415 Oct 27, 2023
4d0d858
minor change to kick CI
andy31415 Oct 27, 2023
835dd06
NOOP change to kick ci
andy31415 Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions ...irpurifier_airqualitysensor_temperaturesensor_humiditysensor_thermostat_56de3d5f45.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_contactsensor_lFAGG1bfRO.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_fan_7N2TobIlOX.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_flowsensor_1zVxHedlaV.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ client cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -76,7 +76,7 @@ client cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

request struct GetGroupMembershipRequest {
Expand All @@ -99,7 +99,7 @@ client cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

/** Command description for AddGroup */
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_humiditysensor_Xyj4gda6Hb.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ client cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -76,7 +76,7 @@ client cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

request struct GetGroupMembershipRequest {
Expand All @@ -99,7 +99,7 @@ client cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

/** Command description for AddGroup */
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_lightsensor_lZQycTFcJK.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ client cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -76,7 +76,7 @@ client cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

request struct GetGroupMembershipRequest {
Expand All @@ -99,7 +99,7 @@ client cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

/** Command description for AddGroup */
Expand Down
Loading
Loading